From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: hangcheck parameter
Date: Wed, 22 Jun 2011 18:45:56 +0100 [thread overview]
Message-ID: <d08817$g5q74@azsmga001.ch.intel.com> (raw)
In-Reply-To: <1308763970-2989-1-git-send-email-ben@bwidawsk.net>
On Wed, 22 Jun 2011 10:32:50 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> The hangcheck is undesirable when doing shader debugging. The debugger
> interacts with the EU, and these may cause the hangcheck to fire at most
> unfortunate times.
>
> This provides a way to let the user disable the hangcheck when they want
> to do shader debugging.
Looks like a reasonable idea, I'm tempted to suggest to make it the period
in ms rather a boolean. But for actual use, either a new ioctl for
enable/disable or another wakelock? Just in case we have more than one
program trying to debug at the same time. (Not so far fetched, as the user
may be snooping on the results whilst debugging in another process?)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-06-22 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 17:32 [PATCH] drm/i915: hangcheck parameter Ben Widawsky
2011-06-22 17:45 ` Chris Wilson [this message]
2011-06-22 17:55 ` Ben Widawsky
2011-06-22 18:05 ` Chris Wilson
2011-06-22 23:07 ` [PATCH 1/2] drm/i915: hangcheck disable flag Ben Widawsky
2011-06-22 23:07 ` [PATCH 2/2] drm/i915: debugger debugfs entry Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='d08817$g5q74@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.