All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>
Cc: Linux-pm mailing list
	<linux-pm-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
	Vojtech Pavlik <vojtech-AlSwsSmVLrQ@public.gmane.org>,
	Stefan Seyfried <seife-l3A5Bk7waGM@public.gmane.org>,
	kernel list
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Andy Isaacson <adi-3HqRAUrWAWyGglJvpFV4uA@public.gmane.org>
Subject: Re: swsusp 'disk' fails in bk-current - intel_agp at fault?
Date: Tue, 29 Mar 2005 16:33:04 -0500	[thread overview]
Message-ID: <d120d50005032913331be39802@mail.gmail.com> (raw)
In-Reply-To: <20050329211239.GG8125-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>

On Tue, 29 Mar 2005 23:12:39 +0200, Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org> wrote:
> >
> > I am leaning towards calling disable_usermodehelper (not writtent yet)
> > after swsusp completes snapshotting memory. We really don't care about
> > hotplug events in this case and this will allow keeping "normal"
> > resume in drivers as is. What do you think?
> 
> That would certianly do the trick.
> 
> [Or perhaps in_suspend() is slightly nicer solution? People wanted it
> for other stuff (sanity checking, like BUG_ON(in_suspend())), too....]
> 

We might want having both... Hmm... in_suspend - is it only for swsusp
(in_swsusp) or for suspend-to-ram as well? For suspend to ram we might
need slightly different rules, I don't know. A separate call will
allow more fine-grained control and will explicitely tell reader what
is happening.

I do not have a strong preference though.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Stefan Seyfried <seife@suse.de>,
	Andy Isaacson <adi@hexapodia.org>,
	kernel list <linux-kernel@vger.kernel.org>,
	Vojtech Pavlik <vojtech@suse.cz>,
	Linux-pm mailing list <linux-pm@lists.osdl.org>
Subject: Re: swsusp 'disk' fails in bk-current - intel_agp at fault?
Date: Tue, 29 Mar 2005 16:33:04 -0500	[thread overview]
Message-ID: <d120d50005032913331be39802@mail.gmail.com> (raw)
In-Reply-To: <20050329211239.GG8125@elf.ucw.cz>

On Tue, 29 Mar 2005 23:12:39 +0200, Pavel Machek <pavel@suse.cz> wrote:
> >
> > I am leaning towards calling disable_usermodehelper (not writtent yet)
> > after swsusp completes snapshotting memory. We really don't care about
> > hotplug events in this case and this will allow keeping "normal"
> > resume in drivers as is. What do you think?
> 
> That would certianly do the trick.
> 
> [Or perhaps in_suspend() is slightly nicer solution? People wanted it
> for other stuff (sanity checking, like BUG_ON(in_suspend())), too....]
> 

We might want having both... Hmm... in_suspend - is it only for swsusp
(in_swsusp) or for suspend-to-ram as well? For suspend to ram we might
need slightly different rules, I don't know. A separate call will
allow more fine-grained control and will explicitely tell reader what
is happening.

I do not have a strong preference though.

-- 
Dmitry

  parent reply	other threads:[~2005-03-29 21:33 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-23 18:49 swsusp 'disk' fails in bk-current - intel_agp at fault? Andy Isaacson
2005-03-24 14:27 ` Stefan Seyfried
2005-03-24 18:10   ` Andy Isaacson
2005-03-24 19:18     ` Dmitry Torokhov
2005-03-24 20:20       ` Andy Isaacson
2005-03-24 21:10         ` Dmitry Torokhov
2005-03-24 23:54           ` Andy Isaacson
2005-03-25  9:22             ` Stefan Seyfried
2005-03-25 10:13               ` Pavel Machek
2005-03-25 14:19                 ` Dmitry Torokhov
2005-03-25 14:24                   ` Pavel Machek
2005-03-25 14:52                     ` Dmitry Torokhov
2005-03-25 15:42                       ` Pavel Machek
2005-03-25 16:04                         ` Dmitry Torokhov
2005-03-28 23:00                           ` Pavel Machek
2005-03-29 23:19                           ` Rafael J. Wysocki
2005-03-29 21:49                       ` Rafael J. Wysocki
2005-03-25 18:36                 ` Andy Isaacson
2005-03-29 16:18               ` Dmitry Torokhov
2005-03-29 18:18                 ` Pavel Machek
2005-03-29 19:11                   ` Dmitry Torokhov
2005-03-29 19:23                     ` Pavel Machek
2005-03-29 20:05                       ` Dmitry Torokhov
     [not found]                         ` <d120d50005032912051fee6e91-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-03-29 20:52                           ` Pavel Machek
2005-03-29 20:52                             ` Pavel Machek
     [not found]                             ` <20050329205225.GF8125-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-29 21:07                               ` Dmitry Torokhov
2005-03-29 21:07                                 ` Dmitry Torokhov
     [not found]                                 ` <d120d500050329130714e1daaf-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-03-29 21:12                                   ` Pavel Machek
2005-03-29 21:12                                     ` Pavel Machek
     [not found]                                     ` <20050329211239.GG8125-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-29 21:33                                       ` Dmitry Torokhov [this message]
2005-03-29 21:33                                         ` Dmitry Torokhov
     [not found]                                         ` <d120d50005032913331be39802-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-03-29 21:44                                           ` Pavel Machek
2005-03-29 21:44                                             ` Pavel Machek
     [not found]                                             ` <20050329214408.GH8125-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-29 22:31                                               ` Nigel Cunningham
2005-03-29 22:31                                                 ` [linux-pm] " Nigel Cunningham
     [not found]                                                 ` <1112135477.29392.16.camel-r49W/1Cwd2ff0s6lnCXPX/uOuaPYTxhvJwvTLr3MMZM@public.gmane.org>
2005-03-29 22:35                                                   ` Pavel Machek
2005-03-29 22:35                                                     ` [linux-pm] " Pavel Machek
     [not found]                                                     ` <20050329223519.GI8125-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-29 23:46                                                       ` Nigel Cunningham
2005-03-29 23:46                                                         ` [linux-pm] " Nigel Cunningham
2005-03-31  7:26                                                       ` Dmitry Torokhov
2005-03-31  7:26                                                         ` [linux-pm] " Dmitry Torokhov
     [not found]                                                         ` <200503310226.03495.dtor_core-yWtbtysYrB+LZ21kGMrzwg@public.gmane.org>
2005-03-31  8:39                                                           ` Pavel Machek
2005-03-31  8:39                                                             ` [linux-pm] " Pavel Machek
     [not found]                                                             ` <20050331083909.GA1387-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-31 15:02                                                               ` Dmitry Torokhov
2005-03-31 15:02                                                                 ` [linux-pm] " Dmitry Torokhov
2005-03-31 16:02                                                           ` Patrick Mochel
2005-03-31 16:02                                                             ` [linux-pm] " Patrick Mochel
     [not found]                                                             ` <Pine.LNX.4.50.0503310801410.15519-100000-x8k/2hhmB0w5etPau2IXcQ@public.gmane.org>
2005-03-31 16:32                                                               ` Dmitry Torokhov
2005-03-31 16:32                                                                 ` [linux-pm] " Dmitry Torokhov
     [not found]                                                                 ` <d120d50005033108321c8f4ae7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-03-31 22:16                                                                   ` Nigel Cunningham
2005-03-31 22:16                                                                     ` [linux-pm] " Nigel Cunningham
2005-03-31 22:18                                                                   ` Pavel Machek
2005-03-31 22:18                                                                     ` [linux-pm] " Pavel Machek
     [not found]                                                                     ` <20050331221814.GC1802-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-31 22:28                                                                       ` Nigel Cunningham
2005-03-31 22:28                                                                         ` [linux-pm] " Nigel Cunningham
     [not found]                                                                         ` <1112308137.18871.7.camel-r49W/1Cwd2ff0s6lnCXPX/uOuaPYTxhvJwvTLr3MMZM@public.gmane.org>
2005-04-01  8:49                                                                           ` Rafael J. Wysocki
2005-04-01  8:49                                                                             ` [linux-pm] " Rafael J. Wysocki
     [not found]                                                                             ` <200504011049.01540.rjw-KKrjLPT3xs0@public.gmane.org>
2005-04-01 10:33                                                                               ` Stefan Seyfried
2005-04-01 10:33                                                                                 ` [linux-pm] " Stefan Seyfried
2005-03-29 23:05                                       ` Rafael J. Wysocki
2005-03-29 23:05                                         ` Rafael J. Wysocki
2005-03-29 21:23                               ` Patrick Mochel
2005-03-29 21:23                                 ` [linux-pm] " Patrick Mochel
     [not found]                                 ` <Pine.LNX.4.50.0503291321490.29474-100000-x8k/2hhmB0w5etPau2IXcQ@public.gmane.org>
2005-03-29 21:38                                   ` Dmitry Torokhov
2005-03-29 21:38                                     ` [linux-pm] " Dmitry Torokhov
2005-03-30  9:52                                   ` Greg KH
2005-03-30  9:52                                     ` [linux-pm] " Greg KH
2005-03-25 14:58             ` Dmitry Torokhov
2005-03-30  7:26               ` Andy Isaacson
2005-03-24 21:14         ` Dmitry Torokhov
2005-03-24 20:38     ` Stefan Seyfried
2005-03-29 18:42       ` Dmitry Torokhov
2005-03-30  7:24         ` Andy Isaacson
     [not found] ` <20050525171825.51a06908.akpm@osdl.org>
2005-05-27 17:44   ` Andy Isaacson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d50005032913331be39802@mail.gmail.com \
    --to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=adi-3HqRAUrWAWyGglJvpFV4uA@public.gmane.org \
    --cc=dtor_core-yWtbtysYrB+LZ21kGMrzwg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=pavel-AlSwsSmVLrQ@public.gmane.org \
    --cc=seife-l3A5Bk7waGM@public.gmane.org \
    --cc=vojtech-AlSwsSmVLrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.