* [PATCH] Amiga joystick typo (was: Re: Input: fix open/close races in joystick drivers - add a semaphore) [not found] <200506280052.j5S0qDQT010792@hera.kernel.org> @ 2005-07-13 10:56 ` Geert Uytterhoeven 2005-07-13 14:11 ` Dmitry Torokhov 0 siblings, 1 reply; 3+ messages in thread From: Geert Uytterhoeven @ 2005-07-13 10:56 UTC (permalink / raw) To: Dmitry Torokhov, Linus Torvalds, Andrew Morton; +Cc: Linux Kernel Development On Mon, 27 Jun 2005, Linux Kernel Mailing List wrote: > tree 11d80109ddc2f61de6a75a37941346100a67a0d1 > parent af246041277674854383cf91b8f0b01217b521e8 > author Dmitry Torokhov <dtor_core@ameritech.net> Sun, 29 May 2005 12:29:52 -0500 > committer Dmitry Torokhov <dtor_core@ameritech.net> Sun, 29 May 2005 12:29:52 -0500 > > Input: fix open/close races in joystick drivers - add a semaphore > to the ones that register more than one input device. > > Signed-off-by: Dmitry Torokhov <dtor@mail.ru> > > drivers/input/joystick/amijoy.c | 29 ++++++++++++++++------------- This patch broke compilation of amijoy. Trivial fix below. Amiga joystick: Fix typo introduced by fixing the open/close races in 2.6.13-rc1 Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- linux-2.6.13-rc1/drivers/input/joystick/amijoy.c 2005-06-29 22:15:20.000000000 +0200 +++ linux-m68k-2.6.13-rc1/drivers/input/joystick/amijoy.c 2005-07-12 13:20:20.000000000 +0200 @@ -105,7 +105,7 @@ out: static void amijoy_close(struct input_dev *dev) { - down(&amijoysem); + down(&amijoy_sem); if (!--amijoy_used) free_irq(IRQ_AMIGA_VERTB, amijoy_interrupt); up(&amijoy_sem); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Amiga joystick typo (was: Re: Input: fix open/close races in joystick drivers - add a semaphore) 2005-07-13 10:56 ` [PATCH] Amiga joystick typo (was: Re: Input: fix open/close races in joystick drivers - add a semaphore) Geert Uytterhoeven @ 2005-07-13 14:11 ` Dmitry Torokhov 2005-07-13 16:28 ` Geert Uytterhoeven 0 siblings, 1 reply; 3+ messages in thread From: Dmitry Torokhov @ 2005-07-13 14:11 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Dmitry Torokhov, Linus Torvalds, Andrew Morton, Linux Kernel Development On 7/13/05, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Mon, 27 Jun 2005, Linux Kernel Mailing List wrote: > > tree 11d80109ddc2f61de6a75a37941346100a67a0d1 > > parent af246041277674854383cf91b8f0b01217b521e8 > > author Dmitry Torokhov <dtor_core@ameritech.net> Sun, 29 May 2005 12:29:52 -0500 > > committer Dmitry Torokhov <dtor_core@ameritech.net> Sun, 29 May 2005 12:29:52 -0500 > > > > Input: fix open/close races in joystick drivers - add a semaphore > > to the ones that register more than one input device. > > > > Signed-off-by: Dmitry Torokhov <dtor@mail.ru> > > > > drivers/input/joystick/amijoy.c | 29 ++++++++++++++++------------- > > This patch broke compilation of amijoy. Trivial fix below. > Sorry about that. Question - if I were to build a cross-compiler for amiga what arch is that? Right now I am "compiling" for i386 and hope that I will catch some real errors in between complaints about missing include files and definitions... -- Dmitry ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Amiga joystick typo (was: Re: Input: fix open/close races in joystick drivers - add a semaphore) 2005-07-13 14:11 ` Dmitry Torokhov @ 2005-07-13 16:28 ` Geert Uytterhoeven 0 siblings, 0 replies; 3+ messages in thread From: Geert Uytterhoeven @ 2005-07-13 16:28 UTC (permalink / raw) To: dtor_core; +Cc: Dmitry Torokhov, Linux Kernel Development On Wed, 13 Jul 2005, Dmitry Torokhov wrote: > On 7/13/05, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Mon, 27 Jun 2005, Linux Kernel Mailing List wrote: > > > tree 11d80109ddc2f61de6a75a37941346100a67a0d1 > > > parent af246041277674854383cf91b8f0b01217b521e8 > > > author Dmitry Torokhov <dtor_core@ameritech.net> Sun, 29 May 2005 12:29:52 -0500 > > > committer Dmitry Torokhov <dtor_core@ameritech.net> Sun, 29 May 2005 12:29:52 -0500 > > > > > > Input: fix open/close races in joystick drivers - add a semaphore > > > to the ones that register more than one input device. > > > > > > Signed-off-by: Dmitry Torokhov <dtor@mail.ru> > > > > > > drivers/input/joystick/amijoy.c | 29 ++++++++++++++++------------- > > > > This patch broke compilation of amijoy. Trivial fix below. > > > > Sorry about that. Question - if I were to build a cross-compiler for > amiga what arch is that? Right now I am "compiling" for i386 and hope > that I will catch some real errors in between complaints about missing > include files and definitions... That's either m68k for original Amigas, or ppc for Amigas equipped with an APUS (Amiga Power Up System) CPU upgrade card. Unfortunately both of them are broken in the main tree. For m68k, our tree is at http://linux-m68k-cvs.ubb.ca/. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-07-13 16:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200506280052.j5S0qDQT010792@hera.kernel.org>
2005-07-13 10:56 ` [PATCH] Amiga joystick typo (was: Re: Input: fix open/close races in joystick drivers - add a semaphore) Geert Uytterhoeven
2005-07-13 14:11 ` Dmitry Torokhov
2005-07-13 16:28 ` Geert Uytterhoeven
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.