Re: [PATCH u-boot, v2019.04-aspeed-openbmc v1 1/1] ARM: dts: Aspeed: Add Facebook common dts

[Andrew Jeffery <andrew@codeconstruct.com.au>]

On Thu, 2024-05-16 at 20:19 -0500, Patrick Williams wrote:
> 
> I don't currently have a lot of faith that if we sent a trivial "add the
> new compatible" that it would be accepted in a timely manner.

Well, I'm responding to the patch because I intend to help you get it
merged. I'm trying to keep on top of the patches people send these
days. Can we give it a chance?

> 
> > > 
> > > Should we do something like "facebook,ast2600-standard"?
> > > 
> > 
> > I guess I'm trying to guard-rail the discussion from the position of
> > the compatible strings should be documented in the DT schemas. Is this
> > something that would pass review upstream?
> 
> I don't know?  We're so far removed from upstream at this point that I
> see that as aspirational.  (Everyone using AST2600 is using u-boot
> 2019.04, which was 5 years ago.)

Sure, the tree is not in good shape. However, that doesn't mean we
should go adding fuel to the fire?

> 
> Having said all this, I would love to do things as "right" as possible
> while still being able to make progress.  What is the right step?
> 

That's what I'm trying to figure out in this discussion :) Currently my
thought is "better to keep things concrete and describe actual
platforms", rather than "make up a name for something that vaguely
exists only in principle". I asked about upstream because that allows
you to escape my thoughts and drive the patch through on someone else's
acceptance of your proposal :)

Andrew