Re: [PATCH u-boot, v2019.04-aspeed-openbmc v1 1/1] ARM: dts: Aspeed: Add Facebook common dts

[Andrew Jeffery <andrew@codeconstruct.com.au>]

On Mon, 2024-05-13 at 22:49 +0800, Peter Yin wrote:
> Initial introduction of Facebook common
> equipped with Aspeed 2600 BMC SoC.
> 
> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
> ---
>  arch/arm/dts/Makefile       |  1 +
>  arch/arm/dts/ast2600-fb.dts | 66 +++++++++++++++++++++++++++++++++++++
>  2 files changed, 67 insertions(+)
>  create mode 100644 arch/arm/dts/ast2600-fb.dts
> 
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 6f4b4d8a17..3740a4452d 100755
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -686,6 +686,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>  	ast2600-dcscm.dtb \
>  	ast2600-evb-ecc.dtb \
>  	ast2600-evb.dtb \
> +	ast2600-fb.dtb \
>  	ast2600-fpga.dtb \
>  	ast2600-greatlakes.dtb \
>  	ast2600-intel.dtb \
> diff --git a/arch/arm/dts/ast2600-fb.dts b/arch/arm/dts/ast2600-fb.dts
> new file mode 100644
> index 0000000000..69ff575419
> --- /dev/null
> +++ b/arch/arm/dts/ast2600-fb.dts
> @@ -0,0 +1,66 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +// Copyright (c) 2023 Meta Platforms Inc.
> +/dts-v1/;
> +
> +#include "ast2600-u-boot.dtsi"
> +
> +/ {
> +	model = "Facebook Common BMC";
> +	compatible = "facebook,common-bmc", "aspeed,ast2600";

I'm not convinced about "facebook,common-bmc" as a compatible. Is there
actually a reason to specify anything here other than "aspeed,ast2600"?

Alternatively, perhaps list all the relevant platforms, like the p10bmc
dts?

```
$ git grep aspeed,ast2600 arch/arm/dts/ast2600-p10bmc.dts
arch/arm/dts/ast2600-p10bmc.dts:        compatible = "ibm,everest-bmc", "ibm,rainier-bmc", "ibm,p10bmc", "aspeed,ast2600";
```

Andrew