Missing signoff in the drivers-x86 tree

Missing signoff in the drivers-x86 tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

Commits

  4dabecbb202e8 ("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")
  9af7fddef448d ("platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()")

are missing a Signed-off-by from their authors

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoff in the drivers-x86 tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

On Thu, Sep 24, 2026 at 11:53:54AM +0100, Mark Brown wrote:
> Commits
> 
>   4dabecbb202e8 ("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")
>   9af7fddef448d ("platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()")
> 
> are missing a Signed-off-by from their authors

This issue is still present today.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoff in the drivers-x86 tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

On Mon, Sep 28, 2026 at 03:37:30PM +0100, Mark Brown wrote:
> On Thu, Sep 24, 2026 at 11:53:54AM +0100, Mark Brown wrote:
> > Commits
> > 
> >   4dabecbb202e8 ("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")
> >   9af7fddef448d ("platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()")
> > 
> > are missing a Signed-off-by from their authors
> 
> This issue is still present today.

And today.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Missing signoff in the drivers-x86 tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

On Mon, Oct 05, 2026 at 02:52:50PM +0200, Mark Brown wrote:
> On Mon, Sep 28, 2026 at 03:37:30PM +0100, Mark Brown wrote:
> > On Thu, Sep 24, 2026 at 11:53:54AM +0100, Mark Brown wrote:
> > > Commits
> > > 
> > >   4dabecbb202e8 ("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")
> > >   9af7fddef448d ("platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()")
> > > 
> > > are missing a Signed-off-by from their authors
> > 
> > This issue is still present today.
> 
> And today.

And today - should Ilpo be added to the list of contacts for this tree?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoff in the drivers-x86 tree

[Ilpo Järvinen]

On Mon, 12 Oct 2026, Mark Brown wrote:

> On Mon, Oct 05, 2026 at 02:52:50PM +0200, Mark Brown wrote:
> > On Mon, Sep 28, 2026 at 03:37:30PM +0100, Mark Brown wrote:
> > > On Thu, Sep 24, 2026 at 11:53:54AM +0100, Mark Brown wrote:
> > > > Commits
> > > > 
> > > >   4dabecbb202e8 ("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")
> > > >   9af7fddef448d ("platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()")
> > > > 
> > > > are missing a Signed-off-by from their authors
> > > 
> > > This issue is still present today.
> > 
> > And today.
> 
> And today - should Ilpo be added to the list of contacts for this tree?

Yeah, I'm in practice the person who is handling pdx86 patches these days 
so it would be good.

...Goes to do some massive history rewriting...

-- 
 i.

Re: Missing signoff in the drivers-x86 tree

[Hans de Goede]

Hi,

On 13-Oct-26 10:34, Ilpo Järvinen wrote:
> On Mon, 12 Oct 2026, Mark Brown wrote:
> 
>> On Mon, Oct 05, 2026 at 02:52:50PM +0200, Mark Brown wrote:
>>> On Mon, Sep 28, 2026 at 03:37:30PM +0100, Mark Brown wrote:
>>>> On Thu, Sep 24, 2026 at 11:53:54AM +0100, Mark Brown wrote:
>>>>> Commits
>>>>>
>>>>>   4dabecbb202e8 ("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")
>>>>>   9af7fddef448d ("platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()")
>>>>>
>>>>> are missing a Signed-off-by from their authors
>>>>
>>>> This issue is still present today.
>>>
>>> And today.
>>
>> And today - should Ilpo be added to the list of contacts for this tree?
> 
> Yeah, I'm in practice the person who is handling pdx86 patches these days 
> so it would be good.
> 
> ...Goes to do some massive history rewriting...

My bad, I missed you (Ilpo) were not getting these emails, sorry.

Regards,

Hans

Re: Missing signoff in the drivers-x86 tree

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]

On Tue, 13 Oct 2026, Hans de Goede wrote:
> On 13-Oct-26 10:34, Ilpo Järvinen wrote:
> > On Mon, 12 Oct 2026, Mark Brown wrote:
> > 
> >> On Mon, Oct 05, 2026 at 02:52:50PM +0200, Mark Brown wrote:
> >>> On Mon, Sep 28, 2026 at 03:37:30PM +0100, Mark Brown wrote:
> >>>> On Thu, Sep 24, 2026 at 11:53:54AM +0100, Mark Brown wrote:
> >>>>> Commits
> >>>>>
> >>>>>   4dabecbb202e8 ("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")
> >>>>>   9af7fddef448d ("platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()")
> >>>>>
> >>>>> are missing a Signed-off-by from their authors
> >>>>
> >>>> This issue is still present today.
> >>>
> >>> And today.
> >>
> >> And today - should Ilpo be added to the list of contacts for this tree?
> > 
> > Yeah, I'm in practice the person who is handling pdx86 patches these days 
> > so it would be good.
> > 
> > ...Goes to do some massive history rewriting...
> 
> My bad, I missed you (Ilpo) were not getting these emails, sorry.

I finally went and improved my patch getting script to block any 
submissions for which git interpret-trailers shows no Sign-off-by lines.
That'll make it in practice impossible for me to apply such submissions 
anymore.

It's not entirely foolproof though as the Signed-off-by could still be 
invalid one e.g. by being different from From and I don't know easy way to 
extract From from a patch file (consider encodings and multiple From 
lines properly).

-- 
 i.

Re: Missing signoff in the drivers-x86 tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

On Tue, Oct 13, 2026 at 02:05:41PM +0300, Ilpo Järvinen wrote:

> It's not entirely foolproof though as the Signed-off-by could still be 
> invalid one e.g. by being different from From and I don't know easy way to 
> extract From from a patch file (consider encodings and multiple From 
> lines properly).

The script -next uses is:

   https://git.kernel.org/pub/scm/utils/next-utils/tools.git/tree/check_commits?h=main

Greg K-H has a script a bunch of people use which is a bit more friendly
for using in commit hooks and whatever, I don't have a URL to hand for
it immediately though.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]