Re: [PATCH] fscrypt,f2fs: introduce fscrypt_finalize_bounce_folio() for cleanup

[Chao Yu <chao@kernel.org>]

On 6/24/26 07:29, Eric Biggers wrote:
> On Mon, Jun 22, 2026 at 01:15:39AM +0000, Chao Yu wrote:
>> As part of the linux kernel's migration to folio-based APIs, introduce
>> fscrypt_finalize_bounce_folio() as the folio equivalent of
>> fscrypt_finalize_bounce_page(), and clean up f2fs codes with this new
>> helper.
>>
>> Suggested-by: Matthew Wilcox <willy@infradead.org>
>> Cc: Eric Biggers <ebiggers@kernel.org>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>>
>> Is it worth to introduce fscrypt_finalize_bounce_folio(), then try to
>> do clean in f2fs_write_end_bio() first, and then replace
>> fscrypt_finalize_bounce_page() later?
> 
> I'm working on making ext4 and f2fs always do file contents
> en/decryption using fscrypt_set_bio_crypt_ctx(), which already supports
> large folios and doesn't require the filesystem to manage bounce
> buffers.  I don't think these minor tweaks to the other implementation
> (which don't actually make it support large folios) accomplish anything
> useful, and we should focus on removing it instead.

Good, I see your patchset removing those codes, let's ignore current patch.

Thanks,

> 
> - Eric