From: Lokesh Vutla <lokeshvutla@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: SPL: FIT: fix DTC warnings on FIT generation
Date: Tue, 24 Oct 2017 07:33:42 +0530 [thread overview]
Message-ID: <d31d162a-906c-4be0-7ffc-4a5b3dd05901@ti.com> (raw)
In-Reply-To: <20171023203400.GA22919@bill-the-cat>
On Tuesday 24 October 2017 02:04 AM, Tom Rini wrote:
> On Mon, Oct 23, 2017 at 11:08:57AM +0530, Lokesh Vutla wrote:
>>
>>
>> On Tuesday 17 October 2017 02:43 AM, Tom Rini wrote:
>>> On Tue, Oct 17, 2017 at 02:29:14AM +0530, Jagan Teki wrote:
>>>> On Mon, Oct 9, 2017 at 10:15 AM, Simon Glass <sjg@chromium.org> wrote:
>>>>> Hi Andre,
>>>>>
>>>>> On 4 October 2017 at 17:24, Andre Przywara <andre.przywara@arm.com> wrote:
>>>>>> Newer versions of the device tree compiler (rightfully) complain about
>>>>>> mismatches between attributed node names (name@<addr>) and a missing
>>>>>> reg property in that node.
>>>>>> Adjust the FIT build script for 64-bit Allwinner boards to remove the
>>>>>> bogus addresses from the node names and avoid the warnings.
>>>>>>
>>>>>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>>>>>> ---
>>>>>> board/sunxi/mksunxi_fit_atf.sh | 16 ++++++++--------
>>>>>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>>>>
>>>>> It looks like we have this problem all over the place. The
>>>>> documentation in doc/uImage now seems to have this problem too.
>>>>>
>>>>> I wonder if instead we should add reg / #address-cells / #size-cells properties?
>>>>
>>>> If the update on dts, might be an another-overhead to maintain u-boot
>>>> dts wrt Linux dts sync.
>>>
>>> Anything that DTC is warning about in a dts that we get from the kernel,
>>> should be fixed in the kernel. The kernel dtc is what we're using, and
>>> is/will/can also complain about it.
>>
>> Kernel suppress these warning by default[1] and enables these warnings
>> with W= compiler option. May be this should be included in u-boot as well?
>>
>> [1]
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/Makefile.lib#n272
>
> We have slightly different logic for that today in
> scripts/Makefile.extrawarn, perhaps we need to re-sync?
>
ahh you are right. I do not see these warning with the latest U-Boot.
But I still agree with the $patch as these warnings are meant to be
fixed at some point.
Thanks and regards,
Lokesh
next prev parent reply other threads:[~2017-10-24 2:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 23:24 [U-Boot] [PATCH] ARM: SPL: FIT: fix DTC warnings on FIT generation Andre Przywara
2017-10-09 4:45 ` Simon Glass
2017-10-16 20:59 ` Jagan Teki
2017-10-16 21:13 ` Tom Rini
2017-10-16 21:20 ` Jagan Teki
2017-10-23 5:38 ` Lokesh Vutla
2017-10-23 20:34 ` Tom Rini
2017-10-24 2:03 ` Lokesh Vutla [this message]
2017-10-24 2:31 ` Masahiro Yamada
2017-10-24 22:04 ` André Przywara
2017-10-16 21:30 ` André Przywara
2017-10-22 14:34 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d31d162a-906c-4be0-7ffc-4a5b3dd05901@ti.com \
--to=lokeshvutla@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.