* [PATCH] accel/ivpu: Apply minor code style cleanups to align with kernel style
@ 2026-03-10 12:07 Karol Wachowski
2026-03-11 12:24 ` Falkowski, Maciej
0 siblings, 1 reply; 3+ messages in thread
From: Karol Wachowski @ 2026-03-10 12:07 UTC (permalink / raw)
To: dri-devel
Cc: oded.gabbay, jeff.hugo, maciej.falkowski, lizhi.hou,
andrzej.kacprowski, Karol Wachowski
Replace direct import_attach test with drm_gem_is_imported()
in ivpu_bo_bind().
Replace kzalloc(sizeof(*bo), GFP_KERNEL) with kzalloc_obj()
in ivpu_gem_create_object().
Remove unnecessary cast to bool in ivpu_dbg_bo().
No functional changes.
Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
---
drivers/accel/ivpu/ivpu_gem.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
index 8009965286e0..4f2005a8d496 100644
--- a/drivers/accel/ivpu/ivpu_gem.c
+++ b/drivers/accel/ivpu/ivpu_gem.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * Copyright (C) 2020-2023 Intel Corporation
+ * Copyright (C) 2020-2026 Intel Corporation
*/
#include <linux/dma-buf.h>
@@ -31,7 +31,7 @@ static inline void ivpu_dbg_bo(struct ivpu_device *vdev, struct ivpu_bo *bo, con
"%6s: bo %8p size %9zu ctx %d vpu_addr %9llx pages %d sgt %d mmu_mapped %d wc %d imported %d\n",
action, bo, ivpu_bo_size(bo), bo->ctx_id, bo->vpu_addr,
(bool)bo->base.pages, (bool)bo->base.sgt, bo->mmu_mapped, bo->base.map_wc,
- (bool)drm_gem_is_imported(&bo->base.base));
+ drm_gem_is_imported(&bo->base.base));
}
static inline int ivpu_bo_lock(struct ivpu_bo *bo)
@@ -81,7 +81,7 @@ int __must_check ivpu_bo_bind(struct ivpu_bo *bo)
ivpu_dbg_bo(vdev, bo, "bind");
- if (bo->base.base.import_attach)
+ if (drm_gem_is_imported(&bo->base.base))
sgt = ivpu_bo_map_attachment(vdev, bo);
else
sgt = drm_gem_shmem_get_pages_sgt(&bo->base);
@@ -195,7 +195,7 @@ struct drm_gem_object *ivpu_gem_create_object(struct drm_device *dev, size_t siz
if (size == 0 || !PAGE_ALIGNED(size))
return ERR_PTR(-EINVAL);
- bo = kzalloc(sizeof(*bo), GFP_KERNEL);
+ bo = kzalloc_obj(*bo);
if (!bo)
return ERR_PTR(-ENOMEM);
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/ivpu: Apply minor code style cleanups to align with kernel style
2026-03-10 12:07 [PATCH] accel/ivpu: Apply minor code style cleanups to align with kernel style Karol Wachowski
@ 2026-03-11 12:24 ` Falkowski, Maciej
2026-03-11 12:32 ` Karol Wachowski
0 siblings, 1 reply; 3+ messages in thread
From: Falkowski, Maciej @ 2026-03-11 12:24 UTC (permalink / raw)
To: Karol Wachowski, dri-devel
Cc: oded.gabbay, jeff.hugo, lizhi.hou, andrzej.kacprowski
Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
On 3/10/2026 1:07 PM, Karol Wachowski wrote:
> Replace direct import_attach test with drm_gem_is_imported()
> in ivpu_bo_bind().
>
> Replace kzalloc(sizeof(*bo), GFP_KERNEL) with kzalloc_obj()
> in ivpu_gem_create_object().
>
> Remove unnecessary cast to bool in ivpu_dbg_bo().
>
> No functional changes.
>
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_gem.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
> index 8009965286e0..4f2005a8d496 100644
> --- a/drivers/accel/ivpu/ivpu_gem.c
> +++ b/drivers/accel/ivpu/ivpu_gem.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * Copyright (C) 2020-2023 Intel Corporation
> + * Copyright (C) 2020-2026 Intel Corporation
> */
>
> #include <linux/dma-buf.h>
> @@ -31,7 +31,7 @@ static inline void ivpu_dbg_bo(struct ivpu_device *vdev, struct ivpu_bo *bo, con
> "%6s: bo %8p size %9zu ctx %d vpu_addr %9llx pages %d sgt %d mmu_mapped %d wc %d imported %d\n",
> action, bo, ivpu_bo_size(bo), bo->ctx_id, bo->vpu_addr,
> (bool)bo->base.pages, (bool)bo->base.sgt, bo->mmu_mapped, bo->base.map_wc,
> - (bool)drm_gem_is_imported(&bo->base.base));
> + drm_gem_is_imported(&bo->base.base));
> }
>
> static inline int ivpu_bo_lock(struct ivpu_bo *bo)
> @@ -81,7 +81,7 @@ int __must_check ivpu_bo_bind(struct ivpu_bo *bo)
>
> ivpu_dbg_bo(vdev, bo, "bind");
>
> - if (bo->base.base.import_attach)
> + if (drm_gem_is_imported(&bo->base.base))
> sgt = ivpu_bo_map_attachment(vdev, bo);
> else
> sgt = drm_gem_shmem_get_pages_sgt(&bo->base);
> @@ -195,7 +195,7 @@ struct drm_gem_object *ivpu_gem_create_object(struct drm_device *dev, size_t siz
> if (size == 0 || !PAGE_ALIGNED(size))
> return ERR_PTR(-EINVAL);
>
> - bo = kzalloc(sizeof(*bo), GFP_KERNEL);
> + bo = kzalloc_obj(*bo);
> if (!bo)
> return ERR_PTR(-ENOMEM);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/ivpu: Apply minor code style cleanups to align with kernel style
2026-03-11 12:24 ` Falkowski, Maciej
@ 2026-03-11 12:32 ` Karol Wachowski
0 siblings, 0 replies; 3+ messages in thread
From: Karol Wachowski @ 2026-03-11 12:32 UTC (permalink / raw)
To: Falkowski, Maciej, dri-devel
Cc: oded.gabbay, jeff.hugo, lizhi.hou, andrzej.kacprowski
On 3/11/2026 1:24 PM, Falkowski, Maciej wrote:
> Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
Thank you! Applied to drm-misc-next.
>
> On 3/10/2026 1:07 PM, Karol Wachowski wrote:
>> Replace direct import_attach test with drm_gem_is_imported()
>> in ivpu_bo_bind().
>>
>> Replace kzalloc(sizeof(*bo), GFP_KERNEL) with kzalloc_obj()
>> in ivpu_gem_create_object().
>>
>> Remove unnecessary cast to bool in ivpu_dbg_bo().
>>
>> No functional changes.
>>
>> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
>> ---
>> drivers/accel/ivpu/ivpu_gem.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/
>> ivpu_gem.c
>> index 8009965286e0..4f2005a8d496 100644
>> --- a/drivers/accel/ivpu/ivpu_gem.c
>> +++ b/drivers/accel/ivpu/ivpu_gem.c
>> @@ -1,6 +1,6 @@
>> // SPDX-License-Identifier: GPL-2.0-only
>> /*
>> - * Copyright (C) 2020-2023 Intel Corporation
>> + * Copyright (C) 2020-2026 Intel Corporation
>> */
>> #include <linux/dma-buf.h>
>> @@ -31,7 +31,7 @@ static inline void ivpu_dbg_bo(struct ivpu_device
>> *vdev, struct ivpu_bo *bo, con
>> "%6s: bo %8p size %9zu ctx %d vpu_addr %9llx pages %d sgt
>> %d mmu_mapped %d wc %d imported %d\n",
>> action, bo, ivpu_bo_size(bo), bo->ctx_id, bo->vpu_addr,
>> (bool)bo->base.pages, (bool)bo->base.sgt, bo->mmu_mapped,
>> bo->base.map_wc,
>> - (bool)drm_gem_is_imported(&bo->base.base));
>> + drm_gem_is_imported(&bo->base.base));
>> }
>> static inline int ivpu_bo_lock(struct ivpu_bo *bo)
>> @@ -81,7 +81,7 @@ int __must_check ivpu_bo_bind(struct ivpu_bo *bo)
>> ivpu_dbg_bo(vdev, bo, "bind");
>> - if (bo->base.base.import_attach)
>> + if (drm_gem_is_imported(&bo->base.base))
>> sgt = ivpu_bo_map_attachment(vdev, bo);
>> else
>> sgt = drm_gem_shmem_get_pages_sgt(&bo->base);
>> @@ -195,7 +195,7 @@ struct drm_gem_object
>> *ivpu_gem_create_object(struct drm_device *dev, size_t siz
>> if (size == 0 || !PAGE_ALIGNED(size))
>> return ERR_PTR(-EINVAL);
>> - bo = kzalloc(sizeof(*bo), GFP_KERNEL);
>> + bo = kzalloc_obj(*bo);
>> if (!bo)
>> return ERR_PTR(-ENOMEM);
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-11 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-10 12:07 [PATCH] accel/ivpu: Apply minor code style cleanups to align with kernel style Karol Wachowski
2026-03-11 12:24 ` Falkowski, Maciej
2026-03-11 12:32 ` Karol Wachowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.