From: Jes Sorensen <jes@linuxcare.com>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: Linux Knernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@oss.sgi.com
Subject: Re: [PATCH] RFC: fix ethernet device initialization
Date: 08 Mar 2001 18:35:54 +0100 [thread overview]
Message-ID: <d3ofvcyxhh.fsf@lxplus012.cern.ch> (raw)
In-Reply-To: <3AA6A570.57FF2D36@mandrakesoft.com>
In-Reply-To: Jeff Garzik's message of "Wed, 07 Mar 2001 16:17:36 -0500"
>>>>> "Jeff" == Jeff Garzik <jgarzik@mandrakesoft.com> writes:
Jeff> People from time to time point out a wart in ethernet
Jeff> initialization: The net_device is allocated and registered to
Jeff> the system in init_etherdev, which is usually one of the first
Jeff> things an ethernet driver probe function does. The net_device's
Jeff> final members are setup at some time between then and the exit
Jeff> of the probe function. There is never a clear point where the
Jeff> net device is available to the system for use.
I don't like the way you declare all the code in obscure macros in
there.
+#define DECLARE_CHG_MTU(suffix,low,high) \
+ static int suffix##_change_mtu(struct net_device *dev, int new_mtu) \
......
All it does is to make the code harder to read and debug for little/no
gain.
Jes
next prev parent reply other threads:[~2001-03-08 17:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-07 21:17 [PATCH] RFC: fix ethernet device initialization Jeff Garzik
2001-03-07 21:23 ` Jeff Garzik
2001-03-07 21:41 ` Arjan van de Ven
2001-03-07 22:16 ` Jeff Garzik
2001-03-07 23:13 ` Andrew Morton
2001-03-07 23:23 ` Alan Cox
2001-03-08 17:35 ` Jes Sorensen [this message]
2001-03-11 3:25 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3ofvcyxhh.fsf@lxplus012.cern.ch \
--to=jes@linuxcare.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.