All of lore.kernel.org
 help / color / mirror / Atom feed
From: arjan@fenrus.demon.nl (Arjan van de Ven)
To: jgarzik@mandrakesoft.com (Jeff Garzik)
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RFC: fix ethernet device initialization
Date: Wed, 7 Mar 2001 21:41:35 +0000 (GMT)	[thread overview]
Message-ID: <m14algd-000ObPC@amadeus.home.nl> (raw)
In-Reply-To: <3AA6A570.57FF2D36@mandrakesoft.com> <3AA6A6D6.70877AA3@mandrakesoft.com>

In article <3AA6A6D6.70877AA3@mandrakesoft.com> you wrote:
> This bug, which I fix, isn't causing oops AFAIK, just
> exporting ugliness to user space etc.

It CAN and IS causing oopses. init_etherdev() causes /sbin/hotplug to be
invoked, which in turn ifconfig up's the interface.
Several (if not all) drivers have an _up() function which cannot handle 
not-yet initialized device nodes.

Now we don't see this often as on UP systems, /sbin/hotplug is only started
_after_ the probe function either sleeps or exits, and 95% of the probe
functions don't sleep. (The ones that do are indeed reported to oops)
For SMP systems, I guess not that many have cardbus or other hotplug NICs....

Greetings,
   Arjan van de Ven

  reply	other threads:[~2001-03-07 21:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-07 21:17 [PATCH] RFC: fix ethernet device initialization Jeff Garzik
2001-03-07 21:23 ` Jeff Garzik
2001-03-07 21:41   ` Arjan van de Ven [this message]
2001-03-07 22:16 ` Jeff Garzik
2001-03-07 23:13 ` Andrew Morton
2001-03-07 23:23   ` Alan Cox
2001-03-08 17:35 ` Jes Sorensen
2001-03-11  3:25   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m14algd-000ObPC@amadeus.home.nl \
    --to=arjan@fenrus.demon.nl \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.