All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ihor Solodrai <ihor.solodrai@linux.dev>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>,
	Alan Maguire <alan.maguire@oracle.com>,
	Jiri Olsa <jolsa@kernel.org>,
	bpf@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Emil Tsalapatis <emil@etsalapatis.com>
Subject: Re: [PATCH bpf-next v1 00/14] resolve_btfids: Implement BTF tags emission for kfuncs
Date: Tue, 16 Jun 2026 13:10:01 -0700	[thread overview]
Message-ID: <d4c1c0a8-0c7f-4b0d-b7e7-37933c9f9efe@linux.dev> (raw)
In-Reply-To: <CAEf4Bzb-MuvFqsBdNCYyU=X7O+OXGK33TKA3GRe=P0gVFR=S2g@mail.gmail.com>

On 6/3/26 4:45 PM, Andrii Nakryiko wrote:
> On Mon, Jun 1, 2026 at 3:18 PM Ihor Solodrai <ihor.solodrai@linux.dev> wrote:
>>
>> BTF data for the kernel is generated through the following pipeline:
>>   * DWARF is emitted by the compiler
>>   * pahole reads in DWARF and produces BTF
>>   * resolve_btfids makes kernel-specific btf2btf transformation and
>>     patches .BTF_ids section
>>
>> This is orchestrated by link-vmlinux.sh, gen-btf.sh and Makefile.btf
>> in ./scripts directory.
>>
>> Historically kernel-specific BTF features were implemented in pahole,
>> and controlled by the feature flags. This requires kernel build
>> process to be aware of pahole version used for the build to set
>> correct runtime arguments for BTF encoding [1].
>>
>> This is a burden which can be alleviated by splitting kernel/module
>> BTF generation in two stages:
>>   1. Generic BTF generation from the kernel source code.
>>   2. Kernel-specific BTF modifications to support various BPF features.
>>
>> So far both stages were fused in pahole's BTF encoding. By moving
>> stage (2) in-tree, the dependency of kernel build on pahole can become
>> much more loose.
>>
>> Recent work [2] made it possible to do btf2btf transformations in
>> resolve_btfids, and it is already responsible for a few important BTF
>> modifications for the kernel:
>>   * .BTF.base generation for modules [3]
>>   * BTF sorting [4]
>>   * KF_IMPLICIT_ARGS support [5]
>>
>> This series continues the migration of kernel-specific BTF
>> transformations from pahole to resolve_btfids, implementing emission
>> of decl/type tags for the kfuncs and handling of the KF_ARENA_* flags.
>>
>> The implementation is idempotent with respect to BTF modifications: if
> 
> This sounds like an unnecessary complication. Can't we just control
> pahole through flags to guarantee there will be no kernel-specific
> information emitted?

Hi everyone.

I talked to Andrii off-list about this series last week and I'm in the
middle of preparing a v2, which is why I've been quiet in the thread.

The main v1->v2 design change from the discussion is to drop the
"ensure" pattern: just assume valid BTF on input. This requires
restructuring the series to preserve bisectability with respect to the
pahole flags.

I'll go through the messages now and reply where necessary. I'm going
to silently accept most of the nits I think.

Thanks!

> 
> 
>> input BTF already contains target tags, corresponding resolve_btfids
>> transformation is a noop. This allows for more flexibility in terms of
>> dependency on pahole. In particular, older pahole (without
>> decl_tag_kfuncs support, for example) can now be used in kbuild and
>> the resulting vmlinux BTF will contain properly tagged kfuncs
>> anyways. Conversely, if for whatever reason pahole emitted the same
>> tags, they will be properly skipped.
>>
>> [...]

      reply	other threads:[~2026-06-16 20:10 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 22:17 [PATCH bpf-next v1 00/14] resolve_btfids: Implement BTF tags emission for kfuncs Ihor Solodrai
2026-06-01 22:17 ` [PATCH bpf-next v1 01/14] tools/bpf: Sync btf_ids.h to tools Ihor Solodrai
2026-06-16  6:28   ` Emil Tsalapatis
2026-06-01 22:17 ` [PATCH bpf-next v1 02/14] selftests/bpf: Modernize resolve_btfids test scaffolding Ihor Solodrai
2026-06-02 13:02   ` Jiri Olsa
2026-06-02 18:30     ` Ihor Solodrai
2026-06-16  6:33   ` Emil Tsalapatis
2026-06-01 22:17 ` [PATCH bpf-next v1 03/14] selftests/bpf: Fix resolve_btfids test reads of BTF ID sets in PIE builds Ihor Solodrai
2026-06-03 23:45   ` Andrii Nakryiko
2026-06-16 20:15     ` Ihor Solodrai
2026-06-16  6:53   ` Emil Tsalapatis
2026-06-01 22:17 ` [PATCH bpf-next v1 04/14] selftests/bpf: Add kfunc set test to resolve_btfids Ihor Solodrai
2026-06-02 13:02   ` Jiri Olsa
2026-06-03 23:45   ` Andrii Nakryiko
2026-06-16  7:07   ` Emil Tsalapatis
2026-06-16 18:33     ` Alexei Starovoitov
2026-06-16 21:52     ` Ihor Solodrai
2026-06-01 22:17 ` [PATCH bpf-next v1 05/14] resolve_btfids: Index BTF ID symbols by address Ihor Solodrai
2026-06-01 22:28   ` sashiko-bot
2026-06-01 23:03   ` bot+bpf-ci
2026-06-02 13:01   ` Jiri Olsa
2026-06-02 18:28     ` Ihor Solodrai
2026-06-03 23:45   ` Andrii Nakryiko
2026-06-16 21:47     ` Ihor Solodrai
2026-06-16 18:45   ` Emil Tsalapatis
2026-06-16 21:53     ` Ihor Solodrai
2026-06-01 22:17 ` [PATCH bpf-next v1 06/14] resolve_btfids: Discover kfuncs from BTF ID sets Ihor Solodrai
2026-06-01 22:33   ` sashiko-bot
2026-06-02 18:36     ` Ihor Solodrai
2026-06-02 20:36   ` Jiri Olsa
2026-06-02 21:08     ` Ihor Solodrai
2026-06-03 23:45       ` Andrii Nakryiko
2026-06-03 23:45   ` Andrii Nakryiko
2026-06-16 21:49     ` Ihor Solodrai
2026-06-01 22:17 ` [PATCH bpf-next v1 07/14] resolve_btfids: Emit bpf_kfunc BTF decl tag for discovered kfuncs Ihor Solodrai
2026-06-03 23:45   ` Andrii Nakryiko
2026-06-01 22:17 ` [PATCH bpf-next v1 08/14] selftests/bpf: Verify bpf_kfunc decl tag emission in resolve_btfids Ihor Solodrai
2026-06-01 22:18 ` [PATCH bpf-next v1 09/14] resolve_btfids: Emit a decl tag for kfuncs with KF_FASTCALL Ihor Solodrai
2026-06-01 22:18 ` [PATCH bpf-next v1 10/14] selftests/bpf: Verify bpf_fastcall decl tags in resolve_btfids test Ihor Solodrai
2026-06-03 23:47   ` Andrii Nakryiko
2026-06-01 22:18 ` [PATCH bpf-next v1 11/14] resolve_btfids: Process KF_ARENA_* flags in resolve_btfids Ihor Solodrai
2026-06-03 23:47   ` Andrii Nakryiko
2026-06-16 19:51   ` Emil Tsalapatis
2026-06-16 20:36     ` Emil Tsalapatis
2026-06-16 21:58       ` Ihor Solodrai
2026-06-01 22:18 ` [PATCH bpf-next v1 12/14] selftests/bpf: Verify arena type tags in resolve_btfids test Ihor Solodrai
2026-06-01 22:29   ` sashiko-bot
2026-06-03 23:46   ` Andrii Nakryiko
2026-06-01 22:18 ` [PATCH bpf-next v1 13/14] kbuild: Drop decl_tag_kfuncs and attributes from pahole flags Ihor Solodrai
2026-06-03 23:48   ` Andrii Nakryiko
2026-06-01 22:18 ` [PATCH bpf-next v1 14/14] docs, resolve_btfids: Document kfunc BTF annotation emission Ihor Solodrai
2026-06-16 19:54   ` Emil Tsalapatis
2026-06-03 23:45 ` [PATCH bpf-next v1 00/14] resolve_btfids: Implement BTF tags emission for kfuncs Andrii Nakryiko
2026-06-16 20:10   ` Ihor Solodrai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4c1c0a8-0c7f-4b0d-b7e7-37933c9f9efe@linux.dev \
    --to=ihor.solodrai@linux.dev \
    --cc=alan.maguire@oracle.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=memxor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.