All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <pjw@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Chen Pei <cp0613@linux.alibaba.com>,
	acme@kernel.org, peterz@infradead.org,  mingo@redhat.com,
	namhyung@kernel.org, mark.rutland@arm.com,
	 alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	irogers@google.com,  james.clark@linaro.org, leo.yan@linux.dev,
	john.g.garry@oracle.com,  will@kernel.org, mike.leach@arm.com,
	pjw@kernel.org, palmer@dabbelt.com,  guoren@kernel.org,
	linux-perf-users@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] perf tsc: Declare TSC support from the build system
Date: Wed, 7 Oct 2026 09:31:36 -0600 (MDT)	[thread overview]
Message-ID: <d58889fc-71a1-0144-dc5a-4eb354536748@kernel.org> (raw)
In-Reply-To: <66136aa8-adbe-4fdf-9b7c-d44ea0e5cf1e@intel.com>

On Tue, 6 Oct 2026, Adrian Hunter wrote:

> On 29/09/2026 06:41, Chen Pei wrote:
> > The "TSC support" subtest of the "Convert perf time to TSC" test decides
> > whether the architecture is covered by matching compiler macros for
> > x86_64, i386 and arm64.  That list has to be edited for every new
> > architecture and can drift apart from the set of architectures that really
> > provide a counter.
> > 
> > Declare the capability where the implementation is, following the
> > PERF_HAVE_JITDUMP pattern: an architecture with a usable counter sets
> > PERF_HAVE_RDTSC in its arch Makefile, Makefile.config turns it into
> > -DHAVE_RDTSC, and the test keys off that.
> > 
> > x86 and arm64 keep the same behaviour, riscv starts running the subtest
> > where the previous patch defines rdtsc().
> > 
> > Signed-off-by: Chen Pei <cp0613@linux.alibaba.com>
> 
> One minor style comment below.  In any case:
> 
> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>

Reviewed-by: Paul Walmsley <pjw@kernel.org> 


- Paul

WARNING: multiple messages have this Message-ID (diff)
From: Paul Walmsley <pjw@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Chen Pei <cp0613@linux.alibaba.com>,
	acme@kernel.org, peterz@infradead.org,  mingo@redhat.com,
	namhyung@kernel.org, mark.rutland@arm.com,
	 alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	irogers@google.com,  james.clark@linaro.org, leo.yan@linux.dev,
	john.g.garry@oracle.com,  will@kernel.org, mike.leach@arm.com,
	pjw@kernel.org, palmer@dabbelt.com,  guoren@kernel.org,
	linux-perf-users@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] perf tsc: Declare TSC support from the build system
Date: Wed, 7 Oct 2026 09:31:36 -0600 (MDT)	[thread overview]
Message-ID: <d58889fc-71a1-0144-dc5a-4eb354536748@kernel.org> (raw)
In-Reply-To: <66136aa8-adbe-4fdf-9b7c-d44ea0e5cf1e@intel.com>

On Tue, 6 Oct 2026, Adrian Hunter wrote:

> On 29/09/2026 06:41, Chen Pei wrote:
> > The "TSC support" subtest of the "Convert perf time to TSC" test decides
> > whether the architecture is covered by matching compiler macros for
> > x86_64, i386 and arm64.  That list has to be edited for every new
> > architecture and can drift apart from the set of architectures that really
> > provide a counter.
> > 
> > Declare the capability where the implementation is, following the
> > PERF_HAVE_JITDUMP pattern: an architecture with a usable counter sets
> > PERF_HAVE_RDTSC in its arch Makefile, Makefile.config turns it into
> > -DHAVE_RDTSC, and the test keys off that.
> > 
> > x86 and arm64 keep the same behaviour, riscv starts running the subtest
> > where the previous patch defines rdtsc().
> > 
> > Signed-off-by: Chen Pei <cp0613@linux.alibaba.com>
> 
> One minor style comment below.  In any case:
> 
> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>

Reviewed-by: Paul Walmsley <pjw@kernel.org> 


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-10-07 15:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  3:41 [PATCH v2 0/2] perf riscv: Implement rdtsc() Chen Pei
2026-09-29  3:41 ` Chen Pei
2026-09-29  3:41 ` [PATCH v2 1/2] " Chen Pei
2026-09-29  3:41   ` Chen Pei
2026-09-29  3:47   ` sashiko-bot
2026-10-07 15:28   ` Paul Walmsley
2026-10-07 15:28     ` Paul Walmsley
2026-09-29  3:41 ` [PATCH v2 2/2] perf tsc: Declare TSC support from the build system Chen Pei
2026-09-29  3:41   ` Chen Pei
2026-09-29  3:48   ` sashiko-bot
2026-09-29  9:49   ` Leo Yan
2026-09-29  9:49     ` Leo Yan
2026-10-06 13:16   ` Adrian Hunter
2026-10-06 13:16     ` Adrian Hunter
2026-10-07 15:31     ` Paul Walmsley [this message]
2026-10-07 15:31       ` Paul Walmsley
2026-10-09  2:24     ` Chen Pei
2026-10-09  2:24       ` Chen Pei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d58889fc-71a1-0144-dc5a-4eb354536748@kernel.org \
    --to=pjw@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=cp0613@linux.alibaba.com \
    --cc=guoren@kernel.org \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.