From: Xing Zhengjun <zhengjun.xing@linux.intel.com>
To: lkp@lists.01.org
Subject: Re: [ima] 8eb613c0b8: stress-ng.icache.ops_per_sec -84.2% regression
Date: Fri, 12 Jun 2020 08:39:08 +0800 [thread overview]
Message-ID: <d5b6a48b-005c-e5cb-a82f-5f7225741100@linux.intel.com> (raw)
In-Reply-To: <1591872811.5140.41.camel@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
On 6/11/2020 6:53 PM, Mimi Zohar wrote:
> On Thu, 2020-06-11 at 15:10 +0800, Xing Zhengjun wrote:
>> On 6/10/2020 9:53 PM, Mimi Zohar wrote:
>> ucode: 0x500002c
>>>
>>> Does the following change resolve it?
>>>
>>> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
>>> index c44414a7f82e..78e1dfc8a3f2 100644
>>> --- a/security/integrity/ima/ima_main.c
>>> +++ b/security/integrity/ima/ima_main.c
>>> @@ -426,7 +426,8 @@ int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot)
>>> int pcr;
>>>
>>> /* Is mprotect making an mmap'ed file executable? */
>>> - if (!vma->vm_file || !(prot & PROT_EXEC) || (vma->vm_flags & VM_EXEC))
>>> + if (!(ima_policy_flag & IMA_APPRAISE) || !vma->vm_file ||
>>> + !(prot & PROT_EXEC) || (vma->vm_flags & VM_EXEC))
>>> return 0;
>>>
>>> security_task_getsecid(current, &secid);
>>>
>> Thanks. I test the change, it can resolve the regression.
>
> Thanks! Can I get your "Tested-by" tag?
>
> Mimi
>
Sure.
--
Zhengjun Xing
WARNING: multiple messages have this Message-ID (diff)
From: Xing Zhengjun <zhengjun.xing@linux.intel.com>
To: Mimi Zohar <zohar@linux.ibm.com>,
kernel test robot <rong.a.chen@intel.com>
Cc: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org
Subject: Re: [LKP] [ima] 8eb613c0b8: stress-ng.icache.ops_per_sec -84.2% regression
Date: Fri, 12 Jun 2020 08:39:08 +0800 [thread overview]
Message-ID: <d5b6a48b-005c-e5cb-a82f-5f7225741100@linux.intel.com> (raw)
In-Reply-To: <1591872811.5140.41.camel@linux.ibm.com>
On 6/11/2020 6:53 PM, Mimi Zohar wrote:
> On Thu, 2020-06-11 at 15:10 +0800, Xing Zhengjun wrote:
>> On 6/10/2020 9:53 PM, Mimi Zohar wrote:
>> ucode: 0x500002c
>>>
>>> Does the following change resolve it?
>>>
>>> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
>>> index c44414a7f82e..78e1dfc8a3f2 100644
>>> --- a/security/integrity/ima/ima_main.c
>>> +++ b/security/integrity/ima/ima_main.c
>>> @@ -426,7 +426,8 @@ int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot)
>>> int pcr;
>>>
>>> /* Is mprotect making an mmap'ed file executable? */
>>> - if (!vma->vm_file || !(prot & PROT_EXEC) || (vma->vm_flags & VM_EXEC))
>>> + if (!(ima_policy_flag & IMA_APPRAISE) || !vma->vm_file ||
>>> + !(prot & PROT_EXEC) || (vma->vm_flags & VM_EXEC))
>>> return 0;
>>>
>>> security_task_getsecid(current, &secid);
>>>
>> Thanks. I test the change, it can resolve the regression.
>
> Thanks! Can I get your "Tested-by" tag?
>
> Mimi
>
Sure.
--
Zhengjun Xing
next prev parent reply other threads:[~2020-06-12 0:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 9:11 [ima] 8eb613c0b8: stress-ng.icache.ops_per_sec -84.2% regression kernel test robot
2020-06-03 9:11 ` kernel test robot
2020-06-10 3:21 ` Xing Zhengjun
2020-06-10 3:21 ` [LKP] " Xing Zhengjun
2020-06-10 13:53 ` Mimi Zohar
2020-06-11 7:10 ` Xing Zhengjun
2020-06-11 7:10 ` [LKP] " Xing Zhengjun
2020-06-11 10:53 ` Mimi Zohar
2020-06-12 0:39 ` Xing Zhengjun [this message]
2020-06-12 0:39 ` Xing Zhengjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5b6a48b-005c-e5cb-a82f-5f7225741100@linux.intel.com \
--to=zhengjun.xing@linux.intel.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.