* On 021d53a3d87e ("wifi: mac80211: fix NULL dereference at band check in starting tx ba session")
@ 2025-04-03 14:25 Dmitry Antipov
2025-04-08 2:28 ` Zong-Zhe Yang
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Antipov @ 2025-04-03 14:25 UTC (permalink / raw)
To: Zong-Zhe Yang; +Cc: Johannes Berg, linux-wireless
Looking at 021d53a3d87e ("wifi: mac80211: fix NULL dereference at band check in starting tx ba
session"), can the following be useful for older (e.g. 5.10) kernels without any MLO support?
diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c
index 4b4ab1961068..1a89ba2aecaa 100644
--- a/net/mac80211/agg-tx.c
+++ b/net/mac80211/agg-tx.c
@@ -595,7 +595,8 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
return -EINVAL;
if (!pubsta->ht_cap.ht_supported &&
- sta->sdata->vif.bss_conf.chandef.chan->band != NL80211_BAND_6GHZ)
+ !pubsta->vht_cap.vht_supported &&
+ !pubsta->he_cap.has_he)
return -EINVAL;
if (WARN_ON_ONCE(!local->ops->ampdu_action))
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread* RE: On 021d53a3d87e ("wifi: mac80211: fix NULL dereference at band check in starting tx ba session")
2025-04-03 14:25 On 021d53a3d87e ("wifi: mac80211: fix NULL dereference at band check in starting tx ba session") Dmitry Antipov
@ 2025-04-08 2:28 ` Zong-Zhe Yang
0 siblings, 0 replies; 2+ messages in thread
From: Zong-Zhe Yang @ 2025-04-08 2:28 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: Johannes Berg, linux-wireless@vger.kernel.org
Dmitry Antipov <dmantipov@yandex.ru> wrote:
>
> Looking at 021d53a3d87e ("wifi: mac80211: fix NULL dereference at band check in starting tx
> ba session"), can the following be useful for older (e.g. 5.10) kernels without any MLO
> support?
>
> diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index
> 4b4ab1961068..1a89ba2aecaa 100644
> --- a/net/mac80211/agg-tx.c
> +++ b/net/mac80211/agg-tx.c
> @@ -595,7 +595,8 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16
> tid,
> return -EINVAL;
>
> if (!pubsta->ht_cap.ht_supported &&
> - sta->sdata->vif.bss_conf.chandef.chan->band != NL80211_BAND_6GHZ)
> + !pubsta->vht_cap.vht_supported &&
> + !pubsta->he_cap.has_he)
> return -EINVAL;
>
> if (WARN_ON_ONCE(!local->ops->ampdu_action))
>
> Dmitry
>
Without MLO, no NULL dereference here, and the original logic is workable (though not very intuitive).
So, to me, it doesn't seem much necessary for older kernels.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-08 2:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-03 14:25 On 021d53a3d87e ("wifi: mac80211: fix NULL dereference at band check in starting tx ba session") Dmitry Antipov
2025-04-08 2:28 ` Zong-Zhe Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.