All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Michal Orzel <michal.orzel@amd.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] common: dom0less-bindings: introduce XSM labels
Date: Wed, 9 Sep 2026 10:39:51 +0000	[thread overview]
Message-ID: <d6458362-9fc7-4a5d-9063-c4ac7d21bb01@epam.com> (raw)
In-Reply-To: <3f2bb6fe-a517-421f-adb9-c33d67ef4591@suse.com>

On 9/9/26 12:07, Jan Beulich wrote:
> On 09.09.2026 10:57, Sergiy Kibrik wrote:
>> @@ -141,5 +144,13 @@ int __init parse_dom0less_node(struct dt_device_node *node,
>>           panic("'llc-colors' found, but LLC coloring is disabled\n");
>>   #endif
>>   
>> +    if ( IS_ENABLED(CONFIG_XSM_FLASK) &&
>> +         !dt_property_read_string(node, "seclabel", &xsm_seclabel) )
>> +    {
>> +        if ( flask_context_to_sid(xsm_seclabel, strlen(xsm_seclabel),
>> +                                     &d_cfg->ssidref) )
>> +            panic("Invalid security context for domain: %s\n", xsm_seclabel);
>> +    }
> 
> Is there a reason this isn't a single if()? Also (nit) the one wrapped line
> is mis-indented.

no specific reason, can very well be three long expressions combined 
into single if() condition.

   -Sergiy

  reply	other threads:[~2026-09-09 10:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09  8:57 [PATCH v2] common: dom0less-bindings: introduce XSM labels Sergiy Kibrik
2026-09-09  9:07 ` Jan Beulich
2026-09-09 10:39   ` Sergiy Kibrik [this message]
2026-09-11  7:58 ` Orzel, Michal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6458362-9fc7-4a5d-9063-c4ac7d21bb01@epam.com \
    --to=sergiy_kibrik@epam.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bertrand.marquis@arm.com \
    --cc=dpsmith@apertussolutions.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.