All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/7] block fixes found by code inspection
@ 2026-11-19  7:05 Guixin Liu
  2026-11-19  7:05 ` [PATCH 1/7] blk-mq: free the rqs arrays of tags in the SRCU callback Guixin Liu
                   ` (6 more replies)
  0 siblings, 7 replies; 15+ messages in thread
From: Guixin Liu @ 2026-11-19  7:05 UTC (permalink / raw)
  To: Jens Axboe, Christoph Hellwig, Tejun Heo, Josef Bacik,
	Nilay Shroff, Ming Lei, Hannes Reinecke
  Cc: linux-block

Seven block layer fixes, all found by code inspection of the tags SRCU
lifetime, the hctx reuse path, and the blk-cgroup configuration writers.

Patch 1 and patch 7 close the two halves of the tags_srcu protection for
tag iterators: patch 1 frees the tags->rqs[] and tags->static_rqs[]
arrays in the SRCU callback together with the bitmaps, patch 7 unpublishes
set->tags[] before the grace period starts, so a reader can no longer
load a pointer that the grace period has already released.

Patch 2 clears a stale BLK_MQ_S_STOPPED flag when a parked hctx is
reused, so requests queued on it do not stall until the driver happens
to stop and restart the queue again.

Patch 3 and patch 4 fix the locking order of ioc_cost_model_write():
patch 3 releases rq_qos_mutex before freezing the queue like
ioc_qos_write() does, patch 4 moves the unfreeze in ioc_qos_write()
ahead of the bdev reference drop, closing the same lifetime gap in both
writers.

Patch 5 fixes the mean folding in blk_rq_stat_sum(), which silently
dropped the samples of an already folded source and kept
blk-iolatency's accumulated window mean at zero on rotating disks.

Patch 6 rejects a dead disk in the three lazy policy init helpers, so a
configuration write racing del_gendisk() can no longer attach an orphan
iocost/iolatency/throttle policy that nothing tears down again.

Found by code inspection.

Tested on a KVM q35 guest with a 7.4-rc1 based kernel (PROVE_LOCKING
enabled): hctx state flags after a stop/shrink/start/grow cycle on
nullb0 show no stale flags and IO on the reused hctx completes; iocost
cost.model and cost.qos writes against a live and a removed nullb
device behave as expected, with the removed device rejected with
-ENODEV and the live device accepting all model, qos and coefficient
writes; concurrent nullb submit_queues resizes against continuous
debugfs busy/tags reads under fio ran for six minutes without errors.

Guixin Liu (7):
  blk-mq: free the rqs arrays of tags in the SRCU callback
  blk-mq: clear stale stopped flag on hctx reuse
  blk-iocost: don't take rq_qos_mutex before the queue is frozen in cost
    model write
  blk-iocost: unfreeze the queue before dropping the bdev reference in
    qos write
  blk-stat: account for the mean of the source in blk_rq_stat_sum()
  blk-cgroup: don't attach a qos policy to a dead disk
  blk-mq: unpublish the tags before deferring their free to SRCU

 block/blk-iocost.c    | 19 ++++++++++++++-----
 block/blk-iolatency.c |  3 +++
 block/blk-mq-tag.c    |  2 ++
 block/blk-mq.c        | 24 +++++++-----------------
 block/blk-mq.h        |  1 -
 block/blk-stat.c      |  8 ++++++--
 block/blk-throttle.c  |  3 +++
 7 files changed, 35 insertions(+), 25 deletions(-)

--
2.43.7


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2026-11-20  6:22 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19  7:05 [PATCH 0/7] block fixes found by code inspection Guixin Liu
2026-11-19  7:05 ` [PATCH 1/7] blk-mq: free the rqs arrays of tags in the SRCU callback Guixin Liu
2026-11-19  7:05 ` [PATCH 2/7] blk-mq: clear stale stopped flag on hctx reuse Guixin Liu
2026-11-19  7:05 ` [PATCH 3/7] blk-iocost: don't take rq_qos_mutex before the queue is frozen in cost model write Guixin Liu
2026-11-19 13:40   ` Tao Cui
2026-11-20  2:14     ` Guixin Liu
2026-11-20  2:56       ` Tao Cui
2026-11-19  7:05 ` [PATCH 4/7] blk-iocost: unfreeze the queue before dropping the bdev reference in qos write Guixin Liu
2026-11-19  7:05 ` [PATCH 5/7] blk-stat: account for the mean of the source in blk_rq_stat_sum() Guixin Liu
2026-11-19 13:32   ` Tao Cui
2026-11-20  2:04     ` Guixin Liu
2026-11-20  2:50       ` Tao Cui
2026-11-20  6:22         ` Guixin Liu
2026-11-19  7:05 ` [PATCH 6/7] blk-cgroup: don't attach a qos policy to a dead disk Guixin Liu
2026-11-19  7:05 ` [PATCH 7/7] blk-mq: unpublish the tags before deferring their free to SRCU Guixin Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.