All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>, felix.seitz@thm-motorsport.de
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH v2] cansniffer: totally untested hack to reduce display update by factor of 10
Date: Tue, 24 Jun 2014 18:44:07 +0200	[thread overview]
Message-ID: <d65e3040-e640-4c05-baa3-d97ce7a448b6@email.android.com> (raw)
In-Reply-To: <53A9A96E.5030407@hartkopp.net>



On 24 June 2014 18:38:06 CEST, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
>I'll check it and give a feedback.
>
>Btw. it needs a v3:
>
>>  /* time defaults */
>>  
>> -#define TIMEOUT 50 /* in 100ms */
>> -#define HOLD    10 /* in 100ms */
>> -#define LOOP     2 /* in 100ms */
>> +#define TIMEOUT 500 /* in 10ms */
>> +#define HOLD    100 /* in 10ms */
>> +#define LOOP      2 /* in 10ms */
>
>LOOP has to be *10 too.

Yes, if we want unchanged behaviour, which would be better for mainlining. With my patch the default is now 20ms. 

Marc

  reply	other threads:[~2014-06-24 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 16:26 [PATCH v2] cansniffer: totally untested hack to reduce display update by factor of 10 Marc Kleine-Budde
2014-06-24 16:38 ` Oliver Hartkopp
2014-06-24 16:44   ` Marc Kleine-Budde [this message]
2014-06-24 17:51     ` Oliver Hartkopp
2014-06-24 18:09       ` Felix Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d65e3040-e640-4c05-baa3-d97ce7a448b6@email.android.com \
    --to=mkl@pengutronix.de \
    --cc=felix.seitz@thm-motorsport.de \
    --cc=linux-can@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.