* [PATCH] selftests/powerpc: remove unneeded variable [not found] <20230614064848.5648-1-luojianhong@cdjrlc.com> @ 2023-06-14 6:51 ` baomingtong001 0 siblings, 0 replies; 5+ messages in thread From: baomingtong001 @ 2023-06-14 6:51 UTC (permalink / raw) To: mpe, npiggin, christophe.leroy, shuah; +Cc: linuxppc-dev, linux-kselftest fix the following coccicheck warning: tools/testing/selftests/powerpc/alignment/alignment_handler.c:530:5-7: Unneeded variable: "rc". Return "0". tools/testing/selftests/powerpc/alignment/alignment_handler.c:558:5-7: Unneeded variable: "rc". Return "0". tools/testing/selftests/powerpc/alignment/alignment_handler.c:576:5-7: Unneeded variable: "rc". Return "0". tools/testing/selftests/powerpc/alignment/alignment_handler.c:591:5-7: Unneeded variable: "rc". Return "0". tools/testing/selftests/powerpc/alignment/alignment_handler.c:407:5-7: Unneeded variable: "rc". Return "0". tools/testing/selftests/powerpc/alignment/alignment_handler.c:466:5-7: Unneeded variable: "rc". Return "0". tools/testing/selftests/powerpc/alignment/alignment_handler.c:481:5-7: Unneeded variable: "rc". Return "0". tools/testing/selftests/powerpc/alignment/alignment_handler.c:502:5-7: Unneeded variable: "rc". Return "0". tools/testing/selftests/powerpc/alignment/alignment_handler.c:322:5-7: Unneeded variable: "rc". Return "0". tools/testing/selftests/powerpc/alignment/alignment_handler.c:340:5-7: Unneeded variable: "rc". Return "0". tools/testing/selftests/powerpc/alignment/alignment_handler.c:356:5-7: Unneeded variable: "rc". Return "0". tools/testing/selftests/powerpc/alignment/alignment_handler.c:388:5-7: Unneeded variable: "rc". Return "0". Signed-off-by: Mingtong Bao <baomingtong001@208suo.com> --- .../powerpc/alignment/alignment_handler.c | 36 +++++++------------ 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/tools/testing/selftests/powerpc/alignment/alignment_handler.c b/tools/testing/selftests/powerpc/alignment/alignment_handler.c index 33ee34fc0828..56fc26c2b75a 100644 --- a/tools/testing/selftests/powerpc/alignment/alignment_handler.c +++ b/tools/testing/selftests/powerpc/alignment/alignment_handler.c @@ -319,7 +319,6 @@ static bool can_open_cifile(void) int test_alignment_handler_vsx_206(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); SKIP_IF(!have_hwcap(PPC_FEATURE_ARCH_2_06)); @@ -332,12 +331,11 @@ int test_alignment_handler_vsx_206(void) STORE_VSX_XFORM_TEST(stxvd2x); STORE_VSX_XFORM_TEST(stxvw4x); STORE_VSX_XFORM_TEST(stxsdx); - return rc; + return 0; } int test_alignment_handler_vsx_207(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_2_07)); @@ -348,12 +346,11 @@ int test_alignment_handler_vsx_207(void) LOAD_VSX_XFORM_TEST(lxsiwzx); STORE_VSX_XFORM_TEST(stxsspx); STORE_VSX_XFORM_TEST(stxsiwx); - return rc; + return 0; } int test_alignment_handler_vsx_300(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); @@ -380,12 +377,11 @@ int test_alignment_handler_vsx_300(void) STORE_VSX_XFORM_TEST(stxvx); STORE_VSX_XFORM_TEST(stxvl); STORE_VSX_XFORM_TEST(stxvll); - return rc; + return 0; } int test_alignment_handler_vsx_prefix(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_3_1)); @@ -399,12 +395,11 @@ int test_alignment_handler_vsx_prefix(void) STORE_VSX_8LS_PREFIX_TEST(PSTXSSP, 0); STORE_VSX_8LS_PREFIX_TEST(PSTXV0, 0); STORE_VSX_8LS_PREFIX_TEST(PSTXV1, 1); - return rc; + return 0; } int test_alignment_handler_integer(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); @@ -458,12 +453,11 @@ int test_alignment_handler_integer(void) STORE_DFORM_TEST(stmw); #endif - return rc; + return 0; } int test_alignment_handler_integer_206(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); SKIP_IF(!have_hwcap(PPC_FEATURE_ARCH_2_06)); @@ -473,12 +467,11 @@ int test_alignment_handler_integer_206(void) LOAD_XFORM_TEST(ldbrx); STORE_XFORM_TEST(stdbrx); - return rc; + return 0; } int test_alignment_handler_integer_prefix(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_3_1)); @@ -494,12 +487,11 @@ int test_alignment_handler_integer_prefix(void) STORE_MLS_PREFIX_TEST(PSTH); STORE_MLS_PREFIX_TEST(PSTW); STORE_8LS_PREFIX_TEST(PSTD); - return rc; + return 0; } int test_alignment_handler_vmx(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); SKIP_IF(!have_hwcap(PPC_FEATURE_HAS_ALTIVEC)); @@ -522,12 +514,11 @@ int test_alignment_handler_vmx(void) STORE_VMX_XFORM_TEST(stvehx); STORE_VMX_XFORM_TEST(stvewx); STORE_VMX_XFORM_TEST(stvxl); - return rc; + return 0; } int test_alignment_handler_fp(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); @@ -550,12 +541,11 @@ int test_alignment_handler_fp(void) STORE_FLOAT_XFORM_TEST(stfsux); STORE_FLOAT_XFORM_TEST(stfiwx); - return rc; + return 0; } int test_alignment_handler_fp_205(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); SKIP_IF(!have_hwcap(PPC_FEATURE_ARCH_2_05)); @@ -568,12 +558,11 @@ int test_alignment_handler_fp_205(void) STORE_FLOAT_DFORM_TEST(stfdp); STORE_FLOAT_XFORM_TEST(stfdpx); - return rc; + return 0; } int test_alignment_handler_fp_206(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); SKIP_IF(!have_hwcap(PPC_FEATURE_ARCH_2_06)); @@ -582,13 +571,12 @@ int test_alignment_handler_fp_206(void) LOAD_FLOAT_XFORM_TEST(lfiwzx); - return rc; + return 0; } int test_alignment_handler_fp_prefix(void) { - int rc = 0; SKIP_IF(!can_open_cifile()); SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_3_1)); @@ -599,7 +587,7 @@ int test_alignment_handler_fp_prefix(void) LOAD_FLOAT_MLS_PREFIX_TEST(PLFD); STORE_FLOAT_MLS_PREFIX_TEST(PSTFS); STORE_FLOAT_MLS_PREFIX_TEST(PSTFD); - return rc; + return 0; } void usage(char *prog) ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <20230614070926.36395-1-zhanglibing@cdjrlc.com>]
* [PATCH] selftests/powerpc: Remove unneeded variable [not found] <20230614070926.36395-1-zhanglibing@cdjrlc.com> @ 2023-06-14 7:12 ` wuyonggang001 0 siblings, 0 replies; 5+ messages in thread From: wuyonggang001 @ 2023-06-14 7:12 UTC (permalink / raw) To: shuah; +Cc: linuxppc-dev, linux-kselftest, linux-kernel Fix the following coccicheck warning: tools/testing/selftests/powerpc/alignment/alignment_handler.c:558:5-7: Unneeded variable: "rc". Return "0" Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com> --- .../powerpc/alignment/alignment_handler.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tools/testing/selftests/powerpc/alignment/alignment_handler.c b/tools/testing/selftests/powerpc/alignment/alignment_handler.c index 33ee34fc0828..4980656c3f70 100644 --- a/tools/testing/selftests/powerpc/alignment/alignment_handler.c +++ b/tools/testing/selftests/powerpc/alignment/alignment_handler.c @@ -332,7 +332,7 @@ int test_alignment_handler_vsx_206(void) STORE_VSX_XFORM_TEST(stxvd2x); STORE_VSX_XFORM_TEST(stxvw4x); STORE_VSX_XFORM_TEST(stxsdx); - return rc; + return 0; } int test_alignment_handler_vsx_207(void) @@ -348,7 +348,7 @@ int test_alignment_handler_vsx_207(void) LOAD_VSX_XFORM_TEST(lxsiwzx); STORE_VSX_XFORM_TEST(stxsspx); STORE_VSX_XFORM_TEST(stxsiwx); - return rc; + return 0; } int test_alignment_handler_vsx_300(void) @@ -380,7 +380,7 @@ int test_alignment_handler_vsx_300(void) STORE_VSX_XFORM_TEST(stxvx); STORE_VSX_XFORM_TEST(stxvl); STORE_VSX_XFORM_TEST(stxvll); - return rc; + return 0; } int test_alignment_handler_vsx_prefix(void) @@ -399,7 +399,7 @@ int test_alignment_handler_vsx_prefix(void) STORE_VSX_8LS_PREFIX_TEST(PSTXSSP, 0); STORE_VSX_8LS_PREFIX_TEST(PSTXV0, 0); STORE_VSX_8LS_PREFIX_TEST(PSTXV1, 1); - return rc; + return 0; } int test_alignment_handler_integer(void) @@ -458,7 +458,7 @@ int test_alignment_handler_integer(void) STORE_DFORM_TEST(stmw); #endif - return rc; + return 0; } int test_alignment_handler_integer_206(void) @@ -473,7 +473,7 @@ int test_alignment_handler_integer_206(void) LOAD_XFORM_TEST(ldbrx); STORE_XFORM_TEST(stdbrx); - return rc; + return 0; } int test_alignment_handler_integer_prefix(void) @@ -494,7 +494,7 @@ int test_alignment_handler_integer_prefix(void) STORE_MLS_PREFIX_TEST(PSTH); STORE_MLS_PREFIX_TEST(PSTW); STORE_8LS_PREFIX_TEST(PSTD); - return rc; + return 0; } int test_alignment_handler_vmx(void) @@ -522,7 +522,7 @@ int test_alignment_handler_vmx(void) STORE_VMX_XFORM_TEST(stvehx); STORE_VMX_XFORM_TEST(stvewx); STORE_VMX_XFORM_TEST(stvxl); - return rc; + return 0; } int test_alignment_handler_fp(void) @@ -550,7 +550,7 @@ int test_alignment_handler_fp(void) STORE_FLOAT_XFORM_TEST(stfsux); STORE_FLOAT_XFORM_TEST(stfiwx); - return rc; + return 0; } int test_alignment_handler_fp_205(void) @@ -568,7 +568,7 @@ int test_alignment_handler_fp_205(void) STORE_FLOAT_DFORM_TEST(stfdp); STORE_FLOAT_XFORM_TEST(stfdpx); - return rc; + return 0; } int test_alignment_handler_fp_206(void) @@ -582,7 +582,7 @@ int test_alignment_handler_fp_206(void) LOAD_FLOAT_XFORM_TEST(lfiwzx); - return rc; + return 0; } @@ -599,7 +599,7 @@ int test_alignment_handler_fp_prefix(void) LOAD_FLOAT_MLS_PREFIX_TEST(PLFD); STORE_FLOAT_MLS_PREFIX_TEST(PSTFS); STORE_FLOAT_MLS_PREFIX_TEST(PSTFD); - return rc; + return 0; } void usage(char *prog) ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] selftests/powerpc: Remove unneeded variable @ 2023-06-14 7:12 ` wuyonggang001 0 siblings, 0 replies; 5+ messages in thread From: wuyonggang001 @ 2023-06-14 7:12 UTC (permalink / raw) To: shuah; +Cc: linuxppc-dev, linux-kernel, linux-kselftest Fix the following coccicheck warning: tools/testing/selftests/powerpc/alignment/alignment_handler.c:558:5-7: Unneeded variable: "rc". Return "0" Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com> --- .../powerpc/alignment/alignment_handler.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tools/testing/selftests/powerpc/alignment/alignment_handler.c b/tools/testing/selftests/powerpc/alignment/alignment_handler.c index 33ee34fc0828..4980656c3f70 100644 --- a/tools/testing/selftests/powerpc/alignment/alignment_handler.c +++ b/tools/testing/selftests/powerpc/alignment/alignment_handler.c @@ -332,7 +332,7 @@ int test_alignment_handler_vsx_206(void) STORE_VSX_XFORM_TEST(stxvd2x); STORE_VSX_XFORM_TEST(stxvw4x); STORE_VSX_XFORM_TEST(stxsdx); - return rc; + return 0; } int test_alignment_handler_vsx_207(void) @@ -348,7 +348,7 @@ int test_alignment_handler_vsx_207(void) LOAD_VSX_XFORM_TEST(lxsiwzx); STORE_VSX_XFORM_TEST(stxsspx); STORE_VSX_XFORM_TEST(stxsiwx); - return rc; + return 0; } int test_alignment_handler_vsx_300(void) @@ -380,7 +380,7 @@ int test_alignment_handler_vsx_300(void) STORE_VSX_XFORM_TEST(stxvx); STORE_VSX_XFORM_TEST(stxvl); STORE_VSX_XFORM_TEST(stxvll); - return rc; + return 0; } int test_alignment_handler_vsx_prefix(void) @@ -399,7 +399,7 @@ int test_alignment_handler_vsx_prefix(void) STORE_VSX_8LS_PREFIX_TEST(PSTXSSP, 0); STORE_VSX_8LS_PREFIX_TEST(PSTXV0, 0); STORE_VSX_8LS_PREFIX_TEST(PSTXV1, 1); - return rc; + return 0; } int test_alignment_handler_integer(void) @@ -458,7 +458,7 @@ int test_alignment_handler_integer(void) STORE_DFORM_TEST(stmw); #endif - return rc; + return 0; } int test_alignment_handler_integer_206(void) @@ -473,7 +473,7 @@ int test_alignment_handler_integer_206(void) LOAD_XFORM_TEST(ldbrx); STORE_XFORM_TEST(stdbrx); - return rc; + return 0; } int test_alignment_handler_integer_prefix(void) @@ -494,7 +494,7 @@ int test_alignment_handler_integer_prefix(void) STORE_MLS_PREFIX_TEST(PSTH); STORE_MLS_PREFIX_TEST(PSTW); STORE_8LS_PREFIX_TEST(PSTD); - return rc; + return 0; } int test_alignment_handler_vmx(void) @@ -522,7 +522,7 @@ int test_alignment_handler_vmx(void) STORE_VMX_XFORM_TEST(stvehx); STORE_VMX_XFORM_TEST(stvewx); STORE_VMX_XFORM_TEST(stvxl); - return rc; + return 0; } int test_alignment_handler_fp(void) @@ -550,7 +550,7 @@ int test_alignment_handler_fp(void) STORE_FLOAT_XFORM_TEST(stfsux); STORE_FLOAT_XFORM_TEST(stfiwx); - return rc; + return 0; } int test_alignment_handler_fp_205(void) @@ -568,7 +568,7 @@ int test_alignment_handler_fp_205(void) STORE_FLOAT_DFORM_TEST(stfdp); STORE_FLOAT_XFORM_TEST(stfdpx); - return rc; + return 0; } int test_alignment_handler_fp_206(void) @@ -582,7 +582,7 @@ int test_alignment_handler_fp_206(void) LOAD_FLOAT_XFORM_TEST(lfiwzx); - return rc; + return 0; } @@ -599,7 +599,7 @@ int test_alignment_handler_fp_prefix(void) LOAD_FLOAT_MLS_PREFIX_TEST(PLFD); STORE_FLOAT_MLS_PREFIX_TEST(PSTFS); STORE_FLOAT_MLS_PREFIX_TEST(PSTFD); - return rc; + return 0; } void usage(char *prog) ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/powerpc: Remove unneeded variable 2023-06-14 7:12 ` wuyonggang001 @ 2023-06-15 3:51 ` Michael Ellerman -1 siblings, 0 replies; 5+ messages in thread From: Michael Ellerman @ 2023-06-15 3:51 UTC (permalink / raw) To: wuyonggang001, shuah; +Cc: linuxppc-dev, linux-kselftest, linux-kernel wuyonggang001@208suo.com writes: > Fix the following coccicheck warning: > > tools/testing/selftests/powerpc/alignment/alignment_handler.c:558:5-7: > Unneeded variable: "rc". Return "0" The check is wrong. > diff --git > a/tools/testing/selftests/powerpc/alignment/alignment_handler.c > b/tools/testing/selftests/powerpc/alignment/alignment_handler.c > index 33ee34fc0828..4980656c3f70 100644 > --- a/tools/testing/selftests/powerpc/alignment/alignment_handler.c > +++ b/tools/testing/selftests/powerpc/alignment/alignment_handler.c > @@ -332,7 +332,7 @@ int test_alignment_handler_vsx_206(void) > STORE_VSX_XFORM_TEST(stxvd2x); > STORE_VSX_XFORM_TEST(stxvw4x); > STORE_VSX_XFORM_TEST(stxsdx); > - return rc; > + return 0; rc is used in the macros. cheers ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/powerpc: Remove unneeded variable @ 2023-06-15 3:51 ` Michael Ellerman 0 siblings, 0 replies; 5+ messages in thread From: Michael Ellerman @ 2023-06-15 3:51 UTC (permalink / raw) To: wuyonggang001, shuah; +Cc: linuxppc-dev, linux-kernel, linux-kselftest wuyonggang001@208suo.com writes: > Fix the following coccicheck warning: > > tools/testing/selftests/powerpc/alignment/alignment_handler.c:558:5-7: > Unneeded variable: "rc". Return "0" The check is wrong. > diff --git > a/tools/testing/selftests/powerpc/alignment/alignment_handler.c > b/tools/testing/selftests/powerpc/alignment/alignment_handler.c > index 33ee34fc0828..4980656c3f70 100644 > --- a/tools/testing/selftests/powerpc/alignment/alignment_handler.c > +++ b/tools/testing/selftests/powerpc/alignment/alignment_handler.c > @@ -332,7 +332,7 @@ int test_alignment_handler_vsx_206(void) > STORE_VSX_XFORM_TEST(stxvd2x); > STORE_VSX_XFORM_TEST(stxvw4x); > STORE_VSX_XFORM_TEST(stxsdx); > - return rc; > + return 0; rc is used in the macros. cheers ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-15 3:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230614064848.5648-1-luojianhong@cdjrlc.com>
2023-06-14 6:51 ` [PATCH] selftests/powerpc: remove unneeded variable baomingtong001
[not found] <20230614070926.36395-1-zhanglibing@cdjrlc.com>
2023-06-14 7:12 ` [PATCH] selftests/powerpc: Remove " wuyonggang001
2023-06-14 7:12 ` wuyonggang001
2023-06-15 3:51 ` Michael Ellerman
2023-06-15 3:51 ` Michael Ellerman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.