All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Arpit Saini <arpit.saini@oss.qualcomm.com>,
	Nabige Aala <nabige.aala@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
Date: Fri, 10 Jul 2026 14:10:48 +0200	[thread overview]
Message-ID: <d7322cb1-1c8f-4c81-a3c0-638d60b53230@oss.qualcomm.com> (raw)
In-Reply-To: <6f8d8cf5-1e35-4d45-b2c1-6f36ac51ad4a@oss.qualcomm.com>

On 7/10/26 1:58 PM, Arpit Saini wrote:
> Hi Konrad,
> 
> On 7/10/2026 2:31 PM, Arpit Saini wrote:
>> Hi Konrad,
>>
>> On 7/6/2026 3:33 PM, Konrad Dybcio wrote:
>>> On 7/6/26 8:04 AM, Nabige Aala wrote:
>>>> From: Arpit Saini <arpit.saini@oss.qualcomm.com>

[...]

>>>> +    panel_bl_en_suspend: panel-bl-en-suspend-state {
>>>> +        pins = "gpio91";
>>>> +        function = "gpio";
>>>> +        drive-strength = <2>;
>>>> +        bias-pull-down;
>>>> +        output-low;
>>>> +    };
>>> output-foo isn't necessary, the panel driver will assert it as
>>> necessary
>>>
>>> Konrad
>>
>> Ack, thanks for pointing out.
>>
>> Arpit
>>
> I just checked,
> 
> Normally the backlight EN pin is controlled by a backlight driver.
> 
> However, this panel uses MIPI DCS based backlight control with no
> 
> separate backlight driver. Since there is no driver to assert gpio91,
> 
> we control it via the panel's pinctrl default state..
> 
> So this is platform specific pin , we need this to enable/disable
> 
> the backlight.

Why would the backlight state be so tightly defined by the panel?
Disabling or adjusting the backlight level without shutting down
the panel is a perfectly valid use case.

Take a look at pwm-backlight or gpio-backlight.

Konrad

P.S. Set `mailnews.wraplength = 0` in your thunderbird config - it
currently inserts an extra \n between every single line

  reply	other threads:[~2026-07-10 12:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06  6:04 [PATCH v2 0/4] arm64: qcom: dts: Add display support for Qualcomm Shikra Nabige Aala
2026-07-06  6:04 ` [PATCH v2 1/4] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala
2026-07-06 12:59   ` Konrad Dybcio
2026-07-06  6:04 ` [PATCH v2 2/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel Nabige Aala
2026-07-06  6:33   ` Krzysztof Kozlowski
2026-07-06  8:52     ` Arpit Saini
2026-07-06  9:19       ` Krzysztof Kozlowski
2026-07-06 13:48         ` Dmitry Baryshkov
2026-07-06 15:33           ` Krzysztof Kozlowski
2026-07-06 10:03   ` Konrad Dybcio
2026-07-10  9:01     ` Arpit Saini
2026-07-10 11:58       ` Arpit Saini
2026-07-10 12:10         ` Konrad Dybcio [this message]
2026-07-10 12:47           ` Dmitry Baryshkov
2026-07-10 12:57             ` Konrad Dybcio
2026-07-10 12:39         ` Dmitry Baryshkov
2026-07-14  7:21           ` Arpit Saini
2026-07-16 17:51             ` Konrad Dybcio
2026-07-20 12:07               ` Arpit Saini
2026-07-20 13:05                 ` Dmitry Baryshkov
2026-07-21  9:05                   ` Arpit Saini
2026-07-21 22:27                     ` Dmitry Baryshkov
2026-07-28  5:44                       ` Arpit Saini
2026-08-28  8:24                         ` Arpit Saini
2026-08-28  9:35                         ` Arpit Saini
2026-07-10 12:49   ` Dmitry Baryshkov
2026-07-10 13:06     ` Arpit Saini
2026-07-20 13:06       ` Dmitry Baryshkov
2026-07-06  6:04 ` [PATCH v2 3/4] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
2026-07-06  6:04 ` [PATCH v2 4/4] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala
2026-07-06  6:34   ` Krzysztof Kozlowski
2026-07-06  8:54     ` Arpit Saini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7322cb1-1c8f-4c81-a3c0-638d60b53230@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=arpit.saini@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nabige.aala@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.