[PATCH] serial: Fix incorrect dependency for debug sifive serial driver

[PATCH] serial: Fix incorrect dependency for debug sifive serial driver

[Sean Anderson]

The debug sifive serial driver depends on the wrong serial driver, making
it unselectable.

Fixes: 4cc24aeaf42 ("serial: Add missing Kconfig dependencies for debug
consoles")

Signed-off-by: Sean Anderson <seanga2@gmail.com>
CC: Michal Simek <michal.simek@xilinx.com>
---

 drivers/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 14df2e9247..e146ffc5f8 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX
 
 config DEBUG_UART_SIFIVE
 	bool "SiFive UART"
-	depends on PL01X_SERIAL
+	depends on SIFIVE_SERIAL
 	help
 	  Select this to enable a debug UART using the serial_sifive driver. You
 	  will need to provide parameters to make this work. The driver will
-- 
2.27.0

[PATCH] serial: Fix incorrect dependency for debug sifive serial driver

[Michal Simek]

Hi Sean,

On 21. 07. 20 15:58, Sean Anderson wrote:
> The debug sifive serial driver depends on the wrong serial driver, making
> it unselectable.
> 
> Fixes: 4cc24aeaf42 ("serial: Add missing Kconfig dependencies for debug
> consoles")
> 
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> CC: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  drivers/serial/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index 14df2e9247..e146ffc5f8 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX
>  
>  config DEBUG_UART_SIFIVE
>  	bool "SiFive UART"
> -	depends on PL01X_SERIAL
> +	depends on SIFIVE_SERIAL
>  	help
>  	  Select this to enable a debug UART using the serial_sifive driver. You
>  	  will need to provide parameters to make this work. The driver will
> 

I have already sent a fix for it.
https://lists.denx.de/pipermail/u-boot/2020-July/419649.html

Please ack.

Thanks,
Michal

[PATCH] serial: Fix incorrect dependency for debug sifive serial driver

[Sean Anderson]

On 7/21/20 10:00 AM, Michal Simek wrote:
> Hi Sean,
> 
> On 21. 07. 20 15:58, Sean Anderson wrote:
>> The debug sifive serial driver depends on the wrong serial driver, making
>> it unselectable.
>>
>> Fixes: 4cc24aeaf42 ("serial: Add missing Kconfig dependencies for debug
>> consoles")
>>
>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
>> CC: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  drivers/serial/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
>> index 14df2e9247..e146ffc5f8 100644
>> --- a/drivers/serial/Kconfig
>> +++ b/drivers/serial/Kconfig
>> @@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX
>>  
>>  config DEBUG_UART_SIFIVE
>>  	bool "SiFive UART"
>> -	depends on PL01X_SERIAL
>> +	depends on SIFIVE_SERIAL
>>  	help
>>  	  Select this to enable a debug UART using the serial_sifive driver. You
>>  	  will need to provide parameters to make this work. The driver will
>>
> 
> I have already sent a fix for it.
> https://lists.denx.de/pipermail/u-boot/2020-July/419649.html
> 
> Please ack.
> 
> Thanks,
> Michal
> 

Ah, thanks. I only found this when I needed to use the debug serial and
I couldn't select anything.

--Sean