Re: [PATCH 1/3] dt-bindings: phy: qcom,qmp-pcie: add optional current load properties

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ziyue Zhang <quic_ziyuzhan@quicinc.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: vkoul@kernel.org, kishon@kernel.org, dmitry.baryshkov@linaro.org,
	abel.vesa@linaro.org, neil.armstrong@linaro.org,
	andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	quic_qianyu@quicinc.com
Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,qmp-pcie: add optional current load properties
Date: Thu, 12 Dec 2024 08:31:58 +0100	[thread overview]
Message-ID: <d803ead8-af3d-438a-9d9f-6194a7a5431a@kernel.org> (raw)
In-Reply-To: <16d109d8-d1be-4ecb-ba25-8e21e9d48dad@quicinc.com>

On 12/12/2024 08:29, Ziyue Zhang wrote:
>
>> In that case, I was wondering if the load set by the driver is going to vary
>> between platforms (boards) or not (question to Ziyue Zhang). If it varies
>> between SoC, then we can hardcode the load in driver based on compatible.
> 
> Hi Mani, Krzystof
> 
> Now we set  the current to 165mA which is the max power supply the regulator
> can provide, so this is platform(boards) related. But we think PCIe PHY needs

Yeah, so that's the answer to what I asked just a second ago - you do
not put there device load. You put there regulator constraints.

> to set the current value we need, which is soc related.

So move it away from DT. I don't care what's in the driver, so you can
put there whatever fake value.

Best regards,
Krzysztof