Re: [PATCH blktests 2/3] nvme/060: add test nvme fabrics target resetting during I/O

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 3/19/25 02:26, Daniel Wagner wrote:
> On Tue, Mar 18, 2025 at 08:40:39PM +0000, Chaitanya Kulkarni wrote:
>> On 3/18/25 03:39, Daniel Wagner wrote:
>>> Newer kernel support to reset the target via the debugfs. Add a new test
>>> case which exercises this interface.
>>>
>>> Signed-off-by: Daniel Wagner<wagi@kernel.org>
>> Looks useful to me given that its a different code path in the target.
> One thing I forgot to add a check if the feature is available. I think
> the only way is to setup a target and see if the relevant file shows
> up...

perhaps create a controller and in absence of NVMET_DFS skipping the 
test with right reason is a way to go ?

It will also be helpful if you just create a helper that will create
a controller that way any future tests that needs to check for
specific feature via configfs files can use it. That helper will also
get called from requires() in order to set the right SKIP_REASON.

>> do we have any testcaes similar for non-debugfs code path ?
>> (don't remember at this point)
> There is not direct way to trigger a target reset via a nvme command
> yet. The upcoming TP8028 brings cross controller reset.

It will be nice.

> We have an indirect way to trigger a reset, via changing the number of
> queues the target supports (this test case is already there).

ahh thanks..

-ck