All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	linux-kernel@vger.kernel.org, monstr@monstr.eu,
	michal.simek@xilinx.com, git@xilinx.com
Cc: Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: interrupt-controller: Add Xilinx INTC binding
Date: Tue, 22 Jul 2025 09:32:58 +0200	[thread overview]
Message-ID: <da1c19c7-60af-4841-9554-7758324a58bf@amd.com> (raw)
In-Reply-To: <b30f00c3-9062-4d19-8088-5fc5e951eb5d@kernel.org>



On 7/22/25 09:17, Krzysztof Kozlowski wrote:
> On 22/07/2025 08:49, Michal Simek wrote:
>> Add description for AMD/Xilinx interrupt controller.
>> IP acts as primary interrupt controller on Microblaze systems or can be
>> used as secondary interrupt controller on ARM based systems like Zynq,
>> ZynqMP, Versal or Versal Gen 2. Also as secondary interrupt controller on
>> Microblaze-V (Risc-V) systems.
>>
>> Over the years IP exists in multiple variants based on attached bus as OPB,
>> PLB or AXI that's why generic filename is used.
>>
>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>> ---
>>
>> https://docs.amd.com/v/u/en-US/pg099-axi-intc
> 
> 
> We usually do not take bindings without users, that's why bindings patch
> is always part of some other patchset. Commit msg also did not clarify
> the usecase here (or exception).

Example DT is already the part of arch/microblaze/.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/microblaze/boot/dts/system.dts?h=v6.16-rc7#n338

DT has been added in 2014 before dt bindings that's why it was never documented.

Thanks,
Michal

  reply	other threads:[~2025-07-22  7:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22  6:49 [PATCH] dt-bindings: interrupt-controller: Add Xilinx INTC binding Michal Simek
2025-07-22  7:17 ` Krzysztof Kozlowski
2025-07-22  7:32   ` Michal Simek [this message]
2025-07-22  7:37     ` Krzysztof Kozlowski
2025-07-22  7:40 ` Krzysztof Kozlowski
2025-07-22  8:12   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da1c19c7-60af-4841-9554-7758324a58bf@amd.com \
    --to=michal.simek@amd.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=git@xilinx.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=monstr@monstr.eu \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.