apt-package.inc commented out section still evaluated

apt-package.inc commented out section still evaluated

[Kevin Kettinger]

Hello,

when looking into poky/meta/recipes-devtools/apt/apt-package.inc 
(dunfell), i see some section commented out (/*) in do_install():

---
do_install() {
...
install -d ${D}${libdir}/apt/methods

install -m 0755 bin/methods/* ${D}${libdir}/apt/methods/  # <--

install -d ${D}${libdir}/dpkg/methods/apt
install -m 0644 ${S}/dselect/desc.apt ${D}${libdir}/dpkg/methods/apt/
install -m 0644 ${S}/dselect/names ${D}${libdir}/dpkg/methods/apt/
...
---

But it is still evaluated when checking with `bitbake -e apt`.

I noticed it when the apt-daily service was still triggered after 
disabling the systemd service. In the commented out section the cronjob 
file 'apt.apt-compat.cron.daily' is installed, which triggers the service.

Is this a bug?

Thanks.

Build Configuration:
BB_VERSION           = "1.46.0"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "universal"
TARGET_SYS           = "arm-poky-linux-gnueabi"
MACHINE              = "hp00164"
DISTRO               = "xxxxxx"
DISTRO_VERSION       = "3.1.1"
TUNE_FEATURES        = "arm vfp cortexa7 neon vfpv4 thumb 
callconvention-hard"
TARGET_FPU           = "hard"
meta
meta-poky            = "HEAD:39d7cf1abb2c88baaedb3a627eba8827747b2eb9"
meta-oe
meta-filesystems
meta-multimedia
meta-networking
meta-python
meta-webserver       = "HEAD:d7b41ced4b9a9a68083b0fcceff3b226298cff8b"
meta-iot-cloud       = "HEAD:45f83bbef34fb7760942e0ab650ab107053032d6"
meta-qt5             = "HEAD:0e7015f7a86dda995a39662edbb5c26da647c496"
meta-rust            = "HEAD:318fb46863c0df5001f937bb4ca856491a493725"
meta-bytesatwork     = "HEAD:e7db1dc2aa722dae27b6c15fddced0ef1a3d4d54"
meta-st-stm32mp      = "HEAD:36a9911705bd37df136e9ac51dbf418861d510c9"
meta-bytesatwork-st  = "HEAD:131629cf9db0e6000290e22f38943b324219a2bd"

Thanks.

Mit freundlichen Grüßen / Best regards,
Kevin Kettinger

Re: [poky] apt-package.inc commented out section still evaluated

[Quentin Schulz]

Hi Kevin,

On Wed, Jan 20, 2021 at 12:05:35PM +0100, Kevin Kettinger wrote:
> Hello,
> 
> when looking into poky/meta/recipes-devtools/apt/apt-package.inc (dunfell),
> i see some section commented out (/*) in do_install():

That do_install task is a shell task, so /* is just a way to say "all
files from this directory", it is not a comment.

The only other supported kind of task is python task and the python
comments are usually # or """ (triple double quote surrounding some
text).

So no surprise here, it works as intended :)

It obviously does not mean that the installation of the cronjob file
when the systemd unit is disabled is correct, but it's a different
topic there and I cannot help with this one.

Cheers,
Quentin