All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Itaru Kitayama <itaru.kitayama@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] arm64/mm: Add pud_sect_supported()
Date: Wed, 22 Sep 2021 10:37:27 +0530	[thread overview]
Message-ID: <da59cd2e-9666-b236-8b23-49bd51a1c784@arm.com> (raw)
In-Reply-To: <CANW9uyveSs-+DgGr87jYtruYcS7_FMxS=VD7mM4-G8NNcqBqNQ@mail.gmail.com>



On 9/22/21 10:22 AM, Itaru Kitayama wrote:
> How did you test the 16K page size configurations? In QEMU? I wasn't
> aware of hardware that's capable 16KB page size.

FVP (Fixed Virtual Platforms).

> 
> On Wed, Sep 22, 2021 at 1:47 PM Anshuman Khandual
> <anshuman.khandual@arm.com> wrote:
>>
>>
>>
>> On 9/20/21 9:11 PM, Catalin Marinas wrote:
>>> On Mon, Sep 20, 2021 at 02:59:31PM +0530, Anshuman Khandual wrote:
>>>> Section mapping at PUD level is supported only on 4K pages and currently it
>>>> gets verified with explicit #ifdef or IS_ENABLED() constructs. This adds a
>>>> new helper pud_sect_supported() for this purpose, which particularly cleans
>>>> up the HugeTLB code path. It updates relevant switch statements with checks
>>>> for __PAGETABLE_PMD_FOLDED in order to avoid build failures caused with two
>>>> identical switch case values in those code blocks.
>>>>
>>>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>>>> Cc: Will Deacon <will@kernel.org>
>>>> Cc: linux-arm-kernel@lists.infradead.org
>>>> Cc: linux-kernel@vger.kernel.org
>>>> Suggested-by: Mark Rutland <mark.rutland@arm.com>
>>>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>>>
>>> Assuming that you tested the corresponding configurations,
>>
>> Right, I did test this on all page size and VA bits configurations
>> , including the specific ones which were problematic.
>>
>>>
>>> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
>>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Itaru Kitayama <itaru.kitayama@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] arm64/mm: Add pud_sect_supported()
Date: Wed, 22 Sep 2021 10:37:27 +0530	[thread overview]
Message-ID: <da59cd2e-9666-b236-8b23-49bd51a1c784@arm.com> (raw)
In-Reply-To: <CANW9uyveSs-+DgGr87jYtruYcS7_FMxS=VD7mM4-G8NNcqBqNQ@mail.gmail.com>



On 9/22/21 10:22 AM, Itaru Kitayama wrote:
> How did you test the 16K page size configurations? In QEMU? I wasn't
> aware of hardware that's capable 16KB page size.

FVP (Fixed Virtual Platforms).

> 
> On Wed, Sep 22, 2021 at 1:47 PM Anshuman Khandual
> <anshuman.khandual@arm.com> wrote:
>>
>>
>>
>> On 9/20/21 9:11 PM, Catalin Marinas wrote:
>>> On Mon, Sep 20, 2021 at 02:59:31PM +0530, Anshuman Khandual wrote:
>>>> Section mapping at PUD level is supported only on 4K pages and currently it
>>>> gets verified with explicit #ifdef or IS_ENABLED() constructs. This adds a
>>>> new helper pud_sect_supported() for this purpose, which particularly cleans
>>>> up the HugeTLB code path. It updates relevant switch statements with checks
>>>> for __PAGETABLE_PMD_FOLDED in order to avoid build failures caused with two
>>>> identical switch case values in those code blocks.
>>>>
>>>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>>>> Cc: Will Deacon <will@kernel.org>
>>>> Cc: linux-arm-kernel@lists.infradead.org
>>>> Cc: linux-kernel@vger.kernel.org
>>>> Suggested-by: Mark Rutland <mark.rutland@arm.com>
>>>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>>>
>>> Assuming that you tested the corresponding configurations,
>>
>> Right, I did test this on all page size and VA bits configurations
>> , including the specific ones which were problematic.
>>
>>>
>>> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
>>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-22  5:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20  9:29 [PATCH V2] arm64/mm: Add pud_sect_supported() Anshuman Khandual
2021-09-20  9:29 ` Anshuman Khandual
2021-09-20 15:41 ` Catalin Marinas
2021-09-20 15:41   ` Catalin Marinas
2021-09-22  4:44   ` Anshuman Khandual
2021-09-22  4:44     ` Anshuman Khandual
2021-09-22  4:52     ` Itaru Kitayama
2021-09-22  4:52       ` Itaru Kitayama
2021-09-22  5:07       ` Anshuman Khandual [this message]
2021-09-22  5:07         ` Anshuman Khandual
2021-09-22  9:52       ` Catalin Marinas
2021-09-22  9:52         ` Catalin Marinas
2021-09-29 17:48 ` Will Deacon
2021-09-29 17:48   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da59cd2e-9666-b236-8b23-49bd51a1c784@arm.com \
    --to=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=itaru.kitayama@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.