Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver

From: Javier Martinez Canillas <javierm@redhat.com>
To: "Ondřej Jirman" <megi@xff.cz>,
	linux-kernel@vger.kernel.org,
	"Kamil Trzciński" <ayufan@ayufan.eu>,
	"Martijn Braam" <martijn@brixit.nl>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Robert Mader" <robert.mader@posteo.de>,
	"Tom Fitzhenry" <tom@tom-fitzhenry.me.uk>,
	"Peter Robinson" <pbrobinson@gmail.com>,
	"Onuralp Sezer" <thunderbirdtr@fedoraproject.org>,
	dri-devel@lists.freedesktop.org,
	"Maya Matuszczyk" <maccraft123mc@gmail.com>,
	"Neal Gompa" <ngompa13@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"David Airlie" <airlied@gmail.com>,
	"Thierry Reding" <thierry.reding@gmail.com>
Subject: Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver
Date: Mon, 2 Jan 2023 19:51:08 +0100	[thread overview]
Message-ID: <da5c9ec8-da44-3dff-11c7-2160e335227f@redhat.com> (raw)
In-Reply-To: <20230102152041.7rc2uts7o37fnsen@core>

On 1/2/23 16:20, Ondřej Jirman wrote:
> On Mon, Jan 02, 2023 at 02:51:42PM +0100, Javier Martinez Canillas wrote:
>> Hello Ondřej,
>>
>> [...]
>>
>> My goal was to have some initial support in mainline even if there could be some
>> issues. IMO it is better to use upstream as a baseline and attempt to support the
>> PPP incrementally.
>>
>> But since you are aware of the issues and know what are the available fixes, I'll
>> let you continue with the effort and take care of the patches. Hopefully there may
>> be things that will be helpful, such as the binding schema patch and the collected
>> tags. I can also take care of pushing the DRM bits to the drm-misc-next tree once
>> you feel that those are ready to get merged.
> 
> Ok. The panel driver itself works fine with some changes in other DRM drivers.
> In fact, it will not need any changes, assuming the to be proposed fixes to
> dw-mipi-dsi will pass, too. So I don't have many objections against this driver
> itself.
>

Exactly, that is what I was trying to say. Awesome that you agree with that.

> I'm not sure I should be giving reviewed-by to driver I co-wrote. :) Anyway,

Indeed :)

> I checked it again, and only issue I found was that shutdown callback tries
> to disable the panel even if it may already be disabled, which will lead to
> unbalanced calls to regulator_disable functions, which may produce some needless
> warnings on shutdown/reboot.
> 
> So if you want to commit this driver now, go ahead. DT will need one more round.
> 
> As you say, the overall usable support for Pinephone Pro in mainline is still
> way off into the future, so I agree it's not necessary to get hung up on these
> issues. I can do a DT revision + add in the other suggested DRM patches, so that
> there's at least a searchable public record of the remaining issues.
> 

Perfect, sounds like a plan. I'll re-spin a v5 that only includes the panel
patches then and drop the DTS. Thanks again for your feedback and comments!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel