Re: [PATCH v3 2/3] efi_loader: Set default console colors on efi_cout_clear_screen if needed

[Jan Kiszka <jan.kiszka@siemens.com>]

On 04.11.22 09:06, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Ensures a consistent background color of the whole screen for succeeding
> outputs as both demanded by the spec and implemented in EDK2 as well.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  lib/efi_loader/efi_console.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c
> index 6ce0fcc168d..4228a509caf 100644
> --- a/lib/efi_loader/efi_console.c
> +++ b/lib/efi_loader/efi_console.c
> @@ -495,6 +495,12 @@ static efi_status_t EFIAPI efi_cout_clear_screen(
>  {
>  	EFI_ENTRY("%p", this);
>  
> +	/* Set default colors if not done yet */
> +	if (efi_con_mode.attribute == 0) {
> +		efi_con_mode.attribute = 0x07;
> +		printf(ESC "[0;37;40m");
> +	}
> +
>  	efi_clear_screen();
>  
>  	return EFI_EXIT(EFI_SUCCESS);

And what about this visual fix? It does not depend on patch 1.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux