From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH] target/i386/kvm: Add missing fallthrough comment
Date: Fri, 11 Sep 2020 15:43:43 +0200 [thread overview]
Message-ID: <db773405-e9da-e98b-8da5-d13fef8b596b@redhat.com> (raw)
In-Reply-To: <20200911125301.413081-1-thuth@redhat.com>
On 11/09/20 14:53, Thomas Huth wrote:
> Let's make this file compilable with -Werror=implicit-fallthrough :
> Looking at the code, it seems like the fallthrough is intended here,
> so we should add the corresponding "/* fallthrough */" comment here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/i386/kvm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> index 205b68bc0c..283d3305d5 100644
> --- a/target/i386/kvm.c
> +++ b/target/i386/kvm.c
> @@ -1568,6 +1568,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
> if (env->nr_dies < 2) {
> break;
> }
> + /* fallthrough */
> case 4:
> case 0xb:
> case 0xd:
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Marcelo Tosatti <mtosatti@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] target/i386/kvm: Add missing fallthrough comment
Date: Fri, 11 Sep 2020 15:43:43 +0200 [thread overview]
Message-ID: <db773405-e9da-e98b-8da5-d13fef8b596b@redhat.com> (raw)
In-Reply-To: <20200911125301.413081-1-thuth@redhat.com>
On 11/09/20 14:53, Thomas Huth wrote:
> Let's make this file compilable with -Werror=implicit-fallthrough :
> Looking at the code, it seems like the fallthrough is intended here,
> so we should add the corresponding "/* fallthrough */" comment here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/i386/kvm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> index 205b68bc0c..283d3305d5 100644
> --- a/target/i386/kvm.c
> +++ b/target/i386/kvm.c
> @@ -1568,6 +1568,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
> if (env->nr_dies < 2) {
> break;
> }
> + /* fallthrough */
> case 4:
> case 0xb:
> case 0xd:
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2020-09-11 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 12:53 [PATCH] target/i386/kvm: Add missing fallthrough comment Thomas Huth
2020-09-11 12:53 ` Thomas Huth
2020-09-11 13:43 ` Paolo Bonzini [this message]
2020-09-11 13:43 ` Paolo Bonzini
2020-09-11 13:51 ` no-reply
2020-09-11 13:51 ` no-reply
2020-09-11 19:23 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db773405-e9da-e98b-8da5-d13fef8b596b@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.