From: David Collins <collinsd@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings
Date: Wed, 2 May 2018 17:13:00 -0700 [thread overview]
Message-ID: <db8970ea-05f4-e7c0-52fa-070c7a6b8d2e@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=UDUKg58xe+3C5QUbFwFkO8d3c_tzxmfPDzdv1KXZ3W9g@mail.gmail.com>
On 05/02/2018 09:37 AM, Doug Anderson wrote:
> On Fri, Apr 13, 2018 at 7:50 PM, David Collins <collinsd@codeaurora.org> wrote:
>> +- vdd_l26-supply
>> +- vdd_lvs1_lvs2-supply
>> +- vdd_lvs1_lvs2-supply
>> + Usage: optional (PM8998 only)
>> + Value type: <phandle>
>> + Definition: phandle of the parent supply regulator of one or more of the
>> + regulators for this PMIC.
>
> One small additional nit here is that "vdd_lvs1_lvs2-supply" is listed twice.
I'll remove the duplicate.
> Also on the schematics (and in the PM8998 datasheet) I have this is
> "VIN_LVS_1_2". It seems like you should be consistent here and call
> this "vin-lvs-1-2-supply".
I was trying to keep the naming consistent within device tree binding
documentation for LVS vs LDO and SMPS (e.g. 'vdd' vs 'vin' prefix). I
suppose that I can change this to match the hardware documentation pin
name. I can also change '_' to '-' in the supply names if that is preferred.
Take care,
David
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: collinsd@codeaurora.org (David Collins)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings
Date: Wed, 2 May 2018 17:13:00 -0700 [thread overview]
Message-ID: <db8970ea-05f4-e7c0-52fa-070c7a6b8d2e@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=UDUKg58xe+3C5QUbFwFkO8d3c_tzxmfPDzdv1KXZ3W9g@mail.gmail.com>
On 05/02/2018 09:37 AM, Doug Anderson wrote:
> On Fri, Apr 13, 2018 at 7:50 PM, David Collins <collinsd@codeaurora.org> wrote:
>> +- vdd_l26-supply
>> +- vdd_lvs1_lvs2-supply
>> +- vdd_lvs1_lvs2-supply
>> + Usage: optional (PM8998 only)
>> + Value type: <phandle>
>> + Definition: phandle of the parent supply regulator of one or more of the
>> + regulators for this PMIC.
>
> One small additional nit here is that "vdd_lvs1_lvs2-supply" is listed twice.
I'll remove the duplicate.
> Also on the schematics (and in the PM8998 datasheet) I have this is
> "VIN_LVS_1_2". It seems like you should be consistent here and call
> this "vin-lvs-1-2-supply".
I was trying to keep the naming consistent within device tree binding
documentation for LVS vs LDO and SMPS (e.g. 'vdd' vs 'vin' prefix). I
suppose that I can change this to match the hardware documentation pin
name. I can also change '_' to '-' in the supply names if that is preferred.
Take care,
David
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-05-03 0:13 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 2:50 [PATCH v2 0/2] regulator: add QCOM RPMh regulator driver David Collins
2018-04-14 2:50 ` David Collins
2018-04-14 2:50 ` [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings David Collins
2018-04-14 2:50 ` David Collins
2018-04-16 20:57 ` Rob Herring
2018-04-16 20:57 ` Rob Herring
2018-04-16 22:06 ` David Collins
2018-04-16 22:06 ` David Collins
2018-04-17 20:06 ` Doug Anderson
2018-04-17 20:06 ` Doug Anderson
2018-04-18 21:44 ` David Collins
2018-04-18 21:44 ` David Collins
2018-05-02 16:37 ` Doug Anderson
2018-05-02 16:37 ` Doug Anderson
2018-05-03 0:13 ` David Collins [this message]
2018-05-03 0:13 ` David Collins
2018-05-03 15:01 ` Doug Anderson
2018-05-03 15:01 ` Doug Anderson
2018-04-14 2:50 ` [PATCH v2 2/2] regulator: add QCOM RPMh regulator driver David Collins
2018-04-14 2:50 ` David Collins
2018-04-17 18:23 ` [v2,2/2] " Matthias Kaehlcke
2018-04-17 18:23 ` Matthias Kaehlcke
2018-04-17 19:15 ` David Collins
2018-04-17 19:15 ` David Collins
2018-04-17 19:47 ` Matthias Kaehlcke
2018-04-17 19:47 ` Matthias Kaehlcke
2018-04-18 21:34 ` David Collins
2018-04-18 21:34 ` David Collins
2018-04-18 17:02 ` Mark Brown
2018-04-18 17:02 ` Mark Brown
2018-04-17 20:02 ` [PATCH v2 2/2] " Doug Anderson
2018-04-17 20:02 ` Doug Anderson
2018-04-18 23:30 ` David Collins
2018-04-18 23:30 ` David Collins
2018-04-19 6:04 ` Stephen Boyd
2018-04-19 6:04 ` Stephen Boyd
2018-04-19 16:16 ` Doug Anderson
2018-04-19 16:16 ` Doug Anderson
2018-04-20 22:08 ` David Collins
2018-04-20 22:08 ` David Collins
2018-04-24 17:45 ` Mark Brown
2018-04-24 17:45 ` Mark Brown
2018-04-24 21:09 ` David Collins
2018-04-24 21:09 ` David Collins
2018-04-25 10:31 ` Mark Brown
2018-04-25 10:31 ` Mark Brown
2018-04-25 21:04 ` David Collins
2018-04-25 21:04 ` David Collins
2018-05-01 21:02 ` Mark Brown
2018-05-01 21:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db8970ea-05f4-e7c0-52fa-070c7a6b8d2e@codeaurora.org \
--to=collinsd@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.