From: Yibo Zhao <yiboz@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless-owner@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2] fq: fix fq_tin tx bytes overflow
Date: Fri, 12 Apr 2019 18:09:03 +0800 [thread overview]
Message-ID: <dba1c91baf387a5e44743075ec7efbc2@codeaurora.org> (raw)
In-Reply-To: <717acf1bde5507f73436ae7d45d114b34aee1c05.camel@sipsolutions.net>
On 2019-04-09 04:01, Johannes Berg wrote:
> On Mon, 2019-03-18 at 12:59 +0800, Yibo Zhao wrote:
>>
>> I understand your concern. Yes, I am using high end AP for throughput
>> test. I'd say 1.2 Gbps is not the worst case since we can achieve max
>> 1.4Gbps according to our test. AFAIK, for most throughput cases, 1min
>> is
>> the minimum requirement. And I think, with more and more high end
>> products(even higher throughput) on the ways to the market, it is
>> highly
>> possible that 30s is not a safe time before overflow.
>
> Well, 2 Gbps (goodput) would make it overflow every 16 seconds, so I'm
> not sure where you take the 1 minute from :-) Maybe from 1.2Gbps PHY
> rate.
>
> But still, the only place we expose this is debugfs, so I'm not really
> sure we want to spend that.
>
> Note that I'm generally pushing back on statistics right now - I really
> want to put some trace points or eBPF hooks in places that people can
> use to keep their favourite statistics, instead of trying to cover each
> and every use case in the stack itself.
Cool, great!looking forward to that change. :-)
>
> johannes
--
Yibo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Yibo Zhao <yiboz@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH v2] fq: fix fq_tin tx bytes overflow
Date: Fri, 12 Apr 2019 18:09:03 +0800 [thread overview]
Message-ID: <dba1c91baf387a5e44743075ec7efbc2@codeaurora.org> (raw)
In-Reply-To: <717acf1bde5507f73436ae7d45d114b34aee1c05.camel@sipsolutions.net>
On 2019-04-09 04:01, Johannes Berg wrote:
> On Mon, 2019-03-18 at 12:59 +0800, Yibo Zhao wrote:
>>
>> I understand your concern. Yes, I am using high end AP for throughput
>> test. I'd say 1.2 Gbps is not the worst case since we can achieve max
>> 1.4Gbps according to our test. AFAIK, for most throughput cases, 1min
>> is
>> the minimum requirement. And I think, with more and more high end
>> products(even higher throughput) on the ways to the market, it is
>> highly
>> possible that 30s is not a safe time before overflow.
>
> Well, 2 Gbps (goodput) would make it overflow every 16 seconds, so I'm
> not sure where you take the 1 minute from :-) Maybe from 1.2Gbps PHY
> rate.
>
> But still, the only place we expose this is debugfs, so I'm not really
> sure we want to spend that.
>
> Note that I'm generally pushing back on statistics right now - I really
> want to put some trace points or eBPF hooks in places that people can
> use to keep their favourite statistics, instead of trying to cover each
> and every use case in the stack itself.
Cool, great!looking forward to that change. :-)
>
> johannes
--
Yibo
next prev parent reply other threads:[~2019-04-12 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 3:08 [PATCH v2] fq: fix fq_tin tx bytes overflow Yibo Zhao
2019-03-13 3:08 ` Yibo Zhao
2019-03-15 9:38 ` Johannes Berg
2019-03-15 9:38 ` Johannes Berg
2019-03-18 4:59 ` Yibo Zhao
2019-03-18 4:59 ` Yibo Zhao
2019-04-08 20:01 ` Johannes Berg
2019-04-08 20:01 ` Johannes Berg
2019-04-12 10:09 ` Yibo Zhao [this message]
2019-04-12 10:09 ` Yibo Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dba1c91baf387a5e44743075ec7efbc2@codeaurora.org \
--to=yiboz@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.