* [PATCH] drm/i915/skl: Fix big integer constant sparse warning @ 2014-11-14 14:20 Damien Lespiau 2014-11-14 16:27 ` Daniel Vetter 2014-11-14 23:54 ` [PATCH] drm/i915/skl: Fix big integer constant sparse shuang.he 0 siblings, 2 replies; 3+ messages in thread From: Damien Lespiau @ 2014-11-14 14:20 UTC (permalink / raw) To: intel-gfx intel_ddi.c:955:41: sparse: constant 8400000000 is so big it is long intel_ddi.c:955:53: sparse: constant 9000000000 is so big it is long intel_ddi.c:955:65: sparse: constant 9600000000 is so big it is long intel_ddi.c:1028:23: sparse: constant 9600000000 is so big it is long intel_ddi.c:1031:23: sparse: constant 9000000000 is so big it is long intel_ddi.c:1034:23: sparse: constant 8400000000 is so big it is long Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- drivers/gpu/drm/i915/intel_ddi.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index 17bf911..ca33ee9 100644 --- a/drivers/gpu/drm/i915/intel_ddi.c +++ b/drivers/gpu/drm/i915/intel_ddi.c @@ -952,7 +952,9 @@ skl_ddi_calculate_wrpll(int clock /* in Hz */, struct skl_wrpll_params *wrpll_params) { uint64_t afe_clock = clock * 5; /* AFE Clock is 5x Pixel clock */ - uint64_t dco_central_freq[3] = {8400000000, 9000000000, 9600000000}; + uint64_t dco_central_freq[3] = {8400000000ULL, + 9000000000ULL, + 9600000000ULL}; uint32_t min_dco_deviation = 400; uint32_t min_dco_index = 3; uint32_t P0[4] = {1, 2, 3, 7}; @@ -1025,13 +1027,13 @@ found: wrpll_params->central_freq = dco_central_freq[min_dco_index]; switch (dco_central_freq[min_dco_index]) { - case 9600000000: + case 9600000000ULL: wrpll_params->central_freq = 0; break; - case 9000000000: + case 9000000000ULL: wrpll_params->central_freq = 1; break; - case 8400000000: + case 8400000000ULL: wrpll_params->central_freq = 3; } -- 1.8.3.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915/skl: Fix big integer constant sparse warning 2014-11-14 14:20 [PATCH] drm/i915/skl: Fix big integer constant sparse warning Damien Lespiau @ 2014-11-14 16:27 ` Daniel Vetter 2014-11-14 23:54 ` [PATCH] drm/i915/skl: Fix big integer constant sparse shuang.he 1 sibling, 0 replies; 3+ messages in thread From: Daniel Vetter @ 2014-11-14 16:27 UTC (permalink / raw) To: Damien Lespiau; +Cc: intel-gfx On Fri, Nov 14, 2014 at 02:20:27PM +0000, Damien Lespiau wrote: > intel_ddi.c:955:41: sparse: constant 8400000000 is so big it is long > intel_ddi.c:955:53: sparse: constant 9000000000 is so big it is long > intel_ddi.c:955:65: sparse: constant 9600000000 is so big it is long > intel_ddi.c:1028:23: sparse: constant 9600000000 is so big it is long > intel_ddi.c:1031:23: sparse: constant 9000000000 is so big it is long > intel_ddi.c:1034:23: sparse: constant 8400000000 is so big it is long > Reported-by: 0-day tester missing here. Please try to acknowledge people who do good work besides writing/reviewing patches. > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915/skl: Fix big integer constant sparse 2014-11-14 14:20 [PATCH] drm/i915/skl: Fix big integer constant sparse warning Damien Lespiau 2014-11-14 16:27 ` Daniel Vetter @ 2014-11-14 23:54 ` shuang.he 1 sibling, 0 replies; 3+ messages in thread From: shuang.he @ 2014-11-14 23:54 UTC (permalink / raw) To: shuang.he, intel-gfx, damien.lespiau Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com) -------------------------------------Summary------------------------------------- Platform: baseline_drm_intel_nightly_pass_rate->patch_applied_pass_rate BYT: pass/total=290/291->290/291 PNV: pass/total=351/356->356/356 ILK: pass/total=371/372->371/372 IVB: pass/total=545/546->545/546 SNB: pass/total=424/425->424/425 HSW: pass/total=579/579->578/579 BDW: pass/total=434/435->434/435 -------------------------------------Detailed------------------------------------- test_platform: test_suite, test_case, result_with_drm_intel_nightly(count, machine_id...)...->result_with_patch_applied(count, machine_id)... PNV: Intel_gpu_tools, igt_gen3_mixed_blits, CRASH(1, M23) -> PASS(1, M25) PNV: Intel_gpu_tools, igt_gen3_render_linear_blits, CRASH(1, M23) -> PASS(1, M25) PNV: Intel_gpu_tools, igt_gen3_render_mixed_blits, CRASH(1, M23) -> PASS(1, M25) PNV: Intel_gpu_tools, igt_gen3_render_tiledx_blits, CRASH(2, M23)DMESG_WARN(1, M23)NRUN(1, M23) -> PASS(1, M25) PNV: Intel_gpu_tools, igt_gen3_render_tiledy_blits, CRASH(1, M23) -> PASS(1, M25) HSW: Intel_gpu_tools, igt_kms_flip_busy-flip, PASS(1, M20) -> DMESG_WARN(1, M40)PASS(3, M40) _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-14 23:55 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-11-14 14:20 [PATCH] drm/i915/skl: Fix big integer constant sparse warning Damien Lespiau 2014-11-14 16:27 ` Daniel Vetter 2014-11-14 23:54 ` [PATCH] drm/i915/skl: Fix big integer constant sparse shuang.he
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.