From: Keerthy <j-keerthy@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: rui.zhang@intel.com, edubezval@gmail.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, nm@ti.com, t-kristo@ti.com
Subject: Re: [PATCH v3 1/2] thermal: core: Allow orderly_poweroff to be called only once
Date: Mon, 8 May 2017 09:50:05 +0530 [thread overview]
Message-ID: <dbe1dfc1-9774-ca92-cded-42b691e36db7@ti.com> (raw)
In-Reply-To: <20170507210219.GB25628@atrey.karlin.mff.cuni.cz>
On Monday 08 May 2017 02:32 AM, Pavel Machek wrote:
>> thermal_zone_device_check --> thermal_zone_device_update -->
>> handle_thermal_trip --> handle_critical_trips --> orderly_poweroff
>>
>> The above sequence happens every 250/500 mS based on the configuration.
>> The orderly_poweroff function is getting called every 250/500 mS.
>> With a full fledged file system it takes at least 5-10 Seconds to
>> power off gracefully.
>>
>> In that period due to the thermal_zone_device_check triggering
>> periodically the thermal work queues bombard with
>> orderly_poweroff calls multiple times eventually leading to
>> failures in gracefully powering off the system.
>>
>> Make sure that orderly_poweroff is called only once.
>
> Pretty please, can we do it in the core code, not in thermal/? There
> are other reasons kernel may want to shut the system down, like for
> example critical battery, and if both thermal _and_ bad battery
> happen, we want just one shutdown...
Pavel,
Thermal fix is still valid. As it is having multiple calls.
I can work on fixing the core code as well.
BTW the latest of this series is v6:
https://patchwork.kernel.org/patch/9684929/
- Keerthy
>
>> Reported-by: Keerthy <j-keerthy@ti.com>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>
> And here probably we need your full name.
>
> Thanks,
> Pavel
>
WARNING: multiple messages have this Message-ID (diff)
From: Keerthy <j-keerthy@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: <rui.zhang@intel.com>, <edubezval@gmail.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>, <nm@ti.com>, <t-kristo@ti.com>
Subject: Re: [PATCH v3 1/2] thermal: core: Allow orderly_poweroff to be called only once
Date: Mon, 8 May 2017 09:50:05 +0530 [thread overview]
Message-ID: <dbe1dfc1-9774-ca92-cded-42b691e36db7@ti.com> (raw)
In-Reply-To: <20170507210219.GB25628@atrey.karlin.mff.cuni.cz>
On Monday 08 May 2017 02:32 AM, Pavel Machek wrote:
>> thermal_zone_device_check --> thermal_zone_device_update -->
>> handle_thermal_trip --> handle_critical_trips --> orderly_poweroff
>>
>> The above sequence happens every 250/500 mS based on the configuration.
>> The orderly_poweroff function is getting called every 250/500 mS.
>> With a full fledged file system it takes at least 5-10 Seconds to
>> power off gracefully.
>>
>> In that period due to the thermal_zone_device_check triggering
>> periodically the thermal work queues bombard with
>> orderly_poweroff calls multiple times eventually leading to
>> failures in gracefully powering off the system.
>>
>> Make sure that orderly_poweroff is called only once.
>
> Pretty please, can we do it in the core code, not in thermal/? There
> are other reasons kernel may want to shut the system down, like for
> example critical battery, and if both thermal _and_ bad battery
> happen, we want just one shutdown...
Pavel,
Thermal fix is still valid. As it is having multiple calls.
I can work on fixing the core code as well.
BTW the latest of this series is v6:
https://patchwork.kernel.org/patch/9684929/
- Keerthy
>
>> Reported-by: Keerthy <j-keerthy@ti.com>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>
> And here probably we need your full name.
>
> Thanks,
> Pavel
>
next prev parent reply other threads:[~2017-05-08 4:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 5:18 [PATCH v3 1/2] thermal: core: Allow orderly_poweroff to be called only once Keerthy
2017-04-14 5:18 ` Keerthy
2017-04-14 5:18 ` [PATCH v3 2/2] thermal: core: Add a back up thermal shutdown mechanism Keerthy
2017-04-14 5:18 ` Keerthy
2017-04-14 6:03 ` Eduardo Valentin
2017-04-14 6:00 ` [PATCH v3 1/2] thermal: core: Allow orderly_poweroff to be called only once Eduardo Valentin
2017-04-14 6:01 ` Keerthy
2017-04-14 6:01 ` Keerthy
2017-05-07 21:02 ` Pavel Machek
2017-05-08 4:20 ` Keerthy [this message]
2017-05-08 4:20 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbe1dfc1-9774-ca92-cded-42b691e36db7@ti.com \
--to=j-keerthy@ti.com \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rui.zhang@intel.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.