All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 01/17] icecc.bbclass: replace deprecated bash command substitution
@ 2022-02-07  1:08 Jose Quaresma
  2022-02-07  1:08 ` [PATCH 02/17] spirv-headers: bump to b42ba6 Jose Quaresma
                   ` (15 more replies)
  0 siblings, 16 replies; 26+ messages in thread
From: Jose Quaresma @ 2022-02-07  1:08 UTC (permalink / raw)
  To: openembedded-core; +Cc: Jose Quaresma

- build some packages with icecc enabled is not supported
  because of the folling that disables the icecc:

  DEBUG: while parsing set_icecc_env, unable to handle non-literal command '$ICECC_CC'

- it can be replicated with:

 bitbake make && bitbake make -c cleansstate && bitbake make -DD
 grep ICECC_CC tmp/log/cooker/qemux86-64/console-latest.log

- bash command substitution backquote deprecated

 https://www.gnu.org/software/bash/manual/html_node/Command-Substitution.html
 https://mywiki.wooledge.org/BashFAQ/082

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 meta/classes/icecc.bbclass | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
index 794e9930ad..3bbd2645af 100644
--- a/meta/classes/icecc.bbclass
+++ b/meta/classes/icecc.bbclass
@@ -309,7 +309,7 @@ wait_for_file() {
     local TIMEOUT=$2
     until [ -f "$FILE_TO_TEST" ]
     do
-        TIME_ELAPSED=`expr $TIME_ELAPSED + 1`
+        TIME_ELAPSED=$(expr $TIME_ELAPSED + 1)
         if [ $TIME_ELAPSED -gt $TIMEOUT ]
         then
             return 1
@@ -362,8 +362,8 @@ set_icecc_env() {
         return
     fi
 
-    ICE_VERSION=`$ICECC_CC -dumpversion`
-    ICECC_VERSION=`echo ${ICECC_VERSION} | sed -e "s/@VERSION@/$ICE_VERSION/g"`
+    ICE_VERSION="$($ICECC_CC -dumpversion)"
+    ICECC_VERSION=$(echo ${ICECC_VERSION} | sed -e "s/@VERSION@/$ICE_VERSION/g")
     if [ ! -x "${ICECC_ENV_EXEC}" ]
     then
         bbwarn "Cannot use icecc: invalid ICECC_ENV_EXEC"
@@ -390,18 +390,18 @@ set_icecc_env() {
         chmod 775 $ICE_PATH/$compiler
     done
 
-    ICECC_AS="`${ICECC_CC} -print-prog-name=as`"
+    ICECC_AS="$(${ICECC_CC} -print-prog-name=as)"
     # for target recipes should return something like:
     # /OE/tmp-eglibc/sysroots/x86_64-linux/usr/libexec/arm920tt-oe-linux-gnueabi/gcc/arm-oe-linux-gnueabi/4.8.2/as
     # and just "as" for native, if it returns "as" in current directory (for whatever reason) use "as" from PATH
-    if [ "`dirname "${ICECC_AS}"`" = "." ]
+    if [ "$(dirname "${ICECC_AS}")" = "." ]
     then
         ICECC_AS="${ICECC_WHICH_AS}"
     fi
 
     if [ ! -f "${ICECC_VERSION}.done" ]
     then
-        mkdir -p "`dirname "${ICECC_VERSION}"`"
+        mkdir -p "$(dirname "${ICECC_VERSION}")"
 
         # the ICECC_VERSION generation step must be locked by a mutex
         # in order to prevent race conditions
-- 
2.35.1



^ permalink raw reply related	[flat|nested] 26+ messages in thread
end of thread, other threads:[~2022-02-17  8:27 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-07  1:08 [PATCH 01/17] icecc.bbclass: replace deprecated bash command substitution Jose Quaresma
2022-02-07  1:08 ` [PATCH 02/17] spirv-headers: bump to b42ba6 Jose Quaresma
2022-02-07  1:08 ` [PATCH 03/17] spirv-tools: upgrade 2021.4 -> 2022.1 Jose Quaresma
2022-02-07  1:08 ` [PATCH 04/17] glslang: upgrade 11.7.1 -> 11.8.0 Jose Quaresma
2022-02-07  1:08 ` [PATCH 05/17] shaderc: upgrade 2021.3 -> 2021.4 Jose Quaresma
2022-02-07  1:08 ` [PATCH 06/17] shaderc: upgrade 2021.4 -> 2022.0 Jose Quaresma
2022-02-07  1:08 ` [PATCH 07/17] gstreamer1.0: upgrade 1.18.5 -> 1.20.0 Jose Quaresma
2022-02-08 22:01   ` [OE-core] " Alexander Kanavin
2022-02-09  9:15     ` Jose Quaresma
2022-02-09  9:30       ` Claudius Heine
2022-02-09 10:33         ` Alexander Kanavin
2022-02-16 23:40           ` Jose Quaresma
2022-02-17  8:27             ` Alexander Kanavin
2022-02-16 23:43         ` Jose Quaresma
2022-02-09 19:09   ` Peter Kjellerstedt
2022-02-16 23:36     ` Jose Quaresma
2022-02-07  1:08 ` [PATCH 08/17] gstreamer1.0-plugins-base: " Jose Quaresma
2022-02-07  1:08 ` [PATCH 09/17] gstreamer1.0-plugins-good: " Jose Quaresma
2022-02-07  1:08 ` [PATCH 10/17] gstreamer1.0-plugins-bad: " Jose Quaresma
2022-02-07  1:08 ` [PATCH 11/17] gstreamer1.0-plugins-ugly: " Jose Quaresma
2022-02-07  1:08 ` [PATCH 12/17] gstreamer1.0-rtsp-server: " Jose Quaresma
2022-02-07  1:08 ` [PATCH 13/17] gstreamer1.0-libav: " Jose Quaresma
2022-02-07  1:08 ` [PATCH 14/17] gstreamer1.0-vaapi: " Jose Quaresma
2022-02-07  1:08 ` [PATCH 15/17] gstreamer1.0-omx: " Jose Quaresma
2022-02-07  1:08 ` [PATCH 16/17] gstreamer1.0-python: " Jose Quaresma
2022-02-07  1:08 ` [PATCH 17/17] gst-devtools: " Jose Quaresma

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.