[poky][PATCH] signing-keys: add RDEPENDS to signing-keys from specific provider

[poky][PATCH] signing-keys: add RDEPENDS to signing-keys from specific provider

[fede.evol]

Specific provider (ie. RPM or IPK) does "provide" just itself as a
package to the system. This will cause the "-dev" package, which
refers to the generic signing-keys and not the provider specific,
to miss the dependency.

Error case (RPM) when populating sdk:

Error:
 Problem: conflicting requests
  - nothing provides signing-keys = 1.0-r0 needed by signing-keys-dev-1.0-r0.noarch
(try to add '--skip-broken' to skip uninstallable packages)

Examining signing-keys-rpm packages in PROVIDES we have indeed:
signing-keys-rpm = 1.0-r0

But in signing-keys-dev: in REQUIRES:
signing-keys-1.0-r0

This MR will fix the situation bringing the specific provider
PROVIDES to include also the generic package (RPM example):
signing-keys
signing-keys-rpm = 1.0-r0

Likely another way could be also to change the requirement for
dev or just allow empty packages as well.

Signed-off-by: Federico Pellegrin <fede@evolware.org>
---
 meta/recipes-core/meta/signing-keys.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-core/meta/signing-keys.bb b/meta/recipes-core/meta/signing-keys.bb
index 03463f95f56..d0602cf82af 100644
--- a/meta/recipes-core/meta/signing-keys.bb
+++ b/meta/recipes-core/meta/signing-keys.bb
@@ -18,6 +18,10 @@ FILES:${PN}-rpm = "${sysconfdir}/pki/rpm-gpg"
 FILES:${PN}-ipk = "${sysconfdir}/pki/ipk-gpg"
 FILES:${PN}-packagefeed = "${sysconfdir}/pki/packagefeed-gpg"
 
+RPROVIDES:${PN}-rpm += "${PN}"
+RPROVIDES:${PN}-ipk += "${PN}"
+RPROVIDES:${PN}-packagefeed += "${PN}"
+
 python do_get_public_keys () {
     from oe.gpg_sign import get_signer
 
-- 
2.35.3

Re: [poky][PATCH] signing-keys: add RDEPENDS to signing-keys from specific provider

[Peter Kjellerstedt]

> -----Original Message-----
> From: poky@lists.yoctoproject.org <poky@lists.yoctoproject.org> On Behalf
> Of Federico Pellegrin
> Sent: den 18 juni 2022 07:23
> To: poky@lists.yoctoproject.org
> Cc: Federico Pellegrin <fede@evolware.org>
> Subject: [poky][PATCH] signing-keys: add RDEPENDS to signing-keys from
> specific provider

Poky is made up of multiple repositories. Patches for meta should go to the 
openembedded-core@lists.openembedded.org mailing list (this is documented 
in README.md).

> 
> Specific provider (ie. RPM or IPK) does "provide" just itself as a
> package to the system. This will cause the "-dev" package, which
> refers to the generic signing-keys and not the provider specific,
> to miss the dependency.
> 
> Error case (RPM) when populating sdk:
> 
> Error:
>  Problem: conflicting requests
>   - nothing provides signing-keys = 1.0-r0 needed by signing-keys-dev-1.0-
> r0.noarch
> (try to add '--skip-broken' to skip uninstallable packages)
> 
> Examining signing-keys-rpm packages in PROVIDES we have indeed:
> signing-keys-rpm = 1.0-r0
> 
> But in signing-keys-dev: in REQUIRES:
> signing-keys-1.0-r0
> 
> This MR will fix the situation bringing the specific provider
> PROVIDES to include also the generic package (RPM example):
> signing-keys
> signing-keys-rpm = 1.0-r0
> 
> Likely another way could be also to change the requirement for
> dev or just allow empty packages as well.
> 
> Signed-off-by: Federico Pellegrin <fede@evolware.org>
> ---
>  meta/recipes-core/meta/signing-keys.bb | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/recipes-core/meta/signing-keys.bb b/meta/recipes-
> core/meta/signing-keys.bb
> index 03463f95f56..d0602cf82af 100644
> --- a/meta/recipes-core/meta/signing-keys.bb
> +++ b/meta/recipes-core/meta/signing-keys.bb
> @@ -18,6 +18,10 @@ FILES:${PN}-rpm = "${sysconfdir}/pki/rpm-gpg"
>  FILES:${PN}-ipk = "${sysconfdir}/pki/ipk-gpg"
>  FILES:${PN}-packagefeed = "${sysconfdir}/pki/packagefeed-gpg"
> 
> +RPROVIDES:${PN}-rpm += "${PN}"
> +RPROVIDES:${PN}-ipk += "${PN}"
> +RPROVIDES:${PN}-packagefeed += "${PN}"

This is incorrect. The correct thing to do is to instead remove the 
dependency from ${PN}-dev on ${PN}, i.e.:

RDEPENDS:${PN}-dev = ""

> +
>  python do_get_public_keys () {
>      from oe.gpg_sign import get_signer
> 
> --
> 2.35.3

//Peter

Re: [poky][PATCH] signing-keys: add RDEPENDS to signing-keys from specific provider

[Federico Pellegrin]

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

Hi Peter,
Many thanks for your feedback!

Il giorno dom 19 giu 2022 alle ore 15:06 Peter Kjellerstedt <
peter.kjellerstedt@axis.com> ha scritto:

> > +RPROVIDES:${PN}-rpm += "${PN}"
> > +RPROVIDES:${PN}-ipk += "${PN}"
> > +RPROVIDES:${PN}-packagefeed += "${PN}"
>
> This is incorrect. The correct thing to do is to instead remove the
> dependency from ${PN}-dev on ${PN}, i.e.:
>
> RDEPENDS:${PN}-dev = ""
>
>
Thanks for the correction. Indeed as per commit comment I was a bit unsure
which way would be correct (or better).

I'll send now (hopefully to the right address!) a v2 of the patch. I've
tried your better solution locally and works of course very fine.

Thanks again and a v2 in a few moments,

Cheers,
Federico

[-- Attachment #2: Type: text/html, Size: 1280 bytes --]

[poky][PATCH] signing-keys: add RDEPENDS to signing-keys from specific provider

[Federico Pellegrin]

Specific provider (ie. RPM or IPK) does "provide" just itself as a
package to the system. This will cause the "-dev" package, which
refers to the generic signing-keys and not the provider specific,
to miss the dependency.

Error case (RPM) when populating sdk:

Error:
 Problem: conflicting requests
  - nothing provides signing-keys = 1.0-r0 needed by signing-keys-dev-1.0-r0.noarch
(try to add '--skip-broken' to skip uninstallable packages)

Examining signing-keys-rpm packages in PROVIDES we have indeed:
signing-keys-rpm = 1.0-r0

But in signing-keys-dev: in REQUIRES:
signing-keys-1.0-r0

This MR will fix the situation bringing the specific provider
PROVIDES to include also the generic package (RPM example):
signing-keys
signing-keys-rpm = 1.0-r0

Likely another way could be also to change the requirement for
dev or just allow empty packages as well.

Signed-off-by: Federico Pellegrin <fede@evolware.org>
---
 meta/recipes-core/meta/signing-keys.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-core/meta/signing-keys.bb b/meta/recipes-core/meta/signing-keys.bb
index 03463f95f56..d0602cf82af 100644
--- a/meta/recipes-core/meta/signing-keys.bb
+++ b/meta/recipes-core/meta/signing-keys.bb
@@ -18,6 +18,10 @@ FILES:${PN}-rpm = "${sysconfdir}/pki/rpm-gpg"
 FILES:${PN}-ipk = "${sysconfdir}/pki/ipk-gpg"
 FILES:${PN}-packagefeed = "${sysconfdir}/pki/packagefeed-gpg"
 
+RPROVIDES:${PN}-rpm += "${PN}"
+RPROVIDES:${PN}-ipk += "${PN}"
+RPROVIDES:${PN}-packagefeed += "${PN}"
+
 python do_get_public_keys () {
     from oe.gpg_sign import get_signer
 
-- 
2.35.3