All of lore.kernel.org
 help / color / mirror / Atom feed
From: aaron.ma@canonical.com (Aaron Ma)
Subject: [PATCH] nvme: determine the number of IO queues
Date: Thu, 18 Apr 2019 22:21:03 +0800	[thread overview]
Message-ID: <ddabda2a-b30d-77cc-7b2e-05a6b599cae7@canonical.com> (raw)
In-Reply-To: <20190418134820.GA7589@localhost.localdomain>



On 4/18/19 9:48 PM, Keith Busch wrote:
> It does change the default behavior. If I have a degraded controller that
> can't do IO in a machine with 1000's of CPUs, I have to iterate this
> non-standard behavior 1000's of times before the drive is servicable
> again. We currenlty figure that out in just a single try.
> 
> At least the quirks document *why* the driver is doing non-standard
> behavior. We do the IO queue quirks for Macbooks, for example.
> 
> But why don't you file a bug report with the device vendor instead? Surely
> a firmware fix provides the best possible outcome, and would make this
> device work not only in all versions of Linux, but also every standard
> compliant driver for any OS.

I will do it, no v2 for now.

Thanks,
Aaron

WARNING: multiple messages have this Message-ID (diff)
From: Aaron Ma <aaron.ma@canonical.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Maxim Levitsky <mlevitsk@redhat.com>,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	keith.busch@intel.com, axboe@fb.com
Subject: Re: [PATCH] nvme: determine the number of IO queues
Date: Thu, 18 Apr 2019 22:21:03 +0800	[thread overview]
Message-ID: <ddabda2a-b30d-77cc-7b2e-05a6b599cae7@canonical.com> (raw)
In-Reply-To: <20190418134820.GA7589@localhost.localdomain>



On 4/18/19 9:48 PM, Keith Busch wrote:
> It does change the default behavior. If I have a degraded controller that
> can't do IO in a machine with 1000's of CPUs, I have to iterate this
> non-standard behavior 1000's of times before the drive is servicable
> again. We currenlty figure that out in just a single try.
> 
> At least the quirks document *why* the driver is doing non-standard
> behavior. We do the IO queue quirks for Macbooks, for example.
> 
> But why don't you file a bug report with the device vendor instead? Surely
> a firmware fix provides the best possible outcome, and would make this
> device work not only in all versions of Linux, but also every standard
> compliant driver for any OS.

I will do it, no v2 for now.

Thanks,
Aaron

  reply	other threads:[~2019-04-18 14:21 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 14:12 [PATCH] nvme: determine the number of IO queues Aaron Ma
2019-04-17 14:12 ` Aaron Ma
2019-04-17 17:32 ` Maxim Levitsky
2019-04-17 17:32   ` Maxim Levitsky
2019-04-17 17:33   ` Maxim Levitsky
2019-04-17 17:33     ` Maxim Levitsky
2019-04-18  6:21     ` Aaron Ma
2019-04-18  6:21       ` Aaron Ma
2019-04-18  7:25       ` Maxim Levitsky
2019-04-18  7:25         ` Maxim Levitsky
2019-04-18 12:13       ` Minwoo Im
2019-04-18 12:13         ` Minwoo Im
2019-04-18 12:52         ` Aaron Ma
2019-04-18 12:52           ` Aaron Ma
2019-04-18 13:33           ` Minwoo Im
2019-04-18 13:33             ` Minwoo Im
2019-04-18 13:38             ` Aaron Ma
2019-04-18 13:38               ` Aaron Ma
2019-04-18 13:58               ` Minwoo Im
2019-04-18 13:58                 ` Minwoo Im
2019-04-18 13:48       ` Keith Busch
2019-04-18 13:48         ` Keith Busch
2019-04-18 14:21         ` Aaron Ma [this message]
2019-04-18 14:21           ` Aaron Ma
2019-04-25 14:39           ` Christoph Hellwig
2019-04-25 14:39             ` Christoph Hellwig
2019-04-26  5:27             ` Aaron Ma
2019-04-26  5:27               ` Aaron Ma
2019-04-17 21:30 ` Edmund Nadolski (Microsoft)
2019-04-17 21:30   ` Edmund Nadolski (Microsoft)
2019-04-18  6:24   ` Aaron Ma
2019-04-18  6:24     ` Aaron Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddabda2a-b30d-77cc-7b2e-05a6b599cae7@canonical.com \
    --to=aaron.ma@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.