* [PATCH] drivers: altera_edac: Guard SDRAM irq2 retrieval for Arria10 only @ 2026-05-08 7:52 muhammad.nazim.amirul.nazle.asmade 2026-05-11 11:54 ` Dinh Nguyen 0 siblings, 1 reply; 7+ messages in thread From: muhammad.nazim.amirul.nazle.asmade @ 2026-05-08 7:52 UTC (permalink / raw) To: dinguyen, bp, tony.luck; +Cc: linux-edac, linux-arm-kernel, linux-kernel From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com> Guard the irq2 retrieval with an of_machine_is_compatible() check so that platform_get_irq(pdev, 1) is only called on Arria10 platforms. Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com> Signed-off-by: Niravkumar L Rabara <nirav.rabara@altera.com> --- drivers/edac/altera_edac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 4edd2088c2db..b30302198cd4 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -348,7 +348,8 @@ static int altr_sdram_probe(struct platform_device *pdev) } /* Arria10 has a 2nd IRQ */ - irq2 = platform_get_irq(pdev, 1); + if (of_machine_is_compatible("altr,socfpga-arria10")) + irq2 = platform_get_irq(pdev, 1); layers[0].type = EDAC_MC_LAYER_CHIP_SELECT; layers[0].size = 1; -- 2.43.7 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: altera_edac: Guard SDRAM irq2 retrieval for Arria10 only 2026-05-08 7:52 [PATCH] drivers: altera_edac: Guard SDRAM irq2 retrieval for Arria10 only muhammad.nazim.amirul.nazle.asmade @ 2026-05-11 11:54 ` Dinh Nguyen 2026-05-12 1:37 ` Nazle Asmade, Muhammad Nazim Amirul 0 siblings, 1 reply; 7+ messages in thread From: Dinh Nguyen @ 2026-05-11 11:54 UTC (permalink / raw) To: muhammad.nazim.amirul.nazle.asmade, bp, tony.luck Cc: linux-edac, linux-arm-kernel, linux-kernel On 5/8/26 02:52, muhammad.nazim.amirul.nazle.asmade@altera.com wrote: > From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com> > > Guard the irq2 retrieval with an of_machine_is_compatible() check so > that platform_get_irq(pdev, 1) is only called on Arria10 platforms. > > Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com> > Signed-off-by: Niravkumar L Rabara <nirav.rabara@altera.com> > --- > drivers/edac/altera_edac.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c > index 4edd2088c2db..b30302198cd4 100644 > --- a/drivers/edac/altera_edac.c > +++ b/drivers/edac/altera_edac.c > @@ -348,7 +348,8 @@ static int altr_sdram_probe(struct platform_device *pdev) > } > > /* Arria10 has a 2nd IRQ */ > - irq2 = platform_get_irq(pdev, 1); > + if (of_machine_is_compatible("altr,socfpga-arria10")) > + irq2 = platform_get_irq(pdev, 1); > > layers[0].type = EDAC_MC_LAYER_CHIP_SELECT; > layers[0].size = 1; Why? We already switch on arria10 later in the same function. Sorry, but NAK. Dinh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: altera_edac: Guard SDRAM irq2 retrieval for Arria10 only 2026-05-11 11:54 ` Dinh Nguyen @ 2026-05-12 1:37 ` Nazle Asmade, Muhammad Nazim Amirul 2026-05-12 11:25 ` Dinh Nguyen 0 siblings, 1 reply; 7+ messages in thread From: Nazle Asmade, Muhammad Nazim Amirul @ 2026-05-12 1:37 UTC (permalink / raw) To: Dinh Nguyen, bp@alien8.de, tony.luck@intel.com Cc: linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On 11/5/2026 7:54 pm, Dinh Nguyen wrote: > > > On 5/8/26 02:52, muhammad.nazim.amirul.nazle.asmade@altera.com wrote: >> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com> >> >> Guard the irq2 retrieval with an of_machine_is_compatible() check so >> that platform_get_irq(pdev, 1) is only called on Arria10 platforms. >> >> Signed-off-by: Nazim Amirul >> <muhammad.nazim.amirul.nazle.asmade@altera.com> >> Signed-off-by: Niravkumar L Rabara <nirav.rabara@altera.com> >> --- >> drivers/edac/altera_edac.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c >> index 4edd2088c2db..b30302198cd4 100644 >> --- a/drivers/edac/altera_edac.c >> +++ b/drivers/edac/altera_edac.c >> @@ -348,7 +348,8 @@ static int altr_sdram_probe(struct platform_device >> *pdev) >> } >> /* Arria10 has a 2nd IRQ */ >> - irq2 = platform_get_irq(pdev, 1); >> + if (of_machine_is_compatible("altr,socfpga-arria10")) >> + irq2 = platform_get_irq(pdev, 1); >> layers[0].type = EDAC_MC_LAYER_CHIP_SELECT; >> layers[0].size = 1; > > Why? We already switch on arria10 later in the same function. > > Sorry, but NAK. > > Dinh This driver were used by cyclone5 and arria10. Cyclone5 only has one interrupt whereby arria10 has 2 interrupt. That is the reason why the interrupt was guard by (of_machine_is_compatible("altr,socfpga-arria10")) Nazim ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: altera_edac: Guard SDRAM irq2 retrieval for Arria10 only 2026-05-12 1:37 ` Nazle Asmade, Muhammad Nazim Amirul @ 2026-05-12 11:25 ` Dinh Nguyen 2026-05-12 11:51 ` Nazle Asmade, Muhammad Nazim Amirul 0 siblings, 1 reply; 7+ messages in thread From: Dinh Nguyen @ 2026-05-12 11:25 UTC (permalink / raw) To: Nazle Asmade, Muhammad Nazim Amirul, bp@alien8.de, tony.luck@intel.com Cc: linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On 5/11/26 20:37, Nazle Asmade, Muhammad Nazim Amirul wrote: > On 11/5/2026 7:54 pm, Dinh Nguyen wrote: >> >> >> On 5/8/26 02:52, muhammad.nazim.amirul.nazle.asmade@altera.com wrote: >>> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com> >>> >>> Guard the irq2 retrieval with an of_machine_is_compatible() check so >>> that platform_get_irq(pdev, 1) is only called on Arria10 platforms. >>> >>> Signed-off-by: Nazim Amirul >>> <muhammad.nazim.amirul.nazle.asmade@altera.com> >>> Signed-off-by: Niravkumar L Rabara <nirav.rabara@altera.com> >>> --- >>> drivers/edac/altera_edac.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c >>> index 4edd2088c2db..b30302198cd4 100644 >>> --- a/drivers/edac/altera_edac.c >>> +++ b/drivers/edac/altera_edac.c >>> @@ -348,7 +348,8 @@ static int altr_sdram_probe(struct platform_device >>> *pdev) >>> } >>> /* Arria10 has a 2nd IRQ */ >>> - irq2 = platform_get_irq(pdev, 1); >>> + if (of_machine_is_compatible("altr,socfpga-arria10")) >>> + irq2 = platform_get_irq(pdev, 1); >>> layers[0].type = EDAC_MC_LAYER_CHIP_SELECT; >>> layers[0].size = 1; >> >> Why? We already switch on arria10 later in the same function. >> >> Sorry, but NAK. >> >> Dinh > This driver were used by cyclone5 and arria10. Cyclone5 only has one > interrupt whereby arria10 has 2 interrupt. That is the reason why the > interrupt was guard by (of_machine_is_compatible("altr,socfpga-arria10")) > Yes, but look at line 397, /* Only the Arria10 has separate IRQs */ if (of_machine_is_compatible("altr,socfpga-arria10")) { /* Arria10 specific initialization */ Dinh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: altera_edac: Guard SDRAM irq2 retrieval for Arria10 only 2026-05-12 11:25 ` Dinh Nguyen @ 2026-05-12 11:51 ` Nazle Asmade, Muhammad Nazim Amirul 2026-05-13 10:45 ` Dinh Nguyen 0 siblings, 1 reply; 7+ messages in thread From: Nazle Asmade, Muhammad Nazim Amirul @ 2026-05-12 11:51 UTC (permalink / raw) To: Dinh Nguyen, bp@alien8.de, tony.luck@intel.com Cc: linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On 12/5/2026 7:25 pm, Dinh Nguyen wrote: > > > On 5/11/26 20:37, Nazle Asmade, Muhammad Nazim Amirul wrote: >> On 11/5/2026 7:54 pm, Dinh Nguyen wrote: >>> >>> >>> On 5/8/26 02:52, muhammad.nazim.amirul.nazle.asmade@altera.com wrote: >>>> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com> >>>> >>>> Guard the irq2 retrieval with an of_machine_is_compatible() check so >>>> that platform_get_irq(pdev, 1) is only called on Arria10 platforms. >>>> >>>> Signed-off-by: Nazim Amirul >>>> <muhammad.nazim.amirul.nazle.asmade@altera.com> >>>> Signed-off-by: Niravkumar L Rabara <nirav.rabara@altera.com> >>>> --- >>>> drivers/edac/altera_edac.c | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c >>>> index 4edd2088c2db..b30302198cd4 100644 >>>> --- a/drivers/edac/altera_edac.c >>>> +++ b/drivers/edac/altera_edac.c >>>> @@ -348,7 +348,8 @@ static int altr_sdram_probe(struct platform_device >>>> *pdev) >>>> } >>>> /* Arria10 has a 2nd IRQ */ >>>> - irq2 = platform_get_irq(pdev, 1); >>>> + if (of_machine_is_compatible("altr,socfpga-arria10")) >>>> + irq2 = platform_get_irq(pdev, 1); >>>> layers[0].type = EDAC_MC_LAYER_CHIP_SELECT; >>>> layers[0].size = 1; >>> >>> Why? We already switch on arria10 later in the same function. >>> >>> Sorry, but NAK. >>> >>> Dinh >> This driver were used by cyclone5 and arria10. Cyclone5 only has one >> interrupt whereby arria10 has 2 interrupt. That is the reason why the >> interrupt was guard by (of_machine_is_compatible("altr,socfpga-arria10")) >> > > Yes, but look at line 397, > > /* Only the Arria10 has separate IRQs */ > if (of_machine_is_compatible("altr,socfpga-arria10")) { > /* Arria10 specific initialization */ > > Dinh > > Hi Dinh, That is true, but the one that we looking at now is at line 352 which enabling the second interrupt and it is not required by cyclone5. Perhaps are you saying we should move the irq2 at line 352 under this line 397? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: altera_edac: Guard SDRAM irq2 retrieval for Arria10 only 2026-05-12 11:51 ` Nazle Asmade, Muhammad Nazim Amirul @ 2026-05-13 10:45 ` Dinh Nguyen 2026-05-14 3:42 ` Nazle Asmade, Muhammad Nazim Amirul 0 siblings, 1 reply; 7+ messages in thread From: Dinh Nguyen @ 2026-05-13 10:45 UTC (permalink / raw) To: Nazle Asmade, Muhammad Nazim Amirul, bp@alien8.de, tony.luck@intel.com Cc: linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On 5/12/26 06:51, Nazle Asmade, Muhammad Nazim Amirul wrote: > On 12/5/2026 7:25 pm, Dinh Nguyen wrote: >> >> >> On 5/11/26 20:37, Nazle Asmade, Muhammad Nazim Amirul wrote: >>> On 11/5/2026 7:54 pm, Dinh Nguyen wrote: >>>> >>>> >>>> On 5/8/26 02:52, muhammad.nazim.amirul.nazle.asmade@altera.com wrote: >>>>> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com> >>>>> >>>>> Guard the irq2 retrieval with an of_machine_is_compatible() check so >>>>> that platform_get_irq(pdev, 1) is only called on Arria10 platforms. >>>>> >>>>> Signed-off-by: Nazim Amirul >>>>> <muhammad.nazim.amirul.nazle.asmade@altera.com> >>>>> Signed-off-by: Niravkumar L Rabara <nirav.rabara@altera.com> >>>>> --- >>>>> drivers/edac/altera_edac.c | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c >>>>> index 4edd2088c2db..b30302198cd4 100644 >>>>> --- a/drivers/edac/altera_edac.c >>>>> +++ b/drivers/edac/altera_edac.c >>>>> @@ -348,7 +348,8 @@ static int altr_sdram_probe(struct platform_device >>>>> *pdev) >>>>> } >>>>> /* Arria10 has a 2nd IRQ */ >>>>> - irq2 = platform_get_irq(pdev, 1); >>>>> + if (of_machine_is_compatible("altr,socfpga-arria10")) >>>>> + irq2 = platform_get_irq(pdev, 1); >>>>> layers[0].type = EDAC_MC_LAYER_CHIP_SELECT; >>>>> layers[0].size = 1; >>>> >>>> Why? We already switch on arria10 later in the same function. >>>> >>>> Sorry, but NAK. >>>> >>>> Dinh >>> This driver were used by cyclone5 and arria10. Cyclone5 only has one >>> interrupt whereby arria10 has 2 interrupt. That is the reason why the >>> interrupt was guard by (of_machine_is_compatible("altr,socfpga-arria10")) >>> >> >> Yes, but look at line 397, >> >> /* Only the Arria10 has separate IRQs */ >> if (of_machine_is_compatible("altr,socfpga-arria10")) { >> /* Arria10 specific initialization */ >> >> Dinh >> >> > Hi Dinh, That is true, but the one that we looking at now is at line 352 > which enabling the second interrupt and it is not required by cyclone5. > Perhaps are you saying we should move the irq2 at line 352 under this > line 397? Yes, that would be fine. Dinh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: altera_edac: Guard SDRAM irq2 retrieval for Arria10 only 2026-05-13 10:45 ` Dinh Nguyen @ 2026-05-14 3:42 ` Nazle Asmade, Muhammad Nazim Amirul 0 siblings, 0 replies; 7+ messages in thread From: Nazle Asmade, Muhammad Nazim Amirul @ 2026-05-14 3:42 UTC (permalink / raw) To: Dinh Nguyen, bp@alien8.de, tony.luck@intel.com Cc: linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On 13/5/2026 6:45 pm, Dinh Nguyen wrote: > > > On 5/12/26 06:51, Nazle Asmade, Muhammad Nazim Amirul wrote: >> On 12/5/2026 7:25 pm, Dinh Nguyen wrote: >>> >>> >>> On 5/11/26 20:37, Nazle Asmade, Muhammad Nazim Amirul wrote: >>>> On 11/5/2026 7:54 pm, Dinh Nguyen wrote: >>>>> >>>>> >>>>> On 5/8/26 02:52, muhammad.nazim.amirul.nazle.asmade@altera.com wrote: >>>>>> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com> >>>>>> >>>>>> Guard the irq2 retrieval with an of_machine_is_compatible() check so >>>>>> that platform_get_irq(pdev, 1) is only called on Arria10 platforms. >>>>>> >>>>>> Signed-off-by: Nazim Amirul >>>>>> <muhammad.nazim.amirul.nazle.asmade@altera.com> >>>>>> Signed-off-by: Niravkumar L Rabara <nirav.rabara@altera.com> >>>>>> --- >>>>>> drivers/edac/altera_edac.c | 3 ++- >>>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c >>>>>> index 4edd2088c2db..b30302198cd4 100644 >>>>>> --- a/drivers/edac/altera_edac.c >>>>>> +++ b/drivers/edac/altera_edac.c >>>>>> @@ -348,7 +348,8 @@ static int altr_sdram_probe(struct >>>>>> platform_device >>>>>> *pdev) >>>>>> } >>>>>> /* Arria10 has a 2nd IRQ */ >>>>>> - irq2 = platform_get_irq(pdev, 1); >>>>>> + if (of_machine_is_compatible("altr,socfpga-arria10")) >>>>>> + irq2 = platform_get_irq(pdev, 1); >>>>>> layers[0].type = EDAC_MC_LAYER_CHIP_SELECT; >>>>>> layers[0].size = 1; >>>>> >>>>> Why? We already switch on arria10 later in the same function. >>>>> >>>>> Sorry, but NAK. >>>>> >>>>> Dinh >>>> This driver were used by cyclone5 and arria10. Cyclone5 only has one >>>> interrupt whereby arria10 has 2 interrupt. That is the reason why the >>>> interrupt was guard by (of_machine_is_compatible("altr,socfpga- >>>> arria10")) >>>> >>> >>> Yes, but look at line 397, >>> >>> /* Only the Arria10 has separate IRQs */ >>> if (of_machine_is_compatible("altr,socfpga-arria10")) { >>> /* Arria10 specific initialization */ >>> >>> Dinh >>> >>> >> Hi Dinh, That is true, but the one that we looking at now is at line 352 >> which enabling the second interrupt and it is not required by cyclone5. >> Perhaps are you saying we should move the irq2 at line 352 under this >> line 397? > > Yes, that would be fine. > > Dinh > changes applied on v2! https://lore.kernel.org/all/20260514034007.11541-1-muhammad.nazim.amirul.nazle.asmade@altera.com/ regards, Nazim ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-05-14 3:42 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-05-08 7:52 [PATCH] drivers: altera_edac: Guard SDRAM irq2 retrieval for Arria10 only muhammad.nazim.amirul.nazle.asmade 2026-05-11 11:54 ` Dinh Nguyen 2026-05-12 1:37 ` Nazle Asmade, Muhammad Nazim Amirul 2026-05-12 11:25 ` Dinh Nguyen 2026-05-12 11:51 ` Nazle Asmade, Muhammad Nazim Amirul 2026-05-13 10:45 ` Dinh Nguyen 2026-05-14 3:42 ` Nazle Asmade, Muhammad Nazim Amirul
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.