[PATCH] drm/amdgpu: fix a build warning by a typo in amdgpu_gfx.c

[PATCH] drm/amdgpu: fix a build warning by a typo in amdgpu_gfx.c

[Guchun Chen]

This should be a typo when intruducing multi-xx support.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Cc: Le Ma <le.ma@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
index 60bb4bba1994..2cf1f88fde48 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
@@ -470,8 +470,8 @@ void amdgpu_gfx_mqd_sw_fini(struct amdgpu_device *adev, int xcc_id)
 
 	for (i = 0; i < adev->gfx.num_compute_rings; i++) {
 		j = i + xcc_id * adev->gfx.num_compute_rings;
-		ring = &adev->gfx.compute_ring[i];
-		kfree(adev->gfx.mec.mqd_backup[i]);
+		ring = &adev->gfx.compute_ring[j];
+		kfree(adev->gfx.mec.mqd_backup[j]);
 		amdgpu_bo_free_kernel(&ring->mqd_obj,
 				      &ring->mqd_gpu_addr,
 				      &ring->mqd_ptr);
-- 
2.25.1

RE: [PATCH] drm/amdgpu: fix a build warning by a typo in amdgpu_gfx.c

[Ma, Le]

[AMD Official Use Only - General]

Reviewed-by: Le Ma <le.ma@amd.com>

> -----Original Message-----
> From: Chen, Guchun <Guchun.Chen@amd.com>
> Sent: Wednesday, April 26, 2023 11:12 AM
> To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>;
> Ma, Le <Le.Ma@amd.com>
> Cc: Chen, Guchun <Guchun.Chen@amd.com>; kernel test robot <lkp@intel.com>
> Subject: [PATCH] drm/amdgpu: fix a build warning by a typo in amdgpu_gfx.c
>
> This should be a typo when intruducing multi-xx support.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
> Cc: Le Ma <le.ma@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index 60bb4bba1994..2cf1f88fde48 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -470,8 +470,8 @@ void amdgpu_gfx_mqd_sw_fini(struct amdgpu_device
> *adev, int xcc_id)
>
>       for (i = 0; i < adev->gfx.num_compute_rings; i++) {
>               j = i + xcc_id * adev->gfx.num_compute_rings;
> -             ring = &adev->gfx.compute_ring[i];
> -             kfree(adev->gfx.mec.mqd_backup[i]);
> +             ring = &adev->gfx.compute_ring[j];
> +             kfree(adev->gfx.mec.mqd_backup[j]);
>               amdgpu_bo_free_kernel(&ring->mqd_obj,
>                                     &ring->mqd_gpu_addr,
>                                     &ring->mqd_ptr);
> --
> 2.25.1

Re: [PATCH] drm/amdgpu: fix a build warning by a typo in amdgpu_gfx.c

[Christian König]

Am 26.04.23 um 05:11 schrieb Guchun Chen:
> This should be a typo when intruducing multi-xx support.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
> Cc: Le Ma <le.ma@amd.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index 60bb4bba1994..2cf1f88fde48 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -470,8 +470,8 @@ void amdgpu_gfx_mqd_sw_fini(struct amdgpu_device *adev, int xcc_id)
>   
>   	for (i = 0; i < adev->gfx.num_compute_rings; i++) {
>   		j = i + xcc_id * adev->gfx.num_compute_rings;
> -		ring = &adev->gfx.compute_ring[i];
> -		kfree(adev->gfx.mec.mqd_backup[i]);
> +		ring = &adev->gfx.compute_ring[j];
> +		kfree(adev->gfx.mec.mqd_backup[j]);
>   		amdgpu_bo_free_kernel(&ring->mqd_obj,
>   				      &ring->mqd_gpu_addr,
>   				      &ring->mqd_ptr);