From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next 3/4] net: phy: Add helper to derive the number of ports from a phy mode
Date: Thu, 28 Jul 2022 14:44:47 -0700 [thread overview]
Message-ID: <df39cfc9-6fd8-e277-870b-67059dcebb2b@gmail.com> (raw)
In-Reply-To: <YuMAdACnRKsL8/xD@lunn.ch>
On 7/28/22 14:32, Andrew Lunn wrote:
>> +int phy_interface_num_ports(phy_interface_t interface)
>> +{
>> + switch (interface) {
>> + case PHY_INTERFACE_MODE_NA:
>> + case PHY_INTERFACE_MODE_INTERNAL:
>> + return 0;
>
> I've not yet looked at how this is used. Returning 0 could have
> interesting effects i guess? INTERNAL clearly does have some sort of
> path between the MAC and the PHY, so i think 1 would be a better
> value. NA is less clear, it generally means Don't touch. But again,
> there still needs to be a path between the MAC and PHY, otherwise
> there would not be any to touch.
>
> Why did you pick 0?
I would agree that returning 1 is a more sensible default to avoid breaking users of that function. However this makes me wonder, in what case will we break the following common meaning:
- Q -> quad
- P -> penta
- O -> octal
Is the helper really needed in the sense that the phy_interface_t enumeration is explicit enough thanks to or because of its name?
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next 3/4] net: phy: Add helper to derive the number of ports from a phy mode
Date: Thu, 28 Jul 2022 14:44:47 -0700 [thread overview]
Message-ID: <df39cfc9-6fd8-e277-870b-67059dcebb2b@gmail.com> (raw)
In-Reply-To: <YuMAdACnRKsL8/xD@lunn.ch>
On 7/28/22 14:32, Andrew Lunn wrote:
>> +int phy_interface_num_ports(phy_interface_t interface)
>> +{
>> + switch (interface) {
>> + case PHY_INTERFACE_MODE_NA:
>> + case PHY_INTERFACE_MODE_INTERNAL:
>> + return 0;
>
> I've not yet looked at how this is used. Returning 0 could have
> interesting effects i guess? INTERNAL clearly does have some sort of
> path between the MAC and the PHY, so i think 1 would be a better
> value. NA is less clear, it generally means Don't touch. But again,
> there still needs to be a path between the MAC and PHY, otherwise
> there would not be any to touch.
>
> Why did you pick 0?
I would agree that returning 1 is a more sensible default to avoid breaking users of that function. However this makes me wonder, in what case will we break the following common meaning:
- Q -> quad
- P -> penta
- O -> octal
Is the helper really needed in the sense that the phy_interface_t enumeration is explicit enough thanks to or because of its name?
--
Florian
next prev parent reply other threads:[~2022-07-28 21:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 14:52 [PATCH net-next 0/4] net: Introduce QUSGMII phy mode Maxime Chevallier
2022-07-28 14:52 ` Maxime Chevallier
2022-07-28 14:52 ` [PATCH net-next 1/4] net: phy: Introduce QUSGMII PHY mode Maxime Chevallier
2022-07-28 14:52 ` Maxime Chevallier
2022-07-28 21:23 ` Andrew Lunn
2022-07-28 21:23 ` Andrew Lunn
2022-07-28 14:52 ` [PATCH net-next 2/4] dt-bindings: net: ethernet-controller: add QUSGMII mode Maxime Chevallier
2022-07-28 14:52 ` Maxime Chevallier
2022-07-28 14:52 ` [PATCH net-next 3/4] net: phy: Add helper to derive the number of ports from a phy mode Maxime Chevallier
2022-07-28 14:52 ` Maxime Chevallier
2022-07-28 21:32 ` Andrew Lunn
2022-07-28 21:32 ` Andrew Lunn
2022-07-28 21:44 ` Florian Fainelli [this message]
2022-07-28 21:44 ` Florian Fainelli
2022-07-29 6:50 ` Maxime Chevallier
2022-07-29 6:50 ` Maxime Chevallier
2022-07-29 7:32 ` Maxime Chevallier
2022-07-29 7:32 ` Maxime Chevallier
2022-07-29 13:00 ` Andrew Lunn
2022-07-29 13:00 ` Andrew Lunn
2022-07-28 14:52 ` [PATCH net-next 4/4] net: lan966x: Add QUSGMII support for lan966x Maxime Chevallier
2022-07-28 14:52 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df39cfc9-6fd8-e277-870b-67059dcebb2b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Allan.Nielsen@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.