From: Dave Hansen <dave.hansen@intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc: stable@vger.kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Yi Zhang <yi.zhang@redhat.com>,
linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org,
willy@infradead.org
Subject: Re: [PATCH] x86/mm: Fix leak of pmd ptlock
Date: Tue, 5 Jan 2021 07:40:16 -0800 [thread overview]
Message-ID: <df5209ad-e527-92ce-52a2-33e1aa9deaff@intel.com> (raw)
In-Reply-To: <160697689204.605323.17629854984697045602.stgit@dwillia2-desk3.amr.corp.intel.com>
On 12/2/20 10:28 PM, Dan Williams wrote:
> Commit 28ee90fe6048 ("x86/mm: implement free pmd/pte page interfaces")
> introduced a new location where a pmd was released, but neglected to run
> the pmd page destructor. In fact, this happened previously for a
> different pmd release path and was fixed by commit:
>
> c283610e44ec ("x86, mm: do not leak page->ptl for pmd page tables").
>
> This issue was hidden until recently because the failure mode is silent,
> but commit:
Looks sane. Thanks as always for the thorough changelog and the
investigation into why we're suddenly seeing this now.
I agree that ridding ourselves of open-coded free_page()'s is a good
idea, but this patch itself needs to be around for stable anyway. So,
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc: stable@vger.kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Yi Zhang <yi.zhang@redhat.com>,
linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org,
willy@infradead.org
Subject: Re: [PATCH] x86/mm: Fix leak of pmd ptlock
Date: Tue, 5 Jan 2021 07:40:16 -0800 [thread overview]
Message-ID: <df5209ad-e527-92ce-52a2-33e1aa9deaff@intel.com> (raw)
In-Reply-To: <160697689204.605323.17629854984697045602.stgit@dwillia2-desk3.amr.corp.intel.com>
On 12/2/20 10:28 PM, Dan Williams wrote:
> Commit 28ee90fe6048 ("x86/mm: implement free pmd/pte page interfaces")
> introduced a new location where a pmd was released, but neglected to run
> the pmd page destructor. In fact, this happened previously for a
> different pmd release path and was fixed by commit:
>
> c283610e44ec ("x86, mm: do not leak page->ptl for pmd page tables").
>
> This issue was hidden until recently because the failure mode is silent,
> but commit:
Looks sane. Thanks as always for the thorough changelog and the
investigation into why we're suddenly seeing this now.
I agree that ridding ourselves of open-coded free_page()'s is a good
idea, but this patch itself needs to be around for stable anyway. So,
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
next prev parent reply other threads:[~2021-01-05 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 6:28 [PATCH] x86/mm: Fix leak of pmd ptlock Dan Williams
2020-12-03 6:28 ` Dan Williams
2020-12-03 10:54 ` Peter Zijlstra
2020-12-03 10:54 ` Peter Zijlstra
2020-12-16 3:25 ` Dan Williams
2020-12-16 3:25 ` Dan Williams
2021-01-05 4:18 ` Dan Williams
2021-01-05 4:18 ` Dan Williams
2021-01-05 15:40 ` Dave Hansen [this message]
2021-01-05 15:40 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df5209ad-e527-92ce-52a2-33e1aa9deaff@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.