Re: [PATCH v5 0/2] gpio: mxc: Locking and direction input fix

[Marc Zyngier <maz@kernel.org>]

On 2022-08-23 11:41, Marek Vasut wrote:
> On 7/25/22 17:50, Marc Zyngier wrote:
>> On Mon, 25 Jul 2022 11:34:43 +0100,
>> Marek Vasut <marex@denx.de> wrote:
>>> 
>>> The irqchip callbacks in gpio-mxc perform register read-modify-write 
>>> operations
>>> without locking, which may lead to a race condition. Add the missing 
>>> locking.
>>> 
>>> In case the GPIO is used as IRQ, make sure it is configured as input.
>>> 
>>> Marek Vasut (2):
>>>    gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock
>>>    gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode
>>> 
>>>   drivers/gpio/gpio-mxc.c | 17 ++++++++++++++++-
>>>   1 file changed, 16 insertions(+), 1 deletion(-)
>>> 
>>> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>> Cc: Linus Walleij <linus.walleij@linaro.org>
>>> Cc: Loic Poulain <loic.poulain@linaro.org>
>>> Cc: Marc Zyngier <maz@kernel.org>
>>> Cc: NXP Linux Team <linux-imx@nxp.com>
>>> Cc: Peng Fan <peng.fan@nxp.com>
>>> Cc: Shawn Guo <shawnguo@kernel.org>
>> 
>> Reviewed-by: Marc Zyngier <maz@kernel.org>
> 
> Can these two now be applied or is there something more to do ?

That'd be question for Linus and Bartosz, I guess. From my
own PoV, this is good to go.

Thanks,

      M.
-- 
Jazz is not dead. It just smells funny...