All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@collabora.com>
To: Amin Gattout <amin.gattout@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: add radxa camera 4k on rock 4d
Date: Tue, 29 Sep 2026 14:56:49 +0200	[thread overview]
Message-ID: <e0699ffb-5e73-4fd5-b3e2-79cc7c2d49aa@collabora.com> (raw)
In-Reply-To: <20260925-rock4d-cam4k-v1-1-c9519c794fb3@gmail.com>

Hi Amin,

Thanks for the patch, LGTM!

On 9/25/26 14:16, Amin Gattout wrote:
> Add a device tree overlay for the Radxa Camera 4K (featuring the Sony
> IMX415 image sensor) to be applied on the Radxa ROCK 4D camera
> connector. The camera connects to CSI HOST1 through the MIPI D-PHY0
> in full mode.
> 
> Signed-off-by: Amin Gattout <amin.gattout@gmail.com>

Reviewed-by: Michael Riesch <michael.riesch@collabora.com>

Best regards,
Michael

> ---
>  arch/arm64/boot/dts/rockchip/Makefile              |   5 +
>  .../dts/rockchip/rk3576-rock-4d-radxa-cam4k.dtso   | 105 +++++++++++++++++++++
>  2 files changed, 110 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index e7936a21c118..82b2afd420d5 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -183,6 +183,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-nanopi-m5.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-nanopi-r76s.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-roc-pc.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-rock-4d.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-rock-4d-radxa-cam4k.dtbo
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3582-radxa-e52c.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-sige7.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-w3.dtb
> @@ -311,6 +312,10 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-evb1-v10-pcie1.dtb
>  rk3576-evb1-v10-pcie1-dtbs := rk3576-evb1-v10.dtb \
>  	rk3576-evb1-v10-pcie1.dtbo
>  
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-rock-4d-radxa-4k-cam.dtb
> +rk3576-rock-4d-radxa-4k-cam-dtbs := rk3576-rock-4d.dtb \
> +	rk3576-rock-4d-radxa-cam4k.dtbo
> +
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb
>  rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \
>  	rk3588-edgeble-neu6a-wifi.dtbo
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-rock-4d-radxa-cam4k.dtso b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d-radxa-cam4k.dtso
> new file mode 100644
> index 000000000000..613a3e351500
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d-radxa-cam4k.dtso
> @@ -0,0 +1,105 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Device tree overlay for the Radxa Camera 4K attached to the camera
> + * connector of the Radxa ROCK 4D.
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/clock/rockchip,rk3576-cru.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/media/video-interfaces.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +
> +&{/} {
> +	savdd_cam: regulator-savdd-cam {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpio = <&gpio3 RK_PD0 GPIO_ACTIVE_HIGH>;
> +		regulator-min-microvolt = <2900000>;
> +		regulator-max-microvolt = <2900000>;
> +		regulator-name = "savdd_cam";
> +		vin-supply = <&vcc_3v3_s0>;
> +	};
> +
> +	sdvdd_cam: regulator-sdvdd-cam {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <1100000>;
> +		regulator-max-microvolt = <1100000>;
> +		regulator-name = "sdvdd_cam";
> +		vin-supply = <&vcc_5v0_device>;
> +	};
> +
> +	siovdd_cam: regulator-siovdd-cam {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		regulator-name = "siovdd_cam";
> +		vin-supply = <&vcc_3v3_s0>;
> +	};
> +};
> +
> +&i2c5 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&i2c5m3_xfer>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +
> +	imx415: camera-sensor@1a {
> +		compatible = "sony,imx415";
> +		reg = <0x1a>;
> +		assigned-clocks = <&cru CLK_MIPI_CAMERAOUT_M1>;
> +		assigned-clock-rates = <37125000>;
> +		avdd-supply = <&savdd_cam>;
> +		clocks = <&cru CLK_MIPI_CAMERAOUT_M1>;
> +		dvdd-supply = <&sdvdd_cam>;
> +		orientation = <2>; /* External */
> +		ovdd-supply = <&siovdd_cam>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&cam_rstn &cam_clk1m0_clk1>;
> +		reset-gpios = <&gpio3 RK_PC7 GPIO_ACTIVE_LOW>;
> +
> +		port {
> +			imx415_output: endpoint {
> +				data-lanes = <1 2 3 4>;
> +				link-frequencies = /bits/ 64 <445500000>;
> +				remote-endpoint = <&csi1_input>;
> +			};
> +		};
> +	};
> +};
> +
> +&pinctrl {
> +	cam {
> +		cam_rstn: cam-rstn-pinctrl {
> +			rockchip,pins = <3 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +};
> +
> +&csi1 {
> +	status = "okay";
> +};
> +
> +&csi1_in {
> +	csi1_input: endpoint {
> +		bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> +		data-lanes = <1 2 3 4>;
> +		link-frequencies = /bits/ 64 <445500000>;
> +		remote-endpoint = <&imx415_output>;
> +	};
> +};
> +
> +&csi_dphy0 {
> +	status = "okay";
> +};
> +
> +&vicap {
> +	status = "okay";
> +};
> +
> +&vicap_mmu {
> +	status = "okay";
> +};
> 
> ---
> base-commit: bd5f485f3f026225b86573e559af0b7254ef4184
> change-id: 20260925-rock4d-cam4k-6e3521c61b55
> prerequisite-change-id: 20260819-rk3576-dphy-2304f848215b:v2
> prerequisite-patch-id: fbe2d84f88709b8bf846debe6b8ce62c4392ca63
> prerequisite-patch-id: 9bce33933ae69e8cc7f7ef2f0d9acb969620bc85
> prerequisite-patch-id: bff0c668524f94b0b7901c682d5ccdccfe18d46e
> prerequisite-patch-id: 8f45701f840680a35e044f43ebd3087282847990
> prerequisite-change-id: 20260825-csi-2-rcv-dts-7712bd834de6:v2
> prerequisite-patch-id: fbe2d84f88709b8bf846debe6b8ce62c4392ca63
> prerequisite-patch-id: 9bce33933ae69e8cc7f7ef2f0d9acb969620bc85
> prerequisite-patch-id: bff0c668524f94b0b7901c682d5ccdccfe18d46e
> prerequisite-patch-id: 8f45701f840680a35e044f43ebd3087282847990
> prerequisite-patch-id: bdbb3e9b072469900cac21031cd799265b52d734
> prerequisite-patch-id: c91ceb74abc8bc79ac036990abdef4cbd7328f97
> prerequisite-change-id: 20260828-vicap-rk3576-6e7118ea0246:v2
> prerequisite-patch-id: fbe2d84f88709b8bf846debe6b8ce62c4392ca63
> prerequisite-patch-id: 9bce33933ae69e8cc7f7ef2f0d9acb969620bc85
> prerequisite-patch-id: bff0c668524f94b0b7901c682d5ccdccfe18d46e
> prerequisite-patch-id: 8f45701f840680a35e044f43ebd3087282847990
> prerequisite-patch-id: bdbb3e9b072469900cac21031cd799265b52d734
> prerequisite-patch-id: c91ceb74abc8bc79ac036990abdef4cbd7328f97
> prerequisite-patch-id: d4120ad9def5effeda632f831b6fd0cd59295285
> prerequisite-patch-id: e0c7e587fcaffe58b61fe78508efccec86dc7c79
> prerequisite-patch-id: 6a87bd22798d58cc8f9b30733f5b28a2fced05c1
> prerequisite-patch-id: a94c687ac3f648079b18dbb5109657fb038bd516
> prerequisite-patch-id: 76e36df1aab8a9853440aa28b4bda528ce2adfd7
> 
> Best regards,
> --  
> Amin Gattout <amin.gattout@gmail.com>
> 



WARNING: multiple messages have this Message-ID (diff)
From: Michael Riesch <michael.riesch@collabora.com>
To: Amin Gattout <amin.gattout@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: add radxa camera 4k on rock 4d
Date: Tue, 29 Sep 2026 14:56:49 +0200	[thread overview]
Message-ID: <e0699ffb-5e73-4fd5-b3e2-79cc7c2d49aa@collabora.com> (raw)
In-Reply-To: <20260925-rock4d-cam4k-v1-1-c9519c794fb3@gmail.com>

Hi Amin,

Thanks for the patch, LGTM!

On 9/25/26 14:16, Amin Gattout wrote:
> Add a device tree overlay for the Radxa Camera 4K (featuring the Sony
> IMX415 image sensor) to be applied on the Radxa ROCK 4D camera
> connector. The camera connects to CSI HOST1 through the MIPI D-PHY0
> in full mode.
> 
> Signed-off-by: Amin Gattout <amin.gattout@gmail.com>

Reviewed-by: Michael Riesch <michael.riesch@collabora.com>

Best regards,
Michael

> ---
>  arch/arm64/boot/dts/rockchip/Makefile              |   5 +
>  .../dts/rockchip/rk3576-rock-4d-radxa-cam4k.dtso   | 105 +++++++++++++++++++++
>  2 files changed, 110 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index e7936a21c118..82b2afd420d5 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -183,6 +183,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-nanopi-m5.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-nanopi-r76s.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-roc-pc.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-rock-4d.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-rock-4d-radxa-cam4k.dtbo
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3582-radxa-e52c.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-sige7.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-w3.dtb
> @@ -311,6 +312,10 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-evb1-v10-pcie1.dtb
>  rk3576-evb1-v10-pcie1-dtbs := rk3576-evb1-v10.dtb \
>  	rk3576-evb1-v10-pcie1.dtbo
>  
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-rock-4d-radxa-4k-cam.dtb
> +rk3576-rock-4d-radxa-4k-cam-dtbs := rk3576-rock-4d.dtb \
> +	rk3576-rock-4d-radxa-cam4k.dtbo
> +
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb
>  rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \
>  	rk3588-edgeble-neu6a-wifi.dtbo
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-rock-4d-radxa-cam4k.dtso b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d-radxa-cam4k.dtso
> new file mode 100644
> index 000000000000..613a3e351500
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d-radxa-cam4k.dtso
> @@ -0,0 +1,105 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Device tree overlay for the Radxa Camera 4K attached to the camera
> + * connector of the Radxa ROCK 4D.
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/clock/rockchip,rk3576-cru.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/media/video-interfaces.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +
> +&{/} {
> +	savdd_cam: regulator-savdd-cam {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpio = <&gpio3 RK_PD0 GPIO_ACTIVE_HIGH>;
> +		regulator-min-microvolt = <2900000>;
> +		regulator-max-microvolt = <2900000>;
> +		regulator-name = "savdd_cam";
> +		vin-supply = <&vcc_3v3_s0>;
> +	};
> +
> +	sdvdd_cam: regulator-sdvdd-cam {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <1100000>;
> +		regulator-max-microvolt = <1100000>;
> +		regulator-name = "sdvdd_cam";
> +		vin-supply = <&vcc_5v0_device>;
> +	};
> +
> +	siovdd_cam: regulator-siovdd-cam {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		regulator-name = "siovdd_cam";
> +		vin-supply = <&vcc_3v3_s0>;
> +	};
> +};
> +
> +&i2c5 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&i2c5m3_xfer>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +
> +	imx415: camera-sensor@1a {
> +		compatible = "sony,imx415";
> +		reg = <0x1a>;
> +		assigned-clocks = <&cru CLK_MIPI_CAMERAOUT_M1>;
> +		assigned-clock-rates = <37125000>;
> +		avdd-supply = <&savdd_cam>;
> +		clocks = <&cru CLK_MIPI_CAMERAOUT_M1>;
> +		dvdd-supply = <&sdvdd_cam>;
> +		orientation = <2>; /* External */
> +		ovdd-supply = <&siovdd_cam>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&cam_rstn &cam_clk1m0_clk1>;
> +		reset-gpios = <&gpio3 RK_PC7 GPIO_ACTIVE_LOW>;
> +
> +		port {
> +			imx415_output: endpoint {
> +				data-lanes = <1 2 3 4>;
> +				link-frequencies = /bits/ 64 <445500000>;
> +				remote-endpoint = <&csi1_input>;
> +			};
> +		};
> +	};
> +};
> +
> +&pinctrl {
> +	cam {
> +		cam_rstn: cam-rstn-pinctrl {
> +			rockchip,pins = <3 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +};
> +
> +&csi1 {
> +	status = "okay";
> +};
> +
> +&csi1_in {
> +	csi1_input: endpoint {
> +		bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> +		data-lanes = <1 2 3 4>;
> +		link-frequencies = /bits/ 64 <445500000>;
> +		remote-endpoint = <&imx415_output>;
> +	};
> +};
> +
> +&csi_dphy0 {
> +	status = "okay";
> +};
> +
> +&vicap {
> +	status = "okay";
> +};
> +
> +&vicap_mmu {
> +	status = "okay";
> +};
> 
> ---
> base-commit: bd5f485f3f026225b86573e559af0b7254ef4184
> change-id: 20260925-rock4d-cam4k-6e3521c61b55
> prerequisite-change-id: 20260819-rk3576-dphy-2304f848215b:v2
> prerequisite-patch-id: fbe2d84f88709b8bf846debe6b8ce62c4392ca63
> prerequisite-patch-id: 9bce33933ae69e8cc7f7ef2f0d9acb969620bc85
> prerequisite-patch-id: bff0c668524f94b0b7901c682d5ccdccfe18d46e
> prerequisite-patch-id: 8f45701f840680a35e044f43ebd3087282847990
> prerequisite-change-id: 20260825-csi-2-rcv-dts-7712bd834de6:v2
> prerequisite-patch-id: fbe2d84f88709b8bf846debe6b8ce62c4392ca63
> prerequisite-patch-id: 9bce33933ae69e8cc7f7ef2f0d9acb969620bc85
> prerequisite-patch-id: bff0c668524f94b0b7901c682d5ccdccfe18d46e
> prerequisite-patch-id: 8f45701f840680a35e044f43ebd3087282847990
> prerequisite-patch-id: bdbb3e9b072469900cac21031cd799265b52d734
> prerequisite-patch-id: c91ceb74abc8bc79ac036990abdef4cbd7328f97
> prerequisite-change-id: 20260828-vicap-rk3576-6e7118ea0246:v2
> prerequisite-patch-id: fbe2d84f88709b8bf846debe6b8ce62c4392ca63
> prerequisite-patch-id: 9bce33933ae69e8cc7f7ef2f0d9acb969620bc85
> prerequisite-patch-id: bff0c668524f94b0b7901c682d5ccdccfe18d46e
> prerequisite-patch-id: 8f45701f840680a35e044f43ebd3087282847990
> prerequisite-patch-id: bdbb3e9b072469900cac21031cd799265b52d734
> prerequisite-patch-id: c91ceb74abc8bc79ac036990abdef4cbd7328f97
> prerequisite-patch-id: d4120ad9def5effeda632f831b6fd0cd59295285
> prerequisite-patch-id: e0c7e587fcaffe58b61fe78508efccec86dc7c79
> prerequisite-patch-id: 6a87bd22798d58cc8f9b30733f5b28a2fced05c1
> prerequisite-patch-id: a94c687ac3f648079b18dbb5109657fb038bd516
> prerequisite-patch-id: 76e36df1aab8a9853440aa28b4bda528ce2adfd7
> 
> Best regards,
> --  
> Amin Gattout <amin.gattout@gmail.com>
> 


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2026-09-29 12:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 12:16 [PATCH] arm64: dts: rockchip: add radxa camera 4k on rock 4d Amin Gattout
2026-09-25 12:16 ` Amin Gattout
2026-09-25 12:26 ` sashiko-bot
2026-09-29 12:56 ` Michael Riesch [this message]
2026-09-29 12:56   ` Michael Riesch
2026-10-05 19:06 ` Heiko Stuebner
2026-10-05 19:06   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0699ffb-5e73-4fd5-b3e2-79cc7c2d49aa@collabora.com \
    --to=michael.riesch@collabora.com \
    --cc=amin.gattout@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.