From: Chris Wilson <chris@chris-wilson.co.uk>
To: Christian Schmidt <schmidt@digadd.de>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] intel-dri: Fix initialization if startup happens in interlaced mode
Date: Mon, 14 Nov 2011 10:10:48 +0000 [thread overview]
Message-ID: <e0d58a$27h259@orsmga002.jf.intel.com> (raw)
In-Reply-To: <4EC031D9.80204@digadd.de>
On Sun, 13 Nov 2011 22:08:41 +0100, Christian Schmidt <schmidt@digadd.de> wrote:
> My EFI BIOS starts the graphics card up in my projector's preferred EDID
> mode, 1080@60i. The Intel driver does not clear the interlaced bit:
>
> #define PIPECONF_PROGRESSIVE (0 << 21)
> #define PIPECONF_INTERLACE_W_FIELD_INDICATION (6 << 21)
> #define PIPECONF_INTERLACE_FIELD_0_ONLY (7 << 21)
>
> Likewise, I suppose that this bit is not set for interlaced modes
> either, however interlaced modes are discarded anyway.
The patch is correct, we do need to clear all 3 bits to restore
progressive mode. However it would be better to add a new
#define PIPECONF_INTERLACE_MASK (7 << 21)
so that we do not confuse clearing all interlace bits with unsetting a
particular mode.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2011-11-14 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 21:08 [PATCH] intel-dri: Fix initialization if startup happens in interlaced mode Christian Schmidt
2011-11-14 10:10 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e0d58a$27h259@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=schmidt@digadd.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.