From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Ben Widawsky <ben@bwidawsk.net>,
Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: Re: [PATCH] drm/i915: enable semaphores on per-device defaults
Date: Mon, 21 Nov 2011 13:08:52 +0000 [thread overview]
Message-ID: <e0d58a$2amtvs@orsmga002.jf.intel.com> (raw)
In-Reply-To: <1321880629-23854-1-git-send-email-eugeni.dodonov@intel.com>
On Mon, 21 Nov 2011 11:03:49 -0200, Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> We should enable semaphores on IVB by default, and on SNB in cases where
> dma remapping is disabled or iommu is not enabled.
>
> v2: adapt patch according to the feedback, and put it in line with Keith's
> rc6 enabling patch.
> ---
> static int
> i915_gem_execbuffer_sync_rings(struct drm_i915_gem_object *obj,
> struct intel_ring_buffer *to)
> @@ -758,7 +780,7 @@ i915_gem_execbuffer_sync_rings(struct drm_i915_gem_object *obj,
> return 0;
>
> /* XXX gpu semaphores are implicated in various hard hangs on SNB */
> - if (INTEL_INFO(obj->base.dev)->gen < 6 || !i915_semaphores)
> + if (INTEL_INFO(obj->base.dev)->gen < 6 || !intel_enable_semaphores(obj->base.dev))
Just merge the generation check into intel_enable_semaphores().
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-11-21 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 13:03 [PATCH] drm/i915: enable semaphores on per-device defaults Eugeni Dodonov
2011-11-21 13:08 ` Chris Wilson [this message]
2011-11-21 16:46 ` Keith Packard
-- strict thread matches above, loose matches on Subject: below --
2011-12-10 0:02 [PATCH 6/8] " Keith Packard
2011-12-10 1:05 ` [PATCH] " Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e0d58a$2amtvs@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.