From: Keith Packard <keithp@keithp.com>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Ben Widawsky <ben@bwidawsk.net>,
Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: Re: [PATCH] drm/i915: enable semaphores on per-device defaults
Date: Mon, 21 Nov 2011 08:46:42 -0800 [thread overview]
Message-ID: <86mxbpift9.fsf@sumi.keithp.com> (raw)
In-Reply-To: <1321880629-23854-1-git-send-email-eugeni.dodonov@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 379 bytes --]
On Mon, 21 Nov 2011 11:03:49 -0200, Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> -unsigned int i915_semaphores __read_mostly = 0;
> +unsigned int i915_semaphores __read_mostly = -1;
That better be signed or it's not going to compare well with -1
Otherwise, this looks good to me.
Reviewed-by: Keith Packard <keithp@keithp.com>
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-11-21 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 13:03 [PATCH] drm/i915: enable semaphores on per-device defaults Eugeni Dodonov
2011-11-21 13:08 ` Chris Wilson
2011-11-21 16:46 ` Keith Packard [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-10 0:02 [PATCH 6/8] " Keith Packard
2011-12-10 1:05 ` [PATCH] " Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86mxbpift9.fsf@sumi.keithp.com \
--to=keithp@keithp.com \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.