Re: [Intel-gfx] [PATCH 1/2] drm/print: Add drm_dbg_ratelimited

["Das, Nirmoy" <nirmoy.das@intel.com>]

Hi Sam,

On 1/17/2023 3:49 PM, Sam Ravnborg wrote:
> Hi Nirmoy
>
> On Tue, Jan 17, 2023 at 12:53:49PM +0100, Nirmoy Das wrote:
>> Add a function for ratelimitted debug print.
>>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> Thanks for adding this.
> The patch as-is is:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>
> It would have been nice to start adding kernel-doc to the
> non-deprecated logging functions. But as everyone else is missing this,
> it is OK that we miss it here.
>
> A couple of nice follow-up patches would be to introduce a KMS variant
> and replace the only user of DRM_DEBUG_KMS_RATELIMITED with the new
> variant and remove the old one.
>
> And maybe even update the remaining *ERROR_RATELIMITED users to a new
> variant - and drop the deprecated ones.


Thanks for reviewing this. I can definitely work on your suggested 
follow-up patches.

Nirmoy

>
> 	Sam
>
>> ---
>>   include/drm/drm_print.h | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
>> index a44fb7ef257f..1d839f507319 100644
>> --- a/include/drm/drm_print.h
>> +++ b/include/drm/drm_print.h
>> @@ -602,6 +602,9 @@ void __drm_err(const char *format, ...);
>>   		drm_dev_printk(drm_ ? drm_->dev : NULL, KERN_DEBUG, fmt, ## __VA_ARGS__);	\
>>   })
>>   
>> +#define drm_dbg_ratelimited(drm, fmt, ...) \
>> +	__DRM_DEFINE_DBG_RATELIMITED(DRIVER, drm, fmt, ## __VA_ARGS__)
>> +
>>   #define drm_dbg_kms_ratelimited(drm, fmt, ...) \
>>   	__DRM_DEFINE_DBG_RATELIMITED(KMS, drm, fmt, ## __VA_ARGS__)
>>   
>> -- 
>> 2.39.0