All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Malek <dan@embeddededge.com>
To: hs@dexn.de
Cc: "linuxppc-dev@ozlabs.org list" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] ppc32: Fix SCC Uart write problem after 2. open()
Date: Tue, 1 Nov 2005 11:08:30 -0500	[thread overview]
Message-ID: <e192e9e7fa764d69dc8e4f4d4391a447@embeddededge.com> (raw)
In-Reply-To: <AHEILKONAKAEJPHNMOPNMEFBCDAA.hs@denx.de>


On Nov 1, 2005, at 2:17 AM, Heiko Schocher wrote:

> The following Patch will fix this problem.

This is wrong.  We should never have to reinitialize the
buffer descriptors (which I see the driver does in some cases)
and we certainly should never have to reinitialize the
SCC or SMC peripherals like this.

Once the driver has initialized the SCC or SMC and set up
the buffer descriptors during kernel start up, it should never
be done again.  The only thing we should do is stop/start
the transmitter or receiver, and they should continue operation
with the next buffer descriptor in the ring.

This patch just covers up a driver bug, find and fix the real bug.

Thanks.

	-- Dan

  reply	other threads:[~2005-11-01 16:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-01  7:17 [PATCH] ppc32: Fix SCC Uart write problem after 2. open() Heiko Schocher
2005-11-01 16:08 ` Dan Malek [this message]
2005-11-03 18:37   ` Heiko Schocher
  -- strict thread matches above, loose matches on Subject: below --
2005-10-31 10:53 Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e192e9e7fa764d69dc8e4f4d4391a447@embeddededge.com \
    --to=dan@embeddededge.com \
    --cc=hs@dexn.de \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.