From: Jie Deng <jie.deng@intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, wsa@kernel.org,
wsa+renesas@sang-engineering.com, mst@redhat.com, arnd@arndb.de,
jasowang@redhat.com, yu1.wang@intel.com, shuo.a.liu@intel.com,
conghui.chen@intel.com, stefanha@redhat.com
Subject: Re: [PATCH v12] i2c: virtio: add a virtio i2c frontend driver
Date: Mon, 5 Jul 2021 11:01:48 +0800 [thread overview]
Message-ID: <e1bcae54-bdbf-6fbd-986d-5c25e1745341@intel.com> (raw)
In-Reply-To: <20210705024340.mb5sv5epxbdatgsg@vireshk-i7>
On 2021/7/5 10:43, Viresh Kumar wrote:
> On 02-07-21, 12:58, Andy Shevchenko wrote:
>> On Fri, Jul 02, 2021 at 04:46:47PM +0800, Jie Deng wrote:
>>> +static int virtio_i2c_complete_reqs(struct virtqueue *vq,
>>> + struct virtio_i2c_req *reqs,
>>> + struct i2c_msg *msgs, int nr,
>>> + bool fail)
>>> +{
>>> + struct virtio_i2c_req *req;
>>> + bool failed = fail;
> Jie, you can actually get rid of this variable too. Jut rename fail to failed
> and everything shall work as you want.
Sure.
WARNING: multiple messages have this Message-ID (diff)
From: Jie Deng <jie.deng@intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: yu1.wang@intel.com, arnd@arndb.de, mst@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, wsa@kernel.org,
wsa+renesas@sang-engineering.com, linux-i2c@vger.kernel.org,
stefanha@redhat.com, shuo.a.liu@intel.com,
conghui.chen@intel.com
Subject: Re: [PATCH v12] i2c: virtio: add a virtio i2c frontend driver
Date: Mon, 5 Jul 2021 11:01:48 +0800 [thread overview]
Message-ID: <e1bcae54-bdbf-6fbd-986d-5c25e1745341@intel.com> (raw)
In-Reply-To: <20210705024340.mb5sv5epxbdatgsg@vireshk-i7>
On 2021/7/5 10:43, Viresh Kumar wrote:
> On 02-07-21, 12:58, Andy Shevchenko wrote:
>> On Fri, Jul 02, 2021 at 04:46:47PM +0800, Jie Deng wrote:
>>> +static int virtio_i2c_complete_reqs(struct virtqueue *vq,
>>> + struct virtio_i2c_req *reqs,
>>> + struct i2c_msg *msgs, int nr,
>>> + bool fail)
>>> +{
>>> + struct virtio_i2c_req *req;
>>> + bool failed = fail;
> Jie, you can actually get rid of this variable too. Jut rename fail to failed
> and everything shall work as you want.
Sure.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-07-05 3:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 8:46 [PATCH v12] i2c: virtio: add a virtio i2c frontend driver Jie Deng
2021-07-02 8:46 ` Jie Deng
2021-07-02 9:58 ` Andy Shevchenko
2021-07-02 9:58 ` Andy Shevchenko
2021-07-02 23:01 ` Wolfram Sang
2021-07-05 2:43 ` Viresh Kumar
2021-07-05 2:43 ` Viresh Kumar
2021-07-05 3:01 ` Jie Deng [this message]
2021-07-05 3:01 ` Jie Deng
2021-07-05 6:21 ` Jie Deng
2021-07-05 6:21 ` Jie Deng
2021-07-05 6:31 ` Viresh Kumar
2021-07-05 6:31 ` Viresh Kumar
2021-07-05 3:46 ` Jie Deng
2021-07-05 3:46 ` Jie Deng
2021-07-05 2:40 ` Viresh Kumar
2021-07-05 2:40 ` Viresh Kumar
2021-07-05 3:45 ` Jie Deng
2021-07-05 3:45 ` Jie Deng
2021-07-05 4:38 ` Viresh Kumar
2021-07-05 4:38 ` Viresh Kumar
2021-07-05 6:22 ` Jie Deng
2021-07-05 6:22 ` Jie Deng
2021-07-05 6:30 ` Viresh Kumar
2021-07-05 6:30 ` Viresh Kumar
2021-07-05 7:13 ` Jie Deng
2021-07-05 7:13 ` Jie Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1bcae54-bdbf-6fbd-986d-5c25e1745341@intel.com \
--to=jie.deng@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=conghui.chen@intel.com \
--cc=jasowang@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=shuo.a.liu@intel.com \
--cc=stefanha@redhat.com \
--cc=viresh.kumar@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=yu1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.