[PATCH v1] platform/surface: surfacepro3_button: Stop setting acpi_device_name()

[PATCH v1] platform/surface: surfacepro3_button: Stop setting acpi_device_name()

[Rafael J. Wysocki]

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Since acpi_device_name() set by the driver is only used for input
class device name initialization and printing a message on probe
success, and SURFACE_BUTTON_DEVICE_NAME can be used instead of it
directly in both cases, make the driver do so and stop setting
acpi_device_name().

No intentional functional impact.

This will facilitate the removal of device_name from struct
acpi_device_pnp in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/platform/surface/surfacepro3_button.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- a/drivers/platform/surface/surfacepro3_button.c
+++ b/drivers/platform/surface/surfacepro3_button.c
@@ -212,11 +212,10 @@ static int surface_button_probe(struct p
 		goto err_free_button;
 	}
 
-	strscpy(acpi_device_name(device), SURFACE_BUTTON_DEVICE_NAME);
 	snprintf(button->phys, sizeof(button->phys), "%s/buttons",
 		 acpi_device_hid(device));
 
-	input->name = acpi_device_name(device);
+	input->name = SURFACE_BUTTON_DEVICE_NAME;
 	input->phys = button->phys;
 	input->id.bustype = BUS_HOST;
 	input->dev.parent = &pdev->dev;
@@ -239,7 +238,7 @@ static int surface_button_probe(struct p
 		goto err_free_button;
 	}
 
-	dev_info(&pdev->dev, "%s [%s]\n", acpi_device_name(device),
+	dev_info(&pdev->dev, SURFACE_BUTTON_DEVICE_NAME " [%s]\n",
 		 acpi_device_bid(device));
 	return 0;
 

Re: [PATCH v1] platform/surface: surfacepro3_button: Stop setting acpi_device_name()

[Chen, Yu C]

On 7/6/2026 8:28 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Since acpi_device_name() set by the driver is only used for input
> class device name initialization and printing a message on probe
> success, and SURFACE_BUTTON_DEVICE_NAME can be used instead of it
> directly in both cases, make the driver do so and stop setting
> acpi_device_name().
> 
> No intentional functional impact.
> 
> This will facilitate the removal of device_name from struct
> acpi_device_pnp in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---

I have not noticed any issues,
(sashiko reported an invalid and unrelated to this patch race of UAF,
which should be gated by evdev->mutex)

Reviewed-by: Chen Yu <yu.c.chen@intel.com>

thanks,
Chenyu

Re: [PATCH v1] platform/surface: surfacepro3_button: Stop setting acpi_device_name()

[Andy Shevchenko]

On Mon, Jul 06, 2026 at 02:28:56PM +0200, Rafael J. Wysocki wrote:

> Since acpi_device_name() set by the driver is only used for input
> class device name initialization and printing a message on probe
> success, and SURFACE_BUTTON_DEVICE_NAME can be used instead of it
> directly in both cases, make the driver do so and stop setting
> acpi_device_name().
> 
> No intentional functional impact.
> 
> This will facilitate the removal of device_name from struct
> acpi_device_pnp in the future.

...

> -	input->name = acpi_device_name(device);
> +	input->name = SURFACE_BUTTON_DEVICE_NAME;
>  	input->phys = button->phys;
>  	input->id.bustype = BUS_HOST;
>  	input->dev.parent = &pdev->dev;

> -	dev_info(&pdev->dev, "%s [%s]\n", acpi_device_name(device),
> +	dev_info(&pdev->dev, SURFACE_BUTTON_DEVICE_NAME " [%s]\n",
>  		 acpi_device_bid(device));

I would keep one place of accessing the definition:

	dev_info(&pdev->dev, "%s [%s]\n", input->name, acpi_device_bid(device));

If we ever change that, we won't need to look at two (or more) places.


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] platform/surface: surfacepro3_button: Stop setting acpi_device_name()

[Rafael J. Wysocki (Intel)]

On Mon, Jul 6, 2026 at 5:46 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Jul 06, 2026 at 02:28:56PM +0200, Rafael J. Wysocki wrote:
>
> > Since acpi_device_name() set by the driver is only used for input
> > class device name initialization and printing a message on probe
> > success, and SURFACE_BUTTON_DEVICE_NAME can be used instead of it
> > directly in both cases, make the driver do so and stop setting
> > acpi_device_name().
> >
> > No intentional functional impact.
> >
> > This will facilitate the removal of device_name from struct
> > acpi_device_pnp in the future.
>
> ...
>
> > -     input->name = acpi_device_name(device);
> > +     input->name = SURFACE_BUTTON_DEVICE_NAME;
> >       input->phys = button->phys;
> >       input->id.bustype = BUS_HOST;
> >       input->dev.parent = &pdev->dev;
>
> > -     dev_info(&pdev->dev, "%s [%s]\n", acpi_device_name(device),
> > +     dev_info(&pdev->dev, SURFACE_BUTTON_DEVICE_NAME " [%s]\n",
> >                acpi_device_bid(device));
>
> I would keep one place of accessing the definition:
>
>         dev_info(&pdev->dev, "%s [%s]\n", input->name, acpi_device_bid(device));
>
> If we ever change that, we won't need to look at two (or more) places.

Yeah, makes sense.  I'll send a v2.