All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tamizh chelvam <tamizhr@codeaurora.org>
To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCHv6 5/9] nl80211: Add netlink attribute to configure TID specific tx rate
Date: Wed, 31 Jul 2019 15:38:35 +0530	[thread overview]
Message-ID: <e306b921ab10228a40eb1958de8e6173@codeaurora.org> (raw)
In-Reply-To: <20190711125442.unlaqjl5nnqgsbod@bars>

On 2019-07-11 18:24, Sergey Matyukevich wrote:
>> Introduce NL80211_TID_ATTR_CONFIG_TX_RATES in nl80211_tid_attr_config
>> to accept data TID specific TX bitrate configuration
>> through NL80211_CMD_SET_TID_CONFIG command. TID for which the
>> this configuration is to be applied is passed in
>> NL80211_TID_ATTR_CONFIG_TID attribute. TX bitrate mask values passed
>> in NL80211_ATTR_TX_RATES attribute and 
>> NL80211_TID_ATTR_CONFIG_TX_RATES
>> attribute will have types of the TX rate should be applied.
>> When the user-space wants this configuration peer specific
>> rather than being applied for all the connected stations,
>> MAC address of the peer can be passed in NL80211_ATTR_MAC attribute.
>> 
>> Driver supporting this feature should advertise
>> NL80211_EXT_FEATURE_PER_TID_TX_BITRATE_MASK and supporting per-STA 
>> data TID
>> TX bitrate configuration should advertise
>> NL80211_EXT_FEATURE_PER_STA_TX_BITRATE_MASK.
>> 
>> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org>
> 
> ...
> 
>>         if (info->attrs[NL80211_ATTR_TX_RATES]) {
>> -               err = nl80211_parse_tx_bitrate_mask(info, 
>> &params.beacon_rate);
>> +               err = nl80211_parse_tx_bitrate_mask(info, info->attrs,
>> +                                                   
>> NL80211_ATTR_TX_RATES,
>> +                                                   
>> &params.beacon_rate);
>>                 if (err)
>>                         return err;
>> 
> 
> Could you please clarify this change of nl80211_parse_tx_bitrate_mask 
> arguments.
> Unless I missing something, the appropriate change for
> nl80211_parse_tx_bitrate_mask
> is not included into this patch set.

Yeah. These arguments are missed in the function definition place:( I 
will fix this rebase issue in next version.

Thanks,
Tamizh.

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Tamizh chelvam <tamizhr@codeaurora.org>
To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCHv6 5/9] nl80211: Add netlink attribute to configure TID specific tx rate
Date: Wed, 31 Jul 2019 15:38:35 +0530	[thread overview]
Message-ID: <e306b921ab10228a40eb1958de8e6173@codeaurora.org> (raw)
In-Reply-To: <20190711125442.unlaqjl5nnqgsbod@bars>

On 2019-07-11 18:24, Sergey Matyukevich wrote:
>> Introduce NL80211_TID_ATTR_CONFIG_TX_RATES in nl80211_tid_attr_config
>> to accept data TID specific TX bitrate configuration
>> through NL80211_CMD_SET_TID_CONFIG command. TID for which the
>> this configuration is to be applied is passed in
>> NL80211_TID_ATTR_CONFIG_TID attribute. TX bitrate mask values passed
>> in NL80211_ATTR_TX_RATES attribute and 
>> NL80211_TID_ATTR_CONFIG_TX_RATES
>> attribute will have types of the TX rate should be applied.
>> When the user-space wants this configuration peer specific
>> rather than being applied for all the connected stations,
>> MAC address of the peer can be passed in NL80211_ATTR_MAC attribute.
>> 
>> Driver supporting this feature should advertise
>> NL80211_EXT_FEATURE_PER_TID_TX_BITRATE_MASK and supporting per-STA 
>> data TID
>> TX bitrate configuration should advertise
>> NL80211_EXT_FEATURE_PER_STA_TX_BITRATE_MASK.
>> 
>> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org>
> 
> ...
> 
>>         if (info->attrs[NL80211_ATTR_TX_RATES]) {
>> -               err = nl80211_parse_tx_bitrate_mask(info, 
>> &params.beacon_rate);
>> +               err = nl80211_parse_tx_bitrate_mask(info, info->attrs,
>> +                                                   
>> NL80211_ATTR_TX_RATES,
>> +                                                   
>> &params.beacon_rate);
>>                 if (err)
>>                         return err;
>> 
> 
> Could you please clarify this change of nl80211_parse_tx_bitrate_mask 
> arguments.
> Unless I missing something, the appropriate change for
> nl80211_parse_tx_bitrate_mask
> is not included into this patch set.

Yeah. These arguments are missed in the function definition place:( I 
will fix this rebase issue in next version.

Thanks,
Tamizh.

  reply	other threads:[~2019-07-31 10:08 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18  5:27 [PATCHv6 0/9] cfg80211/mac80211: Add support for TID specific configuration Tamizh chelvam
2019-06-18  5:27 ` Tamizh chelvam
2019-06-18  5:27 ` [PATCHv6 1/9] nl80211: New netlink command " Tamizh chelvam
2019-06-18  5:27   ` Tamizh chelvam
2019-07-11 12:51   ` Sergey Matyukevich
2019-07-11 12:51     ` Sergey Matyukevich
2019-07-31 10:04     ` Tamizh chelvam
2019-07-31 10:04       ` Tamizh chelvam
2019-07-11 13:13   ` Sergey Matyukevich
2019-07-11 13:13     ` Sergey Matyukevich
2019-07-31  9:19   ` Johannes Berg
2019-07-31  9:19     ` Johannes Berg
2019-07-31 10:28     ` Tamizh chelvam
2019-07-31 10:28       ` Tamizh chelvam
2019-07-31  9:25   ` Johannes Berg
2019-07-31  9:25     ` Johannes Berg
2019-08-10 12:40     ` Tamizh chelvam
2019-08-10 12:40       ` Tamizh chelvam
2019-08-21  7:42       ` Johannes Berg
2019-08-21  7:42         ` Johannes Berg
2019-06-18  5:27 ` [PATCHv6 2/9] nl80211: Add new netlink attribute for TID speicific retry count Tamizh chelvam
2019-06-18  5:27   ` Tamizh chelvam
2019-07-31  9:24   ` Johannes Berg
2019-07-31  9:24     ` Johannes Berg
2019-08-10 12:06     ` Tamizh chelvam
2019-08-10 12:06       ` Tamizh chelvam
2019-08-21  7:41       ` Johannes Berg
2019-08-21  7:41         ` Johannes Berg
2019-06-18  5:27 ` [PATCHv6 3/9] nl80211: Add netlink attribute for AMPDU aggregation enable/disable Tamizh chelvam
2019-06-18  5:27   ` Tamizh chelvam
2019-07-31  9:28   ` Johannes Berg
2019-07-31  9:28     ` Johannes Berg
2019-08-10 12:41     ` Tamizh chelvam
2019-08-10 12:41       ` Tamizh chelvam
2019-06-18  5:27 ` [PATCHv6 4/9] nl80211: Add netlink attribute to enable/disable RTS_CTS Tamizh chelvam
2019-06-18  5:27   ` Tamizh chelvam
2019-06-18  5:27 ` [PATCHv6 5/9] nl80211: Add netlink attribute to configure TID specific tx rate Tamizh chelvam
2019-06-18  5:27   ` Tamizh chelvam
2019-07-11 12:54   ` Sergey Matyukevich
2019-07-11 12:54     ` Sergey Matyukevich
2019-07-31 10:08     ` Tamizh chelvam [this message]
2019-07-31 10:08       ` Tamizh chelvam
2019-07-31  9:32   ` Johannes Berg
2019-07-31  9:32     ` Johannes Berg
2019-06-18  5:27 ` [PATCHv6 6/9] mac80211: Add api to support configuring TID specific configuration Tamizh chelvam
2019-06-18  5:27   ` Tamizh chelvam
2019-07-31  9:34   ` Johannes Berg
2019-07-31  9:34     ` Johannes Berg
2019-06-18  5:27 ` [PATCHv6 7/9] ath10k: Add wmi command support for station specific TID config Tamizh chelvam
2019-06-18  5:27   ` Tamizh chelvam
2019-06-18  5:27 ` [PATCHv6 8/9] ath10k: Add new api to support TID specific configuration Tamizh chelvam
2019-06-18  5:27   ` Tamizh chelvam
2019-06-18  5:27 ` [PATCHv6 9/9] ath10k: Add extended TID configuration support Tamizh chelvam
2019-06-18  5:27   ` Tamizh chelvam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e306b921ab10228a40eb1958de8e6173@codeaurora.org \
    --to=tamizhr@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sergey.matyukevich.os@quantenna.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.